Page MenuHomePhabricator

Support WikiEditor keyboard shortcuts in CodeMirror 6
Closed, DuplicatePublic

Description

In T62928, keyboard shortcuts were implemented for WikiEditor. These are currently available when WikiEditor is used by itself or with CodeMirror 5. CodeMirror 6 support is missing.

Conflicts with CM6 keymap need to be checked. Notably, the shortcut for italic (Ctrl-i) clashes with CodeMirror's selectParentSyntax action – which for wikitext appears to be equivalent to "select all".

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal subscribed.

Sorry I missed this task, and thank you for creating it! I also hope I didn't step one any toes… I've got what I believe to be a fairly robust system in the works for T380913. I hope to have a patch up tomorrow.

Not sure if we want to keep this task here or merge? I hope to have most all feature parity with the 2017 editor. How this reinvented "CSS-only Codex Dialog" works out is yet to be seen, but I digress.

Feel free to merge if that makes sense. I have not been working on this.