Drop support for views/tabs in WikiEditor
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Esanders
	Nov 15 2024, 11:53 AM

Project Tags

Referenced Files

	F57704939: image.png
	Nov 15 2024, 11:53 AM

Subscribers

Description

WikiEditor has a method "addView" which sets up a extra tab, with the default being "Wikitext". ~~This is not used anywhere, and possibly never has been.~~ This code was for a now-deleted feature that was never used in production (see T380034#10378008).

Example:
$('#wpTextbox1').data('wikiEditor-context').fn.addView({name:'new', title: 'New'})

Codesearch: https://codesearch.wmcloud.org/search/?q=addView&files=&excludeFiles=&repos=
Global search: https://global-search.toolforge.org/?q=%5C.addView%5C%28&regex=1&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
[WIP] Remove wikiEditor-ui-view wrapper	TheDJ	mediawiki/extensions/WikiEditor	master	+6 -12
Fix appending of CodeEditor statusbar	TheDJ	mediawiki/extensions/CodeEditor	master	+1 -1
Remove $controls / $tabs / $buttons interfaces	Esanders	mediawiki/extensions/WikiEditor	master	+2 -154

Customize query in gerrit

Event Timeline

Esanders created this task.Nov 15 2024, 11:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2024, 11:53 AM

Change #1091643 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/WikiEditor@master] Remove $controls / $tabs / $buttons interfaces

https://gerrit.wikimedia.org/r/1091643

gerritbot added a project: Patch-For-Review.Nov 15 2024, 12:38 PM

This was used for the tabbed interface, where you had wikitext/preview/changes tabs with live updates. This was developed as part of the original WikiEditor, but never made it to WMF production. The majority of the code was then removed in 2017 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/392899 by @Catrope and @Jdforrester-WMF .

These leftovers seem to have been forgotten, or we didn't want to accidentally break any scripts perhaps that hooked into them.

Aklapper added a project: Technical-Debt.Dec 4 2024, 11:28 AM

Esanders updated the task description. (Show Details)Dec 4 2024, 2:44 PM

As a follow up, we might remove the wrapping ui-view as well, but it can be a separate patch.

Change #1091643 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Remove $controls / $tabs / $buttons interfaces

https://gerrit.wikimedia.org/r/1091643

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2024, 1:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 9 2024, 2:00 PM

In T380034#10378008, @TheDJ wrote:

These leftovers seem to have been forgotten, or we didn't want to accidentally break any scripts perhaps that hooked into them.

I vaguely think it was the latter, but by now they've had a long time to be fixed.

Change #1101924 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/CodeEditor@master] Fix appending of CodeEditor statusbar

https://gerrit.wikimedia.org/r/1101924

Change #1101926 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/WikiEditor@master] [WIP] Remove wikiEditor-ui-view wrapper

https://gerrit.wikimedia.org/r/1101926

In T380034#10394367, @Jdforrester-WMF wrote:

In T380034#10378008, @TheDJ wrote:

These leftovers seem to have been forgotten, or we didn't want to accidentally break any scripts perhaps that hooked into them.

I vaguely think it was the latter, but by now they've had a long time to be fixed.

Yeah it seems that there are quite a few extensions depending on that wrapper providing the border..
https://codesearch.wmcloud.org/search/?q=wikiEditor-ui-view&files=&excludeFiles=&repos=
not sure if it is worth it to rearrange all this.

Nardog subscribed.Dec 20 2024, 5:41 PM

How on earth is the patch still not merged?! We've been missing errors and warnings for weeks!