Page MenuHomePhabricator

This page is using the deprecated ResourceLoader module "mediawiki.Uri" on page load
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • A warning message is printed to the console

What should have happened instead?:

No warning message.
Instead of using mediawiki.Uri we should be using Uri

The deprecation seems to have happened in 3ab92782e3da (cc @Ebrahim @Ladsgroup )
While frontend deprecations are not expected to fix consumers beforehand given this pollutes the console for every page view, I think it's therefore important these modules get updated ASAP (or the deprecation is reversed until this happens) as it makes it harder to see other warnings/errors.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

According to:

Object.keys(mw.loader.moduleRegistry).filter((key)=>mw.loader.getState(key)==='ready' && mw.loader.moduleRegistry[key].dependencies.includes('mediawiki.Uri'))

The modules need to be updated:

Event Timeline

Change #1091774 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Stop using deprecated mediawiki.Uri module

https://gerrit.wikimedia.org/r/1091774

Change #1091774 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Stop using deprecated mediawiki.Uri module

https://gerrit.wikimedia.org/r/1091774

Nikerabbit subscribed.

If it is causing problems, I think it should be reverted. IMHO it's not okay to cause unplanned work for other teams if it can be avoided.

Also, Language and Product Localization will not add tasks tagged with components owned by multiple different teams to our sprints. Separate subtasks will be created if necessary.

Change #1097428 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] WIP: Replace deprecated mediawiki.Uri with native URL API in GrowthExperiments

https://gerrit.wikimedia.org/r/1097428

Change #1099778 had a related patch set uploaded (by FrederikHennecke1; author: FrederikHennecke1):

[mediawiki/extensions/Math@master] Fix for Math Popup not working in newer version of Popup-Extension

https://gerrit.wikimedia.org/r/1099778

Change #1099778 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix for Math Popup not working in newer version of Popup-Extension

https://gerrit.wikimedia.org/r/1099778

Change #1105074 had a related patch set uploaded (by Krinkle; author: FrederikHennecke1):

[mediawiki/extensions/Math@REL1_43] Fix for Math Popup not working in newer version of Popup-Extension

https://gerrit.wikimedia.org/r/1105074

Change #1105074 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_43] Fix for Math Popup not working in newer version of Popup-Extension

https://gerrit.wikimedia.org/r/1105074

Change #1117293 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] SearchSatisfaction: Should not use deprecated mw.Uri library

https://gerrit.wikimedia.org/r/1117293

Change #1119880 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Fixes TypeError: searchSli is not a function

https://gerrit.wikimedia.org/r/1119880

Change #1119880 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Fixes TypeError: searchSli is not a function

https://gerrit.wikimedia.org/r/1119880

Change #1117293 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] SearchSatisfaction: Should not use deprecated mw.Uri library

https://gerrit.wikimedia.org/r/1117293

Change #1121111 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Remove unused library

https://gerrit.wikimedia.org/r/1121111

Change #1121113 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys should not use mediawiki.Uri library

https://gerrit.wikimedia.org/r/1121113

Change #1121111 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove unused mediawiki.Uri library

https://gerrit.wikimedia.org/r/1121111

Change #1125253 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CentralNotice@master] mediawiki.Uri is deprecated, use URL instead

https://gerrit.wikimedia.org/r/1125253

Change #1125257 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] mediawiki.Uri is deprecated, use URL instead

https://gerrit.wikimedia.org/r/1125257

Change #1125665 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ExternalGuidance@master] mediawiki.Uri is deprecated, use URL instead

https://gerrit.wikimedia.org/r/1125665

Change #1125665 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] mediawiki.Uri is deprecated, use URL instead

https://gerrit.wikimedia.org/r/1125665

Change #1141950 had a related patch set uploaded (by Jdlrobson; author: Simon04):

[mediawiki/skins/MinervaNeue@master] Use browser native URL instead of mw.Uri

https://gerrit.wikimedia.org/r/1141950

Change #1125253 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Fixes warning: mediawiki.Uri is deprecated, use URL instead

https://gerrit.wikimedia.org/r/1125253

Change #1141950 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use browser native URL instead of mw.Uri

https://gerrit.wikimedia.org/r/1141950

Jdlrobson-WMF subscribed.

The deprecation warnings are gone on startup on desktop but not on mobile, due to usage by mw.externalguidance.init .

Change #1142685 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ExternalGuidance@master] Drop use of deprecated mw.Uri library

https://gerrit.wikimedia.org/r/1142685

Change #1142685 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Drop use of deprecated mw.Uri library

https://gerrit.wikimedia.org/r/1142685

Jdlrobson-WMF claimed this task.

Thanks everyone for coordinating on this one! There is now no deprecation notice and thus no deprecated libraries on page load!

This is also happening in 1.43.3 (LTS), any chance it can be fixed there too please for LTS users? (I have no idea the convention here, or if my post is appropriate here or should occur elsewhere, apologies in advance if I'm making a misstep by asking here).

@FrozenPlum Hi, it's a perfectly appropriate question :)

This message is only a deprecation warning, and it should not cause any problems for MediaWiki users or site administrators. It's just a signal for extension developers to update their code. If you are experiencing some problems on 1.43 that seem related to this warning, that should not happen, please file a task with more details.

We've merged more than 50 patches to resolve different occurrences of this warning in various places, some of which only landed a month or two ago (see the "Related Objects" below the task description for more). I don't think it's feasible to backport all of them to 1.43, and it would probably be too risky to do that anyway, since they may depend on other changes that are not present in 1.43.