Page MenuHomePhabricator
Create Task
Maniphest T380088

Special:IPContributions and Special:GlobalContributions are listed in Special:SpecialPages for a logged out user
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

The Special:IPContributions and Special:GlobalContributions pages are listed in Special:SpecialPages for a logged out user. These should not be listed here because accessing them requires a specific right. For example, Special:Block is hidden from the list for a logged out user as they don't have the right needed to view the page.

Steps to replicate the issue
  1. Have CheckUser installed
  2. Log out of any account (or use a temporary account)
  3. Visit Special:SpecialPages

What happens:
Special:IPContributions and Special:GlobalContributions are listed in Special:SpecialPages

What should have happened instead:
These pages should not be listed in Special:SpecialPages

Details

SubjectRepoBranchLines +/-
Don't publicly list Special:IPContributions and GlobalContributionsmediawiki/extensions/CheckUsermaster+48 -11
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Fri, Nov 15, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 15, 6:34 PM
Dreamy_Jazz claimed this task.Wed, Nov 20, 3:01 PM
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)).
gerritbot added a comment.Wed, Nov 20, 3:03 PM

Change #1093361 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Don't publicly list IPContributions and GlobalContributions

https://gerrit.wikimedia.org/r/1093361

gerritbot added a project: Patch-For-Review.Wed, Nov 20, 3:03 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Wed, Nov 20, 3:06 PM
Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Wed, Nov 20, 3:21 PM
kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Thu, Nov 21, 9:27 AM
gerritbot added a comment.Thu, Nov 21, 9:47 AM

Change #1093361 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Don't publicly list Special:IPContributions and GlobalContributions

https://gerrit.wikimedia.org/r/1093361

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Thu, Nov 21, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Thu, Nov 21, 10:30 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Fri, Nov 22, 6:46 AM
Djackson-ctr subscribed.

I have verified Special pages for IP Contributions and Global Contributions are not listed in the Special:SpecialPages for logged out users or temporary acccounts.

kostajh closed this task as Resolved.Fri, Nov 22, 7:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits