Page MenuHomePhabricator

When visiting an oldid that can't be found/displayed, MediaWiki shouldn't assume that it's from the Main Page
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

MediaWiki seems to assume that the revision was from the Main Page, and also links to the Main Page's deletion log.

screenshot.png (332×1 px, 66 KB)

What should have happened instead?:

In my opinion, either the notice displayed (missing-revision) should say which page the deleted revision was from (although I assume this may not be possible), or it shouldn't assume what the page's title was at all (unless one was provided in the URL title= parameter).

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

I (re)discovered this bug after clicking on a permalink and finding that the page in question had been deleted. It seems a little misleading to refer to the Main Page, and to link to the Main Page's deletion log, when it seems like in most cases that won't actually be the page that's been deleted.

Event Timeline

This seemed like a known issue to me, and indeed it has been reported a few times in the past, but I like your bug report better, so I'll merge those into here.

Change #1099340 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Differentiate between missing and unknown revision

https://gerrit.wikimedia.org/r/1099340

Change #1099347 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/Wikibase@master] tests: Fix ViewEntityActionTest#testShowNonExistingRevision

https://gerrit.wikimedia.org/r/1099347

One effect of fixing this issue is that title of deleted pages will now be reliably linked to deleted revisions. This may not be expected but probably it is not an issue since it was intended to be so, but just wasn't working.

Change #1099347 abandoned by Ammarpad:

[mediawiki/extensions/Wikibase@master] repo tests: Temporarily skip testShowNonExistingRevision

Reason:

No longer working on this

https://gerrit.wikimedia.org/r/1099347

Change #1099340 abandoned by Ammarpad:

[mediawiki/core@master] Differentiate between missing and unknown revision

Reason:

No longer working on this

https://gerrit.wikimedia.org/r/1099340

Change #1249078 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Sort out handling of diffs with missing revisions

https://gerrit.wikimedia.org/r/1249078

Change #1249078 merged by jenkins-bot:

[mediawiki/core@master] Sort out handling of diffs with missing revisions

https://gerrit.wikimedia.org/r/1249078

matmarex assigned this task to Pppery.