Maniphest T380141

Your template file (/data/project/spamcheck/service.template) contains unknown keys: - extra_args
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Count_Count
	Nov 18 2024, 4:52 AM

Tags

Referenced Files

None

Subscribers

LucasWerkmeister

Description

Steps to replicate the issue (include links if applicable):

Run webservice restart with this service.template file:

backend: kubernetes
type: bookworm
extra_args:
  - ./run.sh
mem: 2Gi
cpu: 2
health-check-path: /healthz

What happens?:

This warning (?) is displayed:

Your template file (/data/project/spamcheck/service.template) contains unknown keys:
- extra_args
Restarting..

What should have happened instead?:

No warning should be displayed. The extra_args entry is essential to specify which script is being run on startup.

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	d/changelog: bump to 0.103.16	repos/cloud/toolforge/webservice-cli!76	dcaro	bump_tools-webservice	main
	functional_tests: add extra_args to the webservice template	repos/cloud/toolforge/toolforge-deploy!603	dcaro	add_extra_args	main
	d/changelog: bump to 0.103.15	repos/cloud/toolforge/webservice-cli!68	dcaro	bump_tools-webservice	main
	Don’t warn about extra_args in service.template	repos/cloud/toolforge/webservice-cli!64	lucaswerkmeister	service-template-unknown-keys	main

Customize query in GitLab

Event Timeline

Count_Count created this task.Nov 18 2024, 4:52 AM

Restricted Application added a project: cloud-services-team. · View Herald TranscriptNov 18 2024, 4:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

lucaswerkmeister opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/64

Don’t warn about extra_args in service.template

LucasWerkmeister claimed this task.Nov 18 2024, 11:12 AM

(Placing the task back up for grabs because the rest is deployment and I have no idea how to do that.)

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/64

Don’t warn about extra_args in service.template

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2024, 1:30 PM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/66

bump tools webservice

dcaro closed https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/66

bump tools webservice

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/68

d/changelog: bump to 0.103.15

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/68

d/changelog: bump to 0.103.15

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2024, 3:30 PM

The fix has been deployed, thanks @LucasWerkmeister !

Thanks for deploying!

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/603

functional_tests: add extra_args to the webservice template

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/webservice-cli/-/merge_requests/76

d/changelog: bump to 0.103.16

dcaro closed https://gitlab.wikimedia.org/repos/cloud/toolforge/webservice-cli/-/merge_requests/76

d/changelog: bump to 0.103.16