Page MenuHomePhabricator
Create Task
Maniphest T380185

Prepare for newer geoip2/geoip2 library
Closed, ResolvedPublic
Actions

Description

Forking from T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs

https://github.com/maxmind/GeoIP2-php/compare/v2.13.0...v3.1.0

Doesn't need doing yet, but after WMF production is on PHP 8.1, we'll want to upgrade geoip2/geoip2 to (at least) v3.1.0 to get PHP 8.4 support/fixes.

https://github.com/maxmind/GeoIP2-php/releases/tag/v3.0.0 requires PHP 8.1

https://github.com/maxmind/GeoIP2-php/releases/tag/v3.1.0 brings in PHP 8.4 fixes

However, 3.0.0 has some breaking changes that may need modifications making for; I don't know if they are relevant to our usages in IPInfo:

  • BREAKING: Read-only properties are now used for the model and record classes rather than magic methods. This significantly improves performance.
  • BREAKING: The raw property on model classess and the record property on record classes have been removed.
  • BREAKING: On GeoIp2\Record\Traits, the deprecated isAnonymousProxy and isSatelliteProvider properties have been removed. -- Neither of these are used in the extension
  • BREAKING: The jsonSerialize output has changed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update geoip2/geoip2 and maxmind/minfraudmediawiki/extensions/DonationInterfacemaster+5 -5
Update geoip2/geoip2 to ^3.2.0mediawiki/extensions/WikimediaEventsmaster+12 -8
Update geoip2/geoip2 to ^3.2.0mediawiki/extensions/IPInfomaster+82 -77
Upgrading geoip2/geoip2 (v2.13.0 => v3.2.0)mediawiki/vendormaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 ResolvedReedyT380185 Prepare for newer geoip2/geoip2 library
 ResolvedKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedtstarlingT292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 ResolvedtstarlingT314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedReedyT311448 Echo PHP 8.1 support
 ResolvedBUG REPORTtstarlingT289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
 ResolvedtstarlingT320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
 ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
 ResolvedDaimonaT311452 Taint Check Plugin release
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
 ResolvedJdforrester-WMFT311463 Re-enable PHP 8.1 CI on Zest
 ResolvedssastryT307632 mediawiki/libs/Zest phan issues under 8.1
 ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
 ResolvedkostajhT321691 StructuredDiscussions support for PHP 8.1
 ResolvedthiemowmdeT321692 FileImporter support for PHP 8.1
 ResolvedtstarlingT322098 GeoData support for PHP 8.1
 ResolvedtstarlingT322099 TwoColConflict support for PHP 8.1
 ResolvedBUG REPORTLucas_Werkmeister_WMDET319219 Wikibase gives deprecated warnings on php 8.1
 ResolvedhooT301249 Handle deprecation of Serializable interface in Wikibase
 ResolvedhooT305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
 ResolvedJdforrester-WMFT322233 PageViewInfo support for PHP 8.1
 ResolvedthiemowmdeT322408 CirrusSearch support for PHP 8.1
 ResolvedkostajhT322838 PageTriage PHP 8.1 support
 ResolvedUmherirrenderT323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
 ResolvedPRODUCTION ERROR• brookeT289189 getid3: PHP Warning: Division by zero
 ResolvedTheresNoTimeT332356 function strftime() is deprecated in php 8.1 used by Calendar extension
 ResolvedtstarlingT322278 MediaWiki core should pass Phan on PHP 8.1
 ResolvedJdforrester-WMFT320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 instead of PHP 7.4
 Resolved• larissagauliaT321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
 ResolvedJMeybohmT345561 Upgrade the MediaWiki servers to ICU 67
 ResolvedMoritzMuehlenhoffT350767 Rebuild PHP 7.4 packages for Bullseye
 ResolvedNoneT373752 Build php-uuid package, and add to WMF production and CI
 DuplicateNoneT378043 Route requests with PHP_ENGINE=8.1 cookie to "next" deployment via ATS plugin
 ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
 ResolvedPRODUCTION ERRORReedyT379834 PHP Deprecated: Automatic conversion of false to array is deprecated
 ResolvedPRODUCTION ERRORNoneT384851 PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
 ResolvedPRODUCTION ERROR• mszaboT384853 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERROR• mszaboT384854 PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERROR• mszaboT384858 PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORNoneT384867 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT384879 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERROR• mszaboT384906 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORNoneT384963 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385028 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385061 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385170 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385169 PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORhasharT385143 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT384694 TypeError: Argument 1 passed to MediaWiki\Extension\Notifications\Api\ApiEchoMute::parsePref() must be of the type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.13/extensions/Echo/includes/Api/ApiEchoMute.php on l
 ResolvedPRODUCTION ERRORReedyT385201 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORthiemowmdeT385268 ArgumentCountError: array_merge() does not accept unknown named parameters
 ResolvedPRODUCTION ERRORReedyT385267 PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT385269 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT385331 PHP Deprecated: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORTacsipacsiT385332 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT385333 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385335 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT385452 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT385460 PHP Deprecated: Brick\Math\BigInteger implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)
 ResolvedPRODUCTION ERRORdcausseT385519 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERROR• mszaboT385567 PHP Warning: Undefined array key 1 in ParsoidRenderID
 ResolvedPRODUCTION ERROR• mszaboT385568 InvalidArgumentException: Bad key: -1" OR 2+583-583-1=0+0+0+1 --
ResolvedPRODUCTION ERRORReedyT385588 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT385758 PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT385762 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT385763 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORjijikiT385395 503 error when edit large size pages on PHP 8.1
 ResolvedScott_FrenchT386006 Update PCRE in PHP 8.1 images to PCRE 10.39 or newer
 ResolvedPRODUCTION ERRORABreault-WMFT384738 TypeError: preg_match() expects parameter 2 to be string, null given
 ResolvedPRODUCTION ERRORdanielT387397 PHP Warning: Attempt to read property "text" on null
 ResolvedPRODUCTION ERRORReedyT387489 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT388069 PHP Deprecated: Implicit conversion from float 143204.63041730312 to int loses precision
 ResolvedPRODUCTION ERRORReedyT388073 PHP Deprecated: Automatic conversion of false to array is deprecated
 ResolvedPRODUCTION ERRORihurbainT388160 TypeError: array_map(): Argument #2 ($array) must be of type array, string given
 ResolvedPRODUCTION ERRORJdforrester-WMFT388255 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT388317 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT388322 PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT388339 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT388355 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT388464 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via ImageMap/InputBox)
 ResolvedPRODUCTION ERRORReedyT388466 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via FeaturedFeeds)
 ResolvedPRODUCTION ERRORReedyT388468 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via CentralNoticeCampaignLogPager)
 ResolvedPRODUCTION ERRORReedyT388469 PHP Deprecated: Automatic conversion of false to array is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT388474 PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT388728 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
 DuplicatePRODUCTION ERRORNoneT388729 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT388812 PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT388814 PHP Warning: Undefined array key "view"
 ResolvedPRODUCTION ERRORReedyT388820 PHP Deprecated: preg_replace_callback(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORReedyT388821 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
 DuplicatePRODUCTION ERRORNoneT388822 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT388900 PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT388924 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedPRODUCTION ERRORPaladoxT388944 PHP Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT389019 Argument #2 must be of type string, array given in /srv/mediawiki/docroot/wwwportal/w/search-redirect.php
 ResolvedBUG REPORTWargoT391297 www.wiktionary.org and other portals are redirecting searches to wikipedia
 ResolvedPRODUCTION ERRORJdforrester-WMFT389020 PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated (via CampaignLog)
 ResolvedBUG REPORTScott_FrenchT389243 Update Excimer to 1.2.3 in production
 ResolvedPRODUCTION ERRORReedyT389261 PHP Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated
 ResolvedPRODUCTION ERRORReedyT389515 PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used
 ResolvedPRODUCTION ERRORssastryT389642 PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$dsr
 ResolvedPRODUCTION ERRORReedyT388074 PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT391595 RSSParser: PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT391867 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedPRODUCTION ERRORJdforrester-WMFT391871 PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
 ResolvedPRODUCTION ERRORUmherirrenderT391874 PHP Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedLadsgroupT393879 PHP Deprecated: Implicit conversion from float 41.45954849253939 to int loses precision
 ResolvedPRODUCTION ERRORUmherirrenderT396591 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
 ResolvedFeature• bd808T378752 Install PHP 8.1 on deployment-prep bullseye MediaWiki instances
 ResolvedScott_FrenchT383845 MediaWiki on PHP 8.1 production traffic ramp-up
 ResolvedScott_FrenchT377042 Support cookie-driven fractional migration to PHP 8.1 deployments of mw-web and mw-api-ext
 ResolvedScott_FrenchT377040 Turn up PHP 8.1-flavored k8s deployments for all MediaWiki services
 ResolvedKrinkleT377987 Prepare sticky cookie for gradual PHP 8.1 rollout
 ResolvedMSantosT379986 Testing and verification of MediaWiki on PHP 8.1 in mwdebug-next
 ResolvedTgrT383633 Test MediaWiki authentication on PHP 8.1 in mwdebug-next
 ResolvedScott_FrenchT372605 Extend x-wikimedia-debug-routing.lua to support PHP 8.1 mw-debug deployment
 ResolvedScott_FrenchT372604 Turn up PHP 8.1-flavored mw-debug k8s deployment
 ResolveddduvallT370934 Build and publish multiple MediaWiki production images for a given set of PHP versions
 ResolvedClement_GoubertT376895 mw-debug-repl fails with `container mediawiki-pinkunicorn-app is not valid for pod mw-debug.codfw.next-5d785576b4-sq6dv`
 ResolvedScott_FrenchT372602 Prepare PHP 8.1 production images
 ResolvedScott_FrenchT372507 Prepare WMF PHP 8.1 packages for Bullseye
 ResolvedScott_FrenchT372603 Regenerate UcfirstOverrides.php for PHP 7.4 -> 8.1 transition
 ResolvedScott_FrenchT384532 Align mw-on-k8s alerts with PHP 8.1 migration
 ResolvedoriT385199 Gather PHP 8.1 profiling data
ResolvedClement_GoubertT387916 Migrate mw-cron to PHP 8.1
 ResolvedScott_FrenchT387917 Migrate mw-script to PHP 8.1
 In ProgressScott_FrenchT388799 php-wmerrors rsyslog rule selects on php7 only
 ResolvedScott_FrenchT380485 Transition parsoidtest1001 to PHP 8.1
 OpenNoneT386246 Migrate parsoidtest functionality to kubernetes
ResolvedScott_FrenchT390225 Migrate scap's maintenance script invocations to PHP 8.1
 ResolvedScott_FrenchT391057 Turn down MediaWiki image builds for PHP 7.4
 ResolvedScott_FrenchT392938 Remove PHP 7.4 from deployment hosts
 ResolvedScott_FrenchT394556 Clean up UcfirstOverrides.php following PHP 7.4 -> 8.1 transition
 ResolvedScott_FrenchT396903 Rename pages, images, and users to reflect migration to PHP 8.1 (Unicode 14) title-casing behavior
 OpenNoneT397230 Upgrade maxmind/minfraud

Event Timeline

Reedy created this task.Nov 18 2024, 3:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2024, 3:34 PM
Reedy added a subtask: T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.Nov 18 2024, 3:34 PM
Reedy updated the task description. (Show Details)
Reedy mentioned this in T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.
Reedy renamed this task from Prepare for newer geoip libraries to Prepare for newer geoip2/geoip2 library.Nov 18 2024, 3:38 PM
Reedy updated the task description. (Show Details)
Reedy added a parent task: T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.
Reedy updated the task description. (Show Details)Nov 18 2024, 3:45 PM
akosiaris subscribed.Nov 18 2024, 4:02 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Nov 21 2024, 8:15 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.4 support board.Nov 25 2024, 2:54 PM
Krinkle removed a project: PHP 8.1 support.EditedNov 26 2024, 6:02 PM
Krinkle subscribed.

Forking from T379587: PHP 8.4: Implicitly nullable parameter declarations

https://github.com/maxmind/GeoIP2-php/compare/v2.13.0...v3.1.0

Doesn't need doing yet, but after WMF production is on PHP 8.1, we'll want to upgrade geoip2/geoip2 to (at least) v3.1.0 to get PHP 8.4 support/fixes.

https://github.com/maxmind/GeoIP2-php/releases/tag/v3.0.0 requires PHP 8.1

If I understand correctly, this is not an issue under PHP 8.1, so I'll untag as such to keep the PHP 8.1 workboard focussed on tasks that block PHP 8.1 and/or that relate to making it run warning-free for third parties.

I am leaving the task relation to T319432: Migrate WMF production from PHP 7.4 to PHP 8.1 unchanged. But note that this is a parent relation, that is, the geoip2 upgrade can start after the PHP 8.1 upgrade has finished. It is not a dependency or subtask of T319432.

jijiki changed the status of subtask T319432: Migrate WMF production from PHP 7.4 to PHP 8.1 from Stalled to In Progress.Jan 24 2025, 2:18 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 24 2025, 2:18 PM
Jdforrester-WMF mentioned this in T386108: Make PHP 8.4 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Feb 11 2025, 3:32 PM
gerritbot added a comment.Jun 16 2025, 9:53 AM

Change #1159393 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@master] Upgrading geoip2/geoip2 (v2.13.0 => v3.2.0)

https://gerrit.wikimedia.org/r/1159393

gerritbot added a project: Patch-For-Review.Jun 16 2025, 9:53 AM

Change #1159394 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/IPInfo@master] Update geoip2/geoip2 to ^3.2.0

https://gerrit.wikimedia.org/r/1159394

gerritbot added a comment.Jun 16 2025, 11:32 AM

Change #1159414 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WikimediaEvents@master] Update geoip2/geoip2 to ^3.2.0

https://gerrit.wikimedia.org/r/1159414

Reedy added a project: MediaWiki-extensions-WikimediaEvents.Jun 16 2025, 1:51 PM
Krinkle added a comment.EditedJun 17 2025, 4:02 PM
In T380185#10358793, @Krinkle wrote:

[…]
https://github.com/maxmind/GeoIP2-php/releases/tag/v3.0.0 requires PHP 8.1

3.0.0 (2023-12-04)

  • BREAKING: Read-only properties are now used for the model and record classes rather than magic methods. This significantly improves performance.

Shouldn't affect source code, but affects test mocks. I see @Reedy has fixed those already.

  • BREAKING: The raw property on model classes and the record property on record classes have been removed.

The repos that use GeoIp2, per Codesearch are:

  • mediawiki/extensions/IPInfo
  • mediawiki/extensions/WikimediaEvents
  • mediawiki/extensions/DonationInterface

Searching those for >raw and >record yields no code results (Codesearch).

  • BREAKING: On GeoIp2\Record\Traits, the deprecated isAnonymousProxy and isSatelliteProvider properties have been removed.

No refs, LGTM. Codesearch.

  • GeoIp2\WebService\Client methods now throw an InvalidArgumentException […]. Previously, they would make […] throw a GeoIp2\Exception\InvalidRequestException.

No refs, LGTM. Codesearch.

  • BREAKING: The jsonSerialize output has changed.

Hard to be sure since this could be called many layers deep in a random variable passed to json_encode. I don't see any explicit calls to >jsonSerialize in these repos that look like they're passing a GeoIp2 record. And in the calls to json_encode, none of the params look like they're related to geo data.

Codesearch.

gerritbot added a comment.Jun 17 2025, 4:08 PM

Change #1160191 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/DonationInterface@master] Update geoip2/geoip2 to ^3.2.0

https://gerrit.wikimedia.org/r/1160191

Reedy added a comment.Jun 17 2025, 4:09 PM

Regarding the serialisation, I don't see anything obvious where we're saving it anywhere...

Krinkle closed subtask T319432: Migrate WMF production from PHP 7.4 to PHP 8.1 as Resolved.Aug 3 2025, 10:39 PM
• Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 10:20 AM
gerritbot added a comment.Aug 7 2025, 12:19 PM

Change #1159393 merged by Jforrester:

[mediawiki/vendor@master] Upgrading geoip2/geoip2 (v2.13.0 => v3.2.0)

https://gerrit.wikimedia.org/r/1159393

gerritbot added a comment.Aug 7 2025, 12:19 PM

Change #1159394 merged by Jforrester:

[mediawiki/extensions/IPInfo@master] Update geoip2/geoip2 to ^3.2.0

https://gerrit.wikimedia.org/r/1159394

Jdforrester-WMF closed this task as Resolved.Aug 7 2025, 12:25 PM
Jdforrester-WMF assigned this task to Reedy.
gerritbot added a comment.Aug 7 2025, 12:36 PM

Change #1159414 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Update geoip2/geoip2 to ^3.2.0

https://gerrit.wikimedia.org/r/1159414

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 7 2025, 1:00 PM
Krinkle mentioned this in T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.Aug 8 2025, 12:56 AM
OKryva-WMF added a project: OKR-Work.Oct 3 2025, 4:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits