The filter mentioned in T377765#10307225 is set to unprotected

While preparing to run the script on this filter, I found that it may not be a good idea to do after all:

• I checked what filters are protected on enwiki by querying the replicas for IDs of protected filters (af_hidden is 2 or 3). Only filter ID 1165 was found.
• 1165 is the same filter discussed in this thread: https://en.wikipedia.org/wiki/Wikipedia:Edit_filter_noticeboard#c-Ohnoitsjamie-20241109182800-Codename_Noreste-20241108230800
• I looked at the filter history, to check double check that no protected variables were ever added to it, before removing the protected flag
• I found that the filter is no longer in use, with a note explaining that it was accidentally protected: https://en.wikipedia.org/wiki/Special:AbuseFilter/history/1165/diff/prev/34275 (access restricted)
• Running the unprotect maintenance script therefore seems unnecessary and likely to cause confusion

In T380290#10352299, @Tchanders wrote:

• Running the unprotect maintenance script therefore seems unnecessary and likely to cause confusion

Having discussed this on Slack, it was still valuable to run the script, so that the logs wouldn't be "protected". (They are still "hidden", as they were before they were accidentally "protected".)

Diff: https://en.wikipedia.org/wiki/Special:AbuseFilter/history/1165/diff/prev/34484 (access restricted)

Change #1097358 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/AbuseFilter@master] Add documentation about running RemoveProtectedFlagFromFilter

https://gerrit.wikimedia.org/r/1097358

• Any other filters known to be wrongly protected are unprotected

We'll do this by allowing AbuseFilter/maintenance/SearchFilters to search by privacy level.

Change #1097377 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/AbuseFilter@master] maintenance/SearchFilters: Allow searching by privacy level

https://gerrit.wikimedia.org/r/1097377

Change #1097358 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Add documentation about running RemoveProtectedFlagFromFilter

https://gerrit.wikimedia.org/r/1097358

Change #1097377 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] maintenance/SearchFilters: Allow searching by privacy level

https://gerrit.wikimedia.org/r/1097377

• Any other filters known to be wrongly protected are unprotected

We can do this once https://gerrit.wikimedia.org/r/1097377 is deployed everywhere. Moving back to Ready until then.

I checked which filters use protected variables and which are protected, across all wikis. Since there is only one protected variable (user_unnamed_ip) and any user can see which filters are protected, regardless of their rights (T381470), it is safe to share this information here.

Filters that contain a protected variable

Summary: All of these filters contain user_unnamed_ip. They are all protected (see second table), except for one where user_unnamed_ip was in the comments.
Action needed: None

Filters that are protected

Summary: All of these filters are protected. Most currently use user_unnamed_ip. Some don't any more but used to, so are correctly protected. Some are protected but never used user_unnamed_ip, so should be unprotected.

Action needed: See table

Thanks for your work on this!