Page MenuHomePhabricator
Create Task
Maniphest T380304

Wikisource extension: Error: Call to undefined method Wikibase\Client\WikibaseClient::getRestrictedEntityLookup()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   Error: Call to undefined method Wikibase\Client\WikibaseClient::getRestrictedEntityLookup()
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikisource/includes/EditionLookup.php(57)
#0/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikisource/includes/WikibaseClientSiteLinksForItemHandler.php(38)MediaWiki\Extension\Wikisource\EditionLookup::newFromGlobalState(Wikibase\Client\Usage\RedirectTrackingUsageAccumulator)
#1/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikisource/includes/WikibaseClientSiteLinksForItemHandler.php(65)MediaWiki\Extension\Wikisource\WikibaseClientSiteLinksForItemHandler::newFromGlobalState(Wikibase\Client\Usage\RedirectTrackingUsageAccumulator)
#2/srv/mediawiki/php-1.44.0-wmf.4/includes/HookContainer/HookContainer.php(159)MediaWiki\Extension\Wikisource\WikibaseClientSiteLinksForItemHandler::provideSiteLinks(Wikibase\DataModel\Entity\Item, array, Wikibase\Client\Usage\RedirectTrackingUsageAccumulator)
#3/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(113)MediaWiki\HookContainer\HookContainer->run(string, array)
#4/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(104)Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForItem(Wikibase\DataModel\Entity\Item)
#5/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(82)Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForItemId(Wikibase\DataModel\Entity\ItemId)
#6/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/LangLinkHandler.php(267)Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForPageTitle(MediaWiki\Title\Title)
#7/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/LangLinkHandler.php(288)Wikibase\Client\Hooks\LangLinkHandler->getEffectiveRepoLinks(MediaWiki\Title\Title, MediaWiki\Parser\ParserOutput)
#8/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandler.php(87)Wikibase\Client\Hooks\LangLinkHandler->addLinksFromRepository(MediaWiki\Title\Title, MediaWiki\Parser\ParserOutput)
#9/srv/mediawiki/php-1.44.0-wmf.4/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandler.php(68)Wikibase\Client\Hooks\ParserOutputUpdateHookHandler->doContentAlterParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Parser\ParserOutput)
#10/srv/mediawiki/php-1.44.0-wmf.4/includes/HookContainer/HookContainer.php(159)Wikibase\Client\Hooks\ParserOutputUpdateHookHandler->onContentAlterParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Parser\ParserOutput)
#11/srv/mediawiki/php-1.44.0-wmf.4/includes/HookContainer/HookRunner.php(1232)MediaWiki\HookContainer\HookContainer->run(string, array)
#12/srv/mediawiki/php-1.44.0-wmf.4/includes/content/ContentHandler.php(1708)MediaWiki\HookContainer\HookRunner->onContentAlterParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Parser\ParserOutput)
#13/srv/mediawiki/php-1.44.0-wmf.4/includes/content/Renderer/ContentRenderer.php(79)MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#14/srv/mediawiki/php-1.44.0-wmf.4/includes/Revision/RenderedRevision.php(264)MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreCacheRecord, MediaWiki\Parser\ParserOptions, array)
#15/srv/mediawiki/php-1.44.0-wmf.4/includes/Revision/RenderedRevision.php(236)MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#16/srv/mediawiki/php-1.44.0-wmf.4/includes/Revision/RevisionRenderer.php(239)MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#17/srv/mediawiki/php-1.44.0-wmf.4/includes/Revision/RevisionRenderer.php(172)MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, MediaWiki\Parser\ParserOptions, array)
#18[internal function]MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#19/srv/mediawiki/php-1.44.0-wmf.4/includes/Revision/RenderedRevision.php(199)call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#20/srv/mediawiki/php-1.44.0-wmf.4/includes/poolcounter/PoolWorkArticleView.php(106)MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#21/srv/mediawiki/php-1.44.0-wmf.4/includes/poolcounter/PoolWorkArticleViewCurrent.php(123)MediaWiki\PoolCounter\PoolWorkArticleView->renderRevision(null, bool, string)
#22/srv/mediawiki/php-1.44.0-wmf.4/includes/poolcounter/PoolCounterWork.php(171)MediaWiki\PoolCounter\PoolWorkArticleViewCurrent->doWork()
#23/srv/mediawiki/php-1.44.0-wmf.4/includes/page/ParserOutputAccess.php(362)MediaWiki\PoolCounter\PoolCounterWork->execute()
#24/srv/mediawiki/php-1.44.0-wmf.4/includes/page/Article.php(828)MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, MediaWiki\Parser\ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, int)
#25/srv/mediawiki/php-1.44.0-wmf.4/includes/page/Article.php(547)Article->generateContentOutput(MediaWiki\User\User, MediaWiki\Parser\ParserOptions, int, MediaWiki\Output\OutputPage, array)
#26/srv/mediawiki/php-1.44.0-wmf.4/includes/actions/ViewAction.php(78)Article->view()
#27/srv/mediawiki/php-1.44.0-wmf.4/includes/actions/ActionEntryPoint.php(733)ViewAction->show()
#28/srv/mediawiki/php-1.44.0-wmf.4/includes/actions/ActionEntryPoint.php(510)MediaWiki\Actions\ActionEntryPoint->performAction(Article, MediaWiki\Title\Title)
#29/srv/mediawiki/php-1.44.0-wmf.4/includes/actions/ActionEntryPoint.php(146)MediaWiki\Actions\ActionEntryPoint->performRequest()
#30/srv/mediawiki/php-1.44.0-wmf.4/includes/MediaWikiEntryPoint.php(200)MediaWiki\Actions\ActionEntryPoint->execute()
#31/srv/mediawiki/php-1.44.0-wmf.4/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#32/srv/mediawiki/w/index.php(3)require(string)
#33{main}
Impact

So far 9 occurrences, all from https://ht.wikisource.org (with different pages).

Notes

I assume this is an outcome of 6c426967c7e21f42b696d7d9bd0beefed55b6f8d / T279069
Wondering if @seanleong-WMDE or @thiemowmde may provide any guidance. Also CC'ing Community-Tech and @Tpt as Wikisource extension stewards listed on https://www.mediawiki.org/wiki/Developers/Maintainers

Details

Request URL
https://ht.wikisource.org/wiki/Paj_Prensipal
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
EditionLookup: Update EntityLookup callsThiemo Kreuz (WMDE)mediawiki/extensions/Wikisourcewmf/1.44.0-wmf.4+6 -2
EditionLookup: Update EntityLookup callsReedymediawiki/extensions/Wikisourcemaster+6 -2
Fix broken call to WikibaseClient::getRestrictedEntityLookupThiemo Kreuz (WMDE)mediawiki/extensions/Wikisourcemaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Aklapper created this task.Nov 19 2024, 5:41 PM
Aklapper triaged this task as Unbreak Now! priority.
Aklapper added a parent task: T375663: 1.44.0-wmf.4 deployment blockers.
TheresNoTime subscribed.Nov 19 2024, 5:43 PM
brennen subscribed.Nov 19 2024, 6:04 PM
brennen added a project: User-brennen.Nov 19 2024, 6:11 PM

This is happening at a fairly low rate, so it seems like it doesn't warrant a rollback but should probably get a fix before we roll forward to group1.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Nov 19 2024, 6:12 PM
brennen added a comment.Nov 19 2024, 6:14 PM

Noting also that if it doesn't get a fix in time for @Aklapper's EU train window, I can pick things up during the US Wednesday workday.

Wargo subscribed.Nov 19 2024, 10:30 PM

This blocks accessing all Wikisource sites!

This patch must be ommited or fixed before deployment.

Aklapper added a comment.EditedNov 19 2024, 10:34 PM

@Wargo: That is already the case. It's blocking further deployment in T375663 in the "Task Graph" above. This issue currently cannot "block accessing all Wikisource sites" though, as the latest version 1.44.0-wmf.4 exposing this problem is currently only deployed on 2 Wikisource sites (ht and ang). All other Wikisource sites still run old 1.44.0-wmf.3 which does not expose this problem. See https://versions.toolforge.org/

Reedy subscribed.EditedNov 20 2024, 2:39 AM

It was caused by rEWBA6c426967c7e2: Fix wikidata entity usage tracking and access count just removing a public static function (arguably an API break)...

Ping T279069: Fix wikidata entity usage tracking and access count, T341957: Wrong number of Wikibase entities in NewPP limit report

gerritbot added a comment.Nov 20 2024, 2:51 AM

Change #1092981 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Wikisource@master] EditionLookup: Update EntityLookup calls

https://gerrit.wikimedia.org/r/1092981

gerritbot added a project: Patch-For-Review.Nov 20 2024, 2:51 AM
Reedy added a project: MediaWiki-extensions-Wikibase-Client.Nov 20 2024, 3:06 AM
Maintenance_bot added a project: Wikidata.Nov 20 2024, 3:29 AM
Restricted Application added a project: wmde-wikidata-tech. · View Herald TranscriptNov 20 2024, 3:29 AM
gerritbot added a comment.Nov 20 2024, 6:32 AM

Change #1093167 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Wikisource@master] Fix broken call to WikibaseClient::getRestrictedEntityLookup

https://gerrit.wikimedia.org/r/1093167

gerritbot added a comment.Nov 20 2024, 6:34 AM

Change #1093167 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Wikisource@master] Fix broken call to WikibaseClient::getRestrictedEntityLookup

Reason:

See I4f212fe.

https://gerrit.wikimedia.org/r/1093167

gerritbot added a comment.Nov 20 2024, 6:38 AM

Change #1093172 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Reedy):

[mediawiki/extensions/Wikisource@wmf/1.44.0-wmf.4] EditionLookup: Update EntityLookup calls

https://gerrit.wikimedia.org/r/1093172

gerritbot added a comment.Nov 20 2024, 6:55 AM

Change #1092981 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] EditionLookup: Update EntityLookup calls

https://gerrit.wikimedia.org/r/1092981

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Nov 20 2024, 7:00 AM
gerritbot added a comment.Nov 20 2024, 9:15 AM

Change #1093172 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@wmf/1.44.0-wmf.4] EditionLookup: Update EntityLookup calls

https://gerrit.wikimedia.org/r/1093172

Stashbot added a comment.Nov 20 2024, 9:20 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-20T09:20:16Z] <aklapper@deploy2002> Started scap sync-world: Backport for [[gerrit:1093172|EditionLookup: Update EntityLookup calls (T380304)]]

Stashbot added a comment.Nov 20 2024, 9:26 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-20T09:26:41Z] <aklapper@deploy2002> aklapper, thiemowmde: Backport for [[gerrit:1093172|EditionLookup: Update EntityLookup calls (T380304)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2024, 9:30 AM
Stashbot added a comment.Nov 20 2024, 9:33 AM

Mentioned in SAL (#wikimedia-operations) [2024-11-20T09:33:49Z] <aklapper@deploy2002> Finished scap sync-world: Backport for [[gerrit:1093172|EditionLookup: Update EntityLookup calls (T380304)]] (duration: 13m 33s)

Aklapper closed this task as Resolved.Nov 20 2024, 9:38 AM
Aklapper assigned this task to Reedy.

Thanks everyone for the quick action! I've backported the fix to 1.44.0-wmf.4 thus I'm resolving this task and will continue with the train.

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19); removed: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Nov 20 2024, 10:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits