Page MenuHomePhabricator

JsonConfig cache key space overlaps between testcommonswiki & commonswiki
Closed, ResolvedPublicBUG REPORT

Description

JsonConfig's internal cache of content data (to avoid repeated remote fetches) is shared, and doesn't include the database name -- this means there is some potential to overlap between Data: pages with the same name on testcommonswiki and commonswiki. Recommend giving them separate cache keys in the $wgJsonConfigs config var.

Followup to T374746

Event Timeline

Change #1092912 had a related patch set uploaded (by Bvibber; author: Bvibber):

[operations/mediawiki-config@master] Separate cache key space for test & production JsonConfig data

https://gerrit.wikimedia.org/r/1092912

bvibber edited projects, added: Charts (Sprint 10); removed: Charts.
bvibber moved this task from Sprint 10 to Sprint 11 on the Charts board.
bvibber edited projects, added: Charts (Sprint 11); removed: Charts (Sprint 10).
bvibber moved this task from Incoming to Doing on the Charts (Sprint 11) board.

Change #1092912 merged by jenkins-bot:

[operations/mediawiki-config@master] Separate cache key space for test & production JsonConfig data

https://gerrit.wikimedia.org/r/1092912

Mentioned in SAL (#wikimedia-operations) [2024-11-19T21:23:24Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1092296|Promote Vector 2022 as default on 3 wikis (T379765)]], [[gerrit:1092912|Separate cache key space for test & production JsonConfig data (T380320)]]

Mentioned in SAL (#wikimedia-operations) [2024-11-19T21:29:13Z] <urbanecm@deploy2002> bvibber, jdlrobson, urbanecm: Backport for [[gerrit:1092296|Promote Vector 2022 as default on 3 wikis (T379765)]], [[gerrit:1092912|Separate cache key space for test & production JsonConfig data (T380320)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-11-19T21:38:02Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1092296|Promote Vector 2022 as default on 3 wikis (T379765)]], [[gerrit:1092912|Separate cache key space for test & production JsonConfig data (T380320)]] (duration: 14m 38s)

CCiufo-WMF triaged this task as High priority.

(resolving as fix was deployed)