Page MenuHomePhabricator

Basic topic selection: Adjust visual style for active filter tags
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
Pginer-WMF
Nov 20 2024, 1:32 PM

Description

In T368422, an initial version was implemented to support basic topic selection in order to customize translation suggestions. Topics are represented by filter tags, and the selected one is shown in an active state. This active state needs some visual adjustments:

  • Background color. Currently, active filter tags use #36c, the Codex color background-color-progressive--active (#233566) should be used instead since it aligns with the active state used for toggle buttons.
  • Border color. Currently, a gray border is used. The Codex color background-color-progressive--active (#233566) should be used instead. As pressed buttons, background and borders using the same color help to create a single pressed surface.

Color references are based on Codex colors. This change applies to filter chips used on both the "Filter status" and the "Adjust suggestions view". Current and proposed examples illustrated below:

Filter status

CurrentProposed
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&active-list.png (568×320 px, 90 KB)
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&active- (3).png (568×320 px, 73 KB)

Adjust suggestions view

CurrentProposed
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&active- (1).png (568×320 px, 45 KB)
bn.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&active-list=suggestions&filter-id=previous-edits&filter-type=automatic&from=en&to=bn&page=List%20of%20cheese%20dishes(Wiki Mobile) (1).png (568×320 px, 45 KB)

Derived Requirements

Requirement 1: Update Active Filter Tag Background Color

  • Update the background color of active filter tags to use the Codex color background-color-progressive--active (#233566) instead of #36c.

Requirement 2: Update Active Filter Tag Border Color

  • Use the Codex color background-color-progressive--active (#233566) for the border of active filter tags, ensuring the border and background create a unified pressed surface.

Requirement 3: Apply Changes to Both "Filter Status" and "Adjust Suggestions View" Sections

  • Implement the updated background and border color changes for active filter tags in both the "Filter status" and "Adjust suggestions view" sections.

Test Cases

Test Case 1: Ensure Changes Are Reflected in "Filter Status" and "Adjust Suggestions View"
  1. Precondition: Access both the "Filter status" and "Adjust suggestions view" sections on the interface.
  2. Select a filter tag in each section to activate it.
  3. Inspect the active filter tags in both sections.
  4. AC1: Confirm that both sections reflect the updated background and border colors for active filter tags for background and border #233566.

QA Results - Test Mobile ContentTranslation

ACStatusDetails
1T380368#10368751

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

SBisson triaged this task as Medium priority.
SBisson moved this task from Backlog to In-progress on the LPL Hypothesis board.

Change #1094008 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Fix filters infochip background and border colors

https://gerrit.wikimedia.org/r/1094008

Reedy renamed this task from Basic topic selection: Adjust visual style for active filter tags to Basic topic selection: Adjust visual style for active filter tags.Nov 21 2024, 8:29 PM
Reedy removed a subscriber: Petar.petkovic.

Change #1094008 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix filters infochip background and border colors

https://gerrit.wikimedia.org/r/1094008

Change #1094472 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241122

https://gerrit.wikimedia.org/r/1094472

Change #1094472 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241125

https://gerrit.wikimedia.org/r/1094472

Nikerabbit set the point value for this task to 1.Nov 26 2024, 8:07 AM

@SBisson Background and border color are set to #233566 for Filter Status and Adjust Suggestion View as seen in the screenshots below. I will move this to sign-off. Thanks for all your work!

Test Result - Test Mobile ContentTranslation

Status: ✅ PASS
Environment: Test Mobile ContentTranslation
OS: macOS Sonoma 15.1
Browser: Chrome 131
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://test.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&from=es&to=en&filter-type=automatic&filter-id=previous-edits

Test Cases

Test Case 1: Ensure Changes Are Reflected in "Filter Status" and "Adjust Suggestions View"
  1. Precondition: Access both the "Filter status" and "Adjust suggestions view" sections on the interface.
  2. Select a filter tag in each section to activate it.
  3. Inspect the active filter tags in both sections.
  4. AC1: Confirm that both sections reflect the updated background and border colors for active filter tags for background and border #233566.
Filter StatusAdjust Suggestion View
2024-11-29_11-06-24.png (1×1 px, 352 KB)
2024-11-29_11-07-27.png (1×2 px, 396 KB)
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.