Page MenuHomePhabricator
Create Task
Maniphest T380466

Make IP info viewable from Special:IPContributions
Closed, ResolvedPublic
Actions

Description

As of now, IP Info can be viewer via Special:Contributions (for IPs and Temporary accounts). Currently, when looking at a temporary account via Special:Contributions, one only sees info about the latest IP. When IPs get revealed, and you open Special:IPContributions to get more info, the IP info cannot be easily accessed.

One can make use of Special:IPInfo and view the data, but this is not really convenient. It would be useful if Special:IPContributions displayed the IP info as well, similar to what Special:Contributions does when viewing info about a legacy IP.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
infobox: Show the IP infobox also for Special:IPContributionsmediawiki/extensions/IPInfomaster+268 -20
ipcontributions: Do IP lookups against an oldid from cu_changesmediawiki/extensions/CheckUsermaster+7 -0
ipcontributions: Refactor permission checks into checkPermissionsmediawiki/extensions/CheckUsermaster+26 -5
infobox: Show the IP infobox also for Special:IPContributionsmediawiki/extensions/IPInfomaster+460 -60
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Nov 21 2024, 12:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2024, 12:12 PM
Urbanecm merged a task: T380465: Make IP info viewable from Special:IPContributions.Nov 21 2024, 12:13 PM
Urbanecm added a subscriber: Urbanecm_WMF.
Urbanecm removed a subscriber: Urbanecm_WMF.
Tchanders added a project: Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).Nov 26 2024, 2:30 PM
kostajh added a subscriber: hector.arroyo.Dec 2 2024, 10:26 AM
hector.arroyo claimed this task.Dec 4 2024, 9:55 AM
hector.arroyo moved this task from Backlog to In Progress on the IP Info board.Dec 4 2024, 3:10 PM
hector.arroyo moved this task from Inbox to In progress on the Temporary accounts board.
hector.arroyo moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.
gerritbot added a comment.Dec 11 2024, 7:39 PM

Change #1102378 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/IPInfo@master] infobox: Show the IP infobox also for Special:IPContributions

https://gerrit.wikimedia.org/r/1102378

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptDec 11 2024, 7:39 PM
gerritbot added a project: Patch-For-Review.Dec 11 2024, 7:39 PM
gerritbot added a comment.Dec 13 2024, 3:41 PM

Change #1102846 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipcontributions: Trigger a new SpecialIPContributionsBeforeMainOutput hook

https://gerrit.wikimedia.org/r/1102846

gerritbot added a comment.Dec 16 2024, 5:29 PM

Change #1102378 abandoned by Harroyo-wmf:

[mediawiki/extensions/IPInfo@master] infobox: Show the IP infobox also for Special:IPContributions

https://gerrit.wikimedia.org/r/1102378

gerritbot added a comment.Dec 16 2024, 6:39 PM

Change #1104713 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/IPInfo@master] infobox: Show the IP infobox also for Special:IPContributions

https://gerrit.wikimedia.org/r/1104713

hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 20 2024, 10:10 AM
hector.arroyo moved this task from Inbox to Engineering on the Trust and Safety Product Team board.
hector.arroyo edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.
hector.arroyo moved this task from Engineering to Inbox on the Trust and Safety Product Team board.Dec 20 2024, 10:12 AM
hector.arroyo edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering).
hector.arroyo added a comment.Dec 20 2024, 1:09 PM

Patches https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1102846 & https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/1104713 are now ready for review

gerritbot added a comment.Dec 20 2024, 3:12 PM

Change #1102846 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipcontributions: Refactor permission checks into checkPermissions

https://gerrit.wikimedia.org/r/1102846

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Dec 20 2024, 4:00 PM
hector.arroyo added a comment.EditedDec 23 2024, 5:02 PM

I'm reworking the implementation so we don't directly pass the IP to perform the lookup for as part of the backend request but with a revId that allows locating it in the DB. That way we don't need to change the signature of methods in the parent IPInfoHandler class.

hector.arroyo moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 23 2024, 5:03 PM
hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Jan 2 2025, 3:40 PM
gerritbot added a comment.Jan 3 2025, 12:51 PM

Change #1106329 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipcontributions: Provide an oldid from cu_changes to be used for the IP lookup

https://gerrit.wikimedia.org/r/1106329

gerritbot added a comment.Jan 7 2025, 10:12 AM

Change #1106329 abandoned by Harroyo-wmf:

[mediawiki/extensions/CheckUser@master] ipcontributions: Do IP lookups against an oldid from cu_changes

Reason:

Not needed

https://gerrit.wikimedia.org/r/1106329

hector.arroyo added a comment.Jan 7 2025, 11:13 AM

After some discussion during the code review, we've decided to rely in a revisionId to get the IPInfo in Special:IPContributions (instead of passing the IP itself for the backend call). The downside is that we'll be showing an error if no edits have been made by a given IP or if the filters used in the page make the list of contirubtions shown empty, but that was already happening for other Contributions pages (there's already a different task to address that: https://phabricator.wikimedia.org/T380221). Therefore, changes in CheckUser are not needed anymore and have been closed.

The changes IPInfo https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/1104713 have been updated to use the revId for the IPContributions page.

hector.arroyo added a comment.Jan 7 2025, 4:40 PM

Chnages updated and ready again for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/1104713.

IPContributions now relies in the backend controller used to query for a given revisionId instead of introducing a new one.

Dreamy_Jazz moved this task from Sprint Chimes (Dec. 9 - Jan. 17) to Sprint Tuba (Jan 20 - Feb 7) on the Trust and Safety Product Sprint board.Jan 15 2025, 2:55 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)); removed Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.
gerritbot added a comment.Jan 21 2025, 10:20 AM

Change #1104713 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] infobox: Show the IP infobox also for Special:IPContributions

https://gerrit.wikimedia.org/r/1104713

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2025, 10:30 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.14; 2025-01-28); removed MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 21 2025, 11:00 AM
hector.arroyo added a comment.Jan 21 2025, 11:33 AM

Change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/1104713 has been merged and is now ready for QA.

hector.arroyo moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 21 2025, 11:34 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 23 2025, 5:06 AM
Djackson-ctr subscribed.

QA is completed... new code changes have been implemented (IP info is now viewable from Special:IPContributions).

kostajh closed this task as Resolved.Jan 23 2025, 7:40 AM
hector.arroyo moved this task from In Progress to Closed on the IP Info board.Jun 3 2025, 11:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits