Page MenuHomePhabricator
Create Task
Maniphest T380492

Remove `GEStructuredTaskRejectionReasonTextInputEnabled` config flag and associated custom text input for the "other"-option when rejecting a structured recommendation
Closed, ResolvedPublic
Actions

Description

That flag and functionality was added in context of T304099: Structured tasks: temporary free text for "other" rejection reason. We clarified that we do not want to enable that again in the future (it is also a trust-and-safety issue). Thus the flag and the functionality of the custom input should be removed.

Acceptance criteria:

  • remove GEStructuredTaskRejectionReasonTextInputEnabled and all the functionality related to the custom text-input, including its handling on the server-side from GrowthExperiments
  • GEStructuredTaskRejectionReasonTextInputEnabled is removed from operations/mediawiki-config
    • it is used in the same "speed-test" files as what is investigated in T379568

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove text input for the "other" option in link and image recommendationsmediawiki/extensions/GrowthExperimentsmaster+38 -283
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 21 2024, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2024, 3:40 PM
Michael triaged this task as Medium priority.Nov 21 2024, 3:41 PM
Michael moved this task from Inbox to Estimated tasks backlog on the Growth-Team board.
KStoller-WMF edited projects, added Growth-Team (Maintenance); removed Growth-Team.Jan 29 2025, 5:49 PM
Michael moved this task from Backlog to Unused code removal on the Growth-Team (Maintenance) board.Jan 29 2025, 8:03 PM
Cyndymediawiksim claimed this task.Mar 6 2025, 10:19 AM
Cyndymediawiksim edited projects, added Growth-Team (Current Sprint); removed Growth-Team (Maintenance).
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Mar 7 2025, 9:19 AM

Change #1125379 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove text input for the "other" option in link and image recommendations

https://gerrit.wikimedia.org/r/1125379

gerritbot added a project: Patch-For-Review.Mar 7 2025, 9:19 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Mar 7 2025, 9:37 AM
Cyndymediawiksim mentioned this in T388502: Rename SelectWithTextInputWidget following removal of text input functionality.Mar 11 2025, 8:49 AM
Cyndymediawiksim mentioned this in T388518: Update schemas to remove other_reason field following GEStructuredTaskRejectionReasonTextInputEnabled removal.Mar 11 2025, 11:20 AM
gerritbot added a comment.Mar 12 2025, 5:33 PM

Change #1125379 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove text input for the "other" option in link and image recommendations

https://gerrit.wikimedia.org/r/1125379

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 12 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2025, 6:31 PM
Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Mar 17 2025, 7:37 AM
Etonkovidova closed this task as Resolved.Mar 25 2025, 10:30 PM
Etonkovidova closed subtask T388502: Rename SelectWithTextInputWidget following removal of text input functionality as Resolved.Apr 1 2025, 1:24 AM
Etonkovidova closed subtask T388518: Update schemas to remove other_reason field following GEStructuredTaskRejectionReasonTextInputEnabled removal as Resolved.Apr 8 2025, 8:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits