Page MenuHomePhabricator
Create Task
Maniphest T380496

Port \GrowthExperiments\Config\ConfigHooks::onPageSaveComplete to PageUpdated event
Closed, InvalidPublic
Actions

Description

As an experiment, the \GrowthExperiments\Config\ConfigHooks::onPageSaveComplete hook should be migrated to use the new PageUpdated event.

Example from the Linter extension: EXP: use new event listener mechanism
TODO: link documentation here

Acceptance criteria:

  • Change the \GrowthExperiments\Config\ConfigHooks::onPageSaveComplete to the PageUpdated event
  • Investigate and document here what would happen if there were a problem with that hook and how we would notice that.
  • (optional) Share any feedback/thoughts/concerns/feelings you may have about how the new system.

Notes:

  • Is that hook defacto part of the legacy CommunityConfiguration 1.0? If so, it might not actually do much in practice.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Port ConfigHooks::onPageSaveComplete to PageUpdated eventCyndywikimemediawiki/extensions/GrowthExperimentsmaster+128 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 21 2024, 3:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2024, 3:59 PM
Michael renamed this task from Port `\GrowthExperiments\Config\ConfigHooks::onPageSaveComplete` to PageUpdated event to Port \GrowthExperiments\Config\ConfigHooks::onPageSaveComplete to PageUpdated event.Nov 21 2024, 4:04 PM
Michael moved this task from Inbox to Maintenance on the Growth-Team board.Nov 21 2024, 4:48 PM
Michael edited projects, added: Growth-Team (Maintenance); removed: Growth-Team.
Michael moved this task from Backlog to Port Hooks to PageUpdated event on the Growth-Team (Maintenance) board.
Cyndymediawiksim claimed this task.Feb 28 2025, 1:10 PM
Cyndymediawiksim edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team (Maintenance).
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Mar 3 2025, 12:38 PM

Change #1124090 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Port ConfigHooks::onPageSaveComplete to PageUpdated event

https://gerrit.wikimedia.org/r/1124090

gerritbot added a project: Patch-For-Review.Mar 3 2025, 12:38 PM
Sgs subscribed.Mar 4 2025, 12:30 PM

Isn't this task already resolved in T384257? Can we mark it as invalid? cc @Michael

Sgs moved this task from Doing to Blocked / Needs Work on the Growth-Team (Current Sprint) board.Mar 4 2025, 12:34 PM
Michael closed this task as Invalid.Mar 4 2025, 2:42 PM
In T380496#10600465, @Sgs wrote:

Isn't this task already resolved in T384257? Can we mark it as invalid? cc @Michael

I agree, that and the changes from T383330, both of which took place after this task was created, mean that this task no longer makes sense. That hook handler is not called anymore. It is just waiting to be deleted in context of T367574: [Epic] Remove code for Special:EditGrowthConfig.

gerritbot added a comment.Mar 4 2025, 5:07 PM

Change #1124090 abandoned by Cyndywikime:

[mediawiki/extensions/GrowthExperiments@master] Port ConfigHooks::onPageSaveComplete to PageUpdated event

Reason:

task already resolved in T384257

https://gerrit.wikimedia.org/r/1124090

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2025, 5:30 PM
gmodena subscribed.Apr 2 2025, 12:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits