Page MenuHomePhabricator
Create Task
Maniphest T380497

Port \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to PageUpdated event
Closed, ResolvedPublic
Actions

Description

As an experiment, the \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete hook should be migrated to use the new PageUpdated event.

Example from the Linter extension: EXP: use new event listener mechanism
TODO: link documentation here

Acceptance criteria:

  • Investigate and document here what would happen if there were a problem with that hook and how we would notice that.
  • Change the \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to the PageUpdated event
  • (optional) Share any feedback/thoughts/concerns/feelings you may have about how the new system.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
refactor: drop needless deferred update in EventSubscribermediawiki/extensions/GrowthExperimentsmaster+15 -18
Migrate PersonalizedPraiseHooks to PageUpdatedEventmediawiki/extensions/GrowthExperimentsmaster+98 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 21 2024, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2024, 4:00 PM
Michael renamed this task from Port `\GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete` to PageUpdated event to Port \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to PageUpdated event.Nov 21 2024, 4:04 PM
Michael moved this task from Inbox to Maintenance on the Growth-Team board.Nov 21 2024, 4:48 PM
Michael edited projects, added Growth-Team (Maintenance); removed Growth-Team.
Michael moved this task from Backlog to Port Hooks to PageUpdated event on the Growth-Team (Maintenance) board.
Cyndymediawiksim claimed this task.Mar 3 2025, 12:41 PM
Cyndymediawiksim edited projects, added Growth-Team (Current Sprint); removed Growth-Team (Maintenance).
Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.Mar 4 2025, 12:39 PM
gerritbot added a comment.Mar 4 2025, 5:38 PM

Change #1124489 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Migrate PersonalizedPraiseHooks to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1124489

gerritbot added a project: Patch-For-Review.Mar 4 2025, 5:38 PM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Mar 4 2025, 5:56 PM
gerritbot added a comment.Mar 17 2025, 9:38 AM

Change #1124489 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Migrate PersonalizedPraiseHooks to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1124489

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 17 2025, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2025, 10:30 AM
Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Mar 17 2025, 1:54 PM
daniel subscribed.Mar 21 2025, 10:21 AM

Is there anything left to do here? Can this task be closed?

Michael closed this task as Resolved.Mar 21 2025, 2:02 PM

I'm not expecting anything more to happen here, let's close it.

Maybe it would be nice to have some metrics in Prometheus to see it actually working, but that's not high enough priority.

gerritbot added a comment.Mar 25 2025, 11:38 AM

Change #1130992 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] refactor: drop needless deferred update in EventSubscriber

https://gerrit.wikimedia.org/r/1130992

gerritbot added a project: Patch-For-Review.Mar 25 2025, 11:38 AM
gerritbot added a comment.Mar 25 2025, 2:15 PM

Change #1130992 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: drop needless deferred update in EventSubscriber

https://gerrit.wikimedia.org/r/1130992

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 25 2025, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits