Page MenuHomePhabricator

Port \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to PageUpdated event
Closed, ResolvedPublic

Description

As an experiment, the \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete hook should be migrated to use the new PageUpdated event.

Example from the Linter extension: EXP: use new event listener mechanism
TODO: link documentation here

Acceptance criteria:

  • Investigate and document here what would happen if there were a problem with that hook and how we would notice that.
  • Change the \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to the PageUpdated event
  • (optional) Share any feedback/thoughts/concerns/feelings you may have about how the new system.

Event Timeline

Michael renamed this task from Port `\GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete` to PageUpdated event to Port \GrowthExperiments\MentorDashboard\PersonalizedPraise\PersonalizedPraiseHooks::onPageSaveComplete to PageUpdated event.Nov 21 2024, 4:04 PM

Change #1124489 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Migrate PersonalizedPraiseHooks to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1124489

Change #1124489 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Migrate PersonalizedPraiseHooks to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1124489

Is there anything left to do here? Can this task be closed?

I'm not expecting anything more to happen here, let's close it.

Maybe it would be nice to have some metrics in Prometheus to see it actually working, but that's not high enough priority.

Change #1130992 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] refactor: drop needless deferred update in EventSubscriber

https://gerrit.wikimedia.org/r/1130992

Change #1130992 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: drop needless deferred update in EventSubscriber

https://gerrit.wikimedia.org/r/1130992