Page MenuHomePhabricator

Update Vector 2022 to use core TypeaheadSearch
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

In T380507 we upstreamed code from TypeaheadSearch to MediaWiki core to allow us to use it in Minerva. We don't want to have two versions of Codex code so we should opt Vector 2022 into the code to ensure it has worked correctly.

User story

As a developer I want a single codebase for typeahead search.

Requirements

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • There should be no change in experience for desktop users.

Acceptance criteria

  • The search form in Vector 2022 is updated so that it triggers the code in core, not the code inside skins.vector.search
  • skins.vector.search is preserved for one deploy cycle to support rollback

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

It should be possible to revert the patch to Vector 2022 to restore the old search.
If we leave the existing skins.vector.search code for one code cycle there should be no caching issue.

Sign off step

  • Make a task for removing the now legacy skins.vector.search module.

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson set the point value for this task to 3.Nov 21 2024, 5:32 PM

(3 assumes that in the event of any unexpected issues we stop working on this and work on a new task to unblock it)

Change #1088637 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Move typeahead search into core

https://gerrit.wikimedia.org/r/1088637

Change #1088637 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] WIP: Move typeahead search into core

Reason:

Abandoning until we are ready to work on it.

https://gerrit.wikimedia.org/r/1088637

I would propose bumping this down to a 2 and then creating a separate ticket for removing the now-legacy code that depends on this one (which I would point as 2-3)

Legacy code would not be removed as part of this ticket due to caching. I added a sign off step with that in mind. I wouldn't be adverse to 2. My thinking for 3 was this is highly visible and a revert would be a pain, so factoring that in to the point score.

Sounds good! I'll never argue against more points haha

Jdlrobson-WMF subscribed.

Per quarterly grooming, this is something we'll likely need to prioritize in Q4 as part of updating Minerva's search component.

Change #1139864 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Vector uses core TypeaheadSearch component

https://gerrit.wikimedia.org/r/1139864

Jdlrobson-WMF raised the priority of this task from Medium to High.May 2 2025, 8:02 AM
Jdlrobson-WMF moved this task from Q4 to Sprint Backlog on the Web-Team board.

Change #1142640 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove module from bundlesize.config.json

https://gerrit.wikimedia.org/r/1142640

Change #1142640 merged by jenkins-bot:

[mediawiki/core@master] Remove module from bundlesize.config.json

https://gerrit.wikimedia.org/r/1142640

Change #1139864 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector uses core TypeaheadSearch component

https://gerrit.wikimedia.org/r/1139864

Jdlrobson-WMF lowered the priority of this task from High to Medium.May 13 2025, 5:16 PM

Jan to read through this and sign off.