Page MenuHomePhabricator

Update Minerva to use new core TypeaheadSearch
Closed, ResolvedPublic3 Estimated Story Points

Description

NOTE: T380325 should be resolved before working on this task

Background

The Minerva skin will be updated to use the new Typeahead search to complete our goal.

User story

As a user I want a consistent search experience across mobile and desktop.

Requirements

The Minerva skin should support the core TypeaheadSearch component behind a feature flag to unify the search experience across mobile and desktop.

  • A feature flag is created and used in minerva
  • Default config uses MobileFrontend search
  • The feature flag is disabled by default.
  • The feature is enabled in beta cluster
  • The mobile site uses core TypeaheadSearch when the feature flag is enabled.

BDD

Scenario: Core TypeaheadSearch is used in Minerva skin
Given I visit the mobile site with the feature flag enabled  
When I tap the search input field  
Then the core TypeaheadSearch component should render

Scenario: Core TypeaheadSearch is used in Minerva skin when logged in
Given I am logged in on the mobile site with the feature flag enabled  
When I tap the search input field  
Then the core TypeaheadSearch component should render

Scenario: Core TypeaheadSearch is used in Vector 2022 skin
Given I visit the Vector 2022 skin with the feature flag enabled  
When I click the search input field  
Then the core TypeaheadSearch component should render

Scenario: Core TypeaheadSearch is used in Vector 2022 skin when logged in
Given I am logged in and using the Vector 2022 skin with the feature flag enabled  
When I click the search input field  
Then the core TypeaheadSearch component should render

Test Steps

Test Case 1: Core TypeaheadSearch is the default in Minerva skin

  1. Visit https://en.m.wikipedia.beta.wmflabs.org while logged out
  2. Tap the search input field
  3. AC1: Confirm the TypeaheadSearch component is used
  1. Log in and return to https://en.m.wikipedia.beta.wmflabs.org
  2. Tap the search input field
  3. AC2: Confirm the TypeaheadSearch component is still used

Test Case 2: Core TypeaheadSearch is the default in Vector 2022 skin

  1. Visit https://en.wikipedia.beta.wmflabs.org?useskin=vector-2022 while logged out
  2. Click the search input field
  3. AC3: Confirm the TypeaheadSearch component is used
  1. Log in and return to https://en.wikipedia.beta.wmflabs.org?useskin=vector-2022
  2. Click the search input field
  3. AC4: Confirm the TypeaheadSearch component is still used

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

Feature flag means no roll back necessary - we will enable this in a follow up.

Sign off

  • Identify any changes we should make to Vector 2022 to improve mobile display.

QA Results - Beta

QA Results - Prod

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson changed the point value for this task from 3 to 5.Nov 21 2024, 5:36 PM

Upped to 5, with new feature flag requirement.

Jdlrobson-WMF subscribed.

Per quarterly grooming, this is something we'll likely need to prioritize in Q4 as part of updating Minerva's search component.

Jdlrobson-WMF moved this task from Sprint Backlog to Q4 on the Web-Team board.

Change #1138764 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Vue TypeaheadSearch replacement

https://gerrit.wikimedia.org/r/1138764

bwang moved this task from Q4 to Sprint Backlog on the Web-Team board.
bwang renamed this task from Update Minerva to use new core Codex TypeaheadSearch to Update Minerva to use new core TypeaheadSearch.May 5 2025, 7:18 PM
bwang updated the task description. (Show Details)

Change #1143691 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Skinning: Allow skins to disable the typeahead search button via parameter

https://gerrit.wikimedia.org/r/1143691

Change #1143691 merged by jenkins-bot:

[mediawiki/core@master] Skinning: Allow skins to disable the typeahead search button via parameter

https://gerrit.wikimedia.org/r/1143691

Change #1138764 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: Feature flagged Vue TypeaheadSearch replacement in Minerva

Reason:

I am now preferring the approach in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1143883?usp=search

https://gerrit.wikimedia.org/r/1138764

Jdlrobson-WMF removed the point value 5 for this task.

We need an updated estimate on this ticket.

Jdlrobson-WMF changed the task status from Open to In Progress.May 12 2025, 5:28 PM
Jdlrobson-WMF raised the priority of this task from Medium to High.
bwang set the point value for this task to 3.May 19 2025, 5:37 PM
bwang moved this task from Q4 to Sprint Backlog on the Web-Team board.

Change #1143881 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Add SearchDialog component

https://gerrit.wikimedia.org/r/1143881

Change #1143883 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use Vue SearchDialog

https://gerrit.wikimedia.org/r/1143883

Jdlrobson-WMF changed the task status from In Progress to Open.May 20 2025, 6:22 PM

Change #1148897 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] WIP: SearchApp supports Dialog component

https://gerrit.wikimedia.org/r/1148897

Change #1143881 abandoned by Jdlrobson:

[mediawiki/core@master] Add SearchDialog component

Reason:

Working on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1148897/3?usp=related-change instead.

https://gerrit.wikimedia.org/r/1143881

Change #1149516 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use Vue SearchDialog/Typehead component in Minerva

https://gerrit.wikimedia.org/r/1149516

Change #1143883 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Use Vue SearchDialog

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1149516

https://gerrit.wikimedia.org/r/1143883

The core patche is now ready for review.

Change #1148897 merged by jenkins-bot:

[mediawiki/core@master] SearchApp switches to Dialog component on mobile

https://gerrit.wikimedia.org/r/1148897

Change #1151812 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable Minerva typeahead search on beta cluster

https://gerrit.wikimedia.org/r/1151812

Bernard to review this morning and I will enable on beta later today.

Change #1149516 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use Vue SearchDialog/Typehead component in Minerva

https://gerrit.wikimedia.org/r/1149516

Jdlrobson-WMF lowered the priority of this task from High to Medium.
Jdlrobson-WMF lowered the priority of this task from Medium to Low.

I'll get this up on the beta cluster for testing and let you know when it's ready.

Change #1151812 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Minerva typeahead search on beta cluster

https://gerrit.wikimedia.org/r/1151812

Mentioned in SAL (#wikimedia-operations) [2025-05-29T20:05:47Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1151812|Enable Minerva typeahead search on beta cluster (T380510)]], [[gerrit:rEFLR1151313712f0|Enable ReadingList special page on test wiki]]

Mentioned in SAL (#wikimedia-operations) [2025-05-29T20:07:45Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1151812|Enable Minerva typeahead search on beta cluster (T380510)]], [[gerrit:rEFLR1151313712f0|Enable ReadingList special page on test wiki]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-05-29T20:16:01Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1151812|Enable Minerva typeahead search on beta cluster (T380510)]], [[gerrit:rEFLR1151313712f0|Enable ReadingList special page on test wiki]] (duration: 10m 13s)

Jdlrobson-WMF raised the priority of this task from Low to Medium.Jun 2 2025, 5:57 PM
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Steps

Test Case 1: Core TypeaheadSearch is the default in Minerva skin

  1. Visit https://en.m.wikipedia.beta.wmflabs.org while logged out
  2. Tap the search input field
  3. AC1: Confirm the TypeaheadSearch component is used

screenshot 385.png (1,175×1,138 px, 268 KB)

  1. Log in and return to https://en.m.wikipedia.beta.wmflabs.org
  2. Tap the search input field
  3. AC2: Confirm the TypeaheadSearch component is still used

screenshot 386.png (1,178×1,198 px, 269 KB)

Test Case 2: Core TypeaheadSearch is the default in Vector 2022 skin

  1. Visit https://en.wikipedia.beta.wmflabs.org?useskin=vector-2022 while logged out
  2. Click the search input field
  3. AC3: Confirm the TypeaheadSearch component is used

screenshot 381.png (1,286×1,138 px, 373 KB)

  1. Log in and return to https://en.wikipedia.beta.wmflabs.org?useskin=vector-2022
  2. Click the search input field
  3. AC4: Confirm the TypeaheadSearch component is still used

screenshot 382.png (1,286×1,138 px, 333 KB)

ovasileva claimed this task.
ovasileva subscribed.

Looks good, resolving!

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Steps

Test Case 1: Core TypeaheadSearch is the default in Minerva skin

  1. Visit https://en.m.wikipedia.beta.wmflabs.org while logged out
  2. Tap the search input field
  3. AC1: Confirm the TypeaheadSearch component is used

screenshot 34.png (1,263×1,096 px, 317 KB)

  1. Log in and return to https://https://test.m.wikipedia.org/wiki/Paris
  2. Tap the search input field
  3. AC2: Confirm the TypeaheadSearch component is still used

screenshot 31.png (1,263×1,096 px, 326 KB)

This was not available on enwiki

Test Case 2: Core TypeaheadSearch is the default in Vector 2022 skin

  1. Visit https://en.wikipedia.beta.wmflabs.org?useskin=vector-2022 while logged out
  2. Click the search input field
  3. AC3: Confirm the TypeaheadSearch component is used

screenshot 33.png (1,263×1,096 px, 344 KB)

  1. Log in and return to https://test.wikipedia.org/wiki/Paris
  2. Click the search input field
  3. AC4: Confirm the TypeaheadSearch component is still used

screenshot 30.png (1,263×1,096 px, 505 KB)

screenshot 32.png (1,263×1,096 px, 387 KB)