AccountVanishRequest locks should always be done on Meta-Wiki
Closed, ResolvedPublic
Actions

Description

It's general custom that account locks are always done on Meta-Wiki to keep the logs for them in a consistent place. Most locks by AccountVanishRequests are done there, but there are several entries in https://en.wikipedia.org/wiki/Special:Log?type=globalauth&user=AccountVanishRequests&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers&wpFormIdentifier=logeventslist, which shouldn't be done.

Steps to reproduce

Create a new account
Open Special:GlobalVanishRequest on any other wiki than the central wiki (defined as metawiki on beta wikis and WMF wikis) using this new account and fill out the form
Notice that the account vanishing is automatically approved
Log into another account and look at the vanishing logs (in the globalauth log type)
See that the log is not on the central wiki but instead on the wiki where the user requested vanishing

Acceptance criteria

Automatically approved account vanishing requests have their log entries stored on the central wiki, defined on WMF wikis as metawiki.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CommonSettings.php: Add $wgCentralAuthAutomaticVanishWiki	operations/mediawiki-config	master	+1 -0
	Execute automatic vanish requests using a job	mediawiki/extensions/CentralAuth	master	+457 -76

Customize query in gerrit

Related Objects

Mentioned In: T398177: 'renameuser' logs for a global rename use actor ID from metawiki instead of the local one when created by the fixStuckGlobalRename.php script
T389585: "JobQueueError: Could not enqueue jobs" when trying to request a global vanish on Beta Cluster

Event Timeline

Pppery created this task.Nov 21 2024, 6:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2024, 6:32 PM

JJMC89 added a project: MediaWiki-extensions-CentralAuth.Nov 21 2024, 6:39 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptNov 21 2024, 6:39 PM

Seddon added a project: Trust and Safety Product Team.Nov 21 2024, 8:01 PM

• larissagaulia moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Nov 22 2024, 3:48 PM

• larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.

A_smart_kitten subscribed.Nov 24 2024, 11:54 AM

Bugreporter moved this task from Backlog to GlobalRename / Vanishing on the MediaWiki-extensions-CentralAuth board.Dec 8 2024, 8:23 AM

Does this mean the local endpoints should be closed? https://en.wikipedia.org/wiki/Wikipedia:Courtesy_vanishing recommends the enwiki version.

No. This request is saying that regardless of what wiki you use to request vanishing on, the lock should be logged on Meta-Wiki.

Amdrel claimed this task.Mar 3 2025, 5:52 PM

From my local testing it seems like the log entry's destination is currently determined by the wiki that the renamer uses to approve the vanish request regardless of which wiki the request was originally made on by the user.

That's fine, except for auto-approvals where the wiki the rename is approved on is the wiki where it was requested.

Understood! Is there any existing mechanism to insert cross-wiki log entries easily? If not, it looks like CentralAuth handles cross-wiki actions (such as renaming users and moving their pages) by scheduling jobs and maybe a similar approach can be used for inserting the log entries for auto-approved vanishes.

Not aware of one.

In T380527#10598126, @Amdrel wrote:

Understood! Is there any existing mechanism to insert cross-wiki log entries easily? If not, it looks like CentralAuth handles cross-wiki actions (such as renaming users and moving their pages) by scheduling jobs and maybe a similar approach can be used for inserting the log entries for auto-approved vanishes.

There is no method currently to create a log entry on any wiki than the current wiki. It is possible to use a job where the job is executed in the context of a different wiki. Examples are in MediaWiki-extensions-CentralAuth as you note.

Amdrel changed the task status from Open to In Progress.Mar 4 2025, 1:48 AM

Change #1124521 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CentralAuth@master] Execute automatic vanish requests using a job

https://gerrit.wikimedia.org/r/1124521

gerritbot added a project: Patch-For-Review.Mar 4 2025, 8:58 PM

The patch I just added moves the execution of the automatic vanish to a job which can be configured to execute on Meta-Wiki.

Change #1124521 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Execute automatic vanish requests using a job

https://gerrit.wikimedia.org/r/1124521

Adding our team tag to be able to perform QA.

Moving to "In Progress" as we still need a config patch to set $wgCentralAuthAutomaticVanishWiki on WMF wikis.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 7 2025, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2025, 12:30 PM

Change #1125497 had a related patch set uploaded (by Amdrel; author: Amdrel):

[operations/mediawiki-config@master] CommonSettings.php: Add $wgCentralAuthAutomaticVanishWiki

https://gerrit.wikimedia.org/r/1125497

gerritbot added a project: Patch-For-Review.Mar 7 2025, 6:36 PM

Change #1125497 merged by jenkins-bot:

[operations/mediawiki-config@master] CommonSettings.php: Add $wgCentralAuthAutomaticVanishWiki

https://gerrit.wikimedia.org/r/1125497

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2025, 4:31 PM

• Dreamy_Jazz moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)) board.Mar 14 2025, 9:49 PM

QA is completed, and the new code has been implemented and is functioning as expected (Automatically approved account vanishing requests will have their log entries stored on the central wiki).