New Linter errors (apparent false positives) as of 21 Nov 2024 MediaWiki update
Open, HighPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Fri, Nov 22, 6:59 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.org/wiki/1995_New_South_Wales_state_election (also the same pages for the 1965, 1968, 1971, 1973, 1976, 1978, 1981, 1984, 1988, 1991, 1995, 2003, 2007, and 2015 elections)
Or to https://en.wikipedia.org/wiki/Template:Tick
Or to https://en.wikipedia.org/wiki/Template:Arbitration_case_implementation_notes
Or to https://en.wikipedia.org/wiki/Template:List_of_oxidation_states_of_the_elements/sandbox

What happens?:
Notice that each page is reporting Linter errors. Neither page was reporting Linter errors yesterday. Neither page has been changed recently, and it does not appear that any transcluded templates or modules or other related code on en.WP has been changed.

If you copy and paste the relevant code into Special:ExpandTemplates, you can see that the expanded code has no Linter errors.

This does not appear to be a case of the job queue finally catching up and re-rendering very stale pages. The Template:Tick page, for example, was edited in June 2023 to remove a Linter bogus image options error and had no Linter errors after that edit.

What should have happened instead?:
No Linter errors should be reported on these pages.

I suspect that a change to MediaWiki code, possible related to parsing include/noinclude tags or the safesubst: function, has led to false positive Linter error detections.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned Here: T380333: CTT midweek deploy

Event Timeline

Jonesey95 created this task.Fri, Nov 22, 6:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 22, 6:59 PM

This was likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1090576
and will also likely be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1094050

I'll check each of the cases listed above individually

λ (master) git co v0.21.0-a6
λ ((v0.21.0-a6)) php bin/parse.php --pageName "Template:Arbitration_case_implementation_notes" --wt2lint < /dev/null

λ ((v0.21.0-a6)) git co v0.21.0-a7
λ ((v0.21.0-a7)) php bin/parse.php --pageName "Template:Arbitration_case_implementation_notes" --wt2lint < /dev/null
{"type":"fostered","dsr":[664,3315,-664,2],"templateInfo":null,"params":[]}

λ ((v0.21.0-a7)) git co master
λ (master) php bin/parse.php --pageName "Template:Arbitration_case_implementation_notes" --wt2lint < /dev/null

λ (master *) git co v0.21.0-a6
λ ((v0.21.0-a6) *) php bin/parse.php --pageName "Template:Tick" --wt2lint < /dev/null

λ ((v0.21.0-a6) *) git co v0.21.0-a7
λ ((v0.21.0-a7) *) php bin/parse.php --pageName "Template:Tick" --wt2lint < /dev/null
{"type":"bogus-image-options","dsr":[0,1022,null,null],"templateInfo":null,"params":{"items":["{{ safesubst:#if:",""]}}

λ ((v0.21.0-a7) *) git checkout master
λ (master *) php bin/parse.php --pageName "Template:Tick" --wt2lint < /dev/null

Yeah, so this was caused by T380333 and will be resolved in next week's train. The fix in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1094050 is already merged

λ (master *) git co v0.21.0-a6                                                 
λ ((v0.21.0-a6) *) php bin/parse.php --pageName "1995_New_South_Wales_state_election" --wt2lint < /dev/null
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_ref-1"}}
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_note-1"}}

λ ((v0.21.0-a6) *) git co v0.21.0-a7
λ ((v0.21.0-a7) *) php bin/parse.php --pageName "1995_New_South_Wales_state_election" --wt2lint < /dev/null
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"tr"}}
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"td"}}
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"td"}}
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"td"}}
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"td"}}
...
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"td"}}
{"type":"stripped-tag","dsr":[12057,15005,null,null],"templateInfo":{"multiPartTemplateBlock":true},"params":{"name":"tr"}}
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_ref-1"}}
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_note-1"}}

λ ((v0.21.0-a7) *) git co master
λ (master *) php bin/parse.php --pageName "1995_New_South_Wales_state_election" --wt2lint < /dev/null
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_ref-1"}}
{"type":"duplicate-ids","dsr":[15194,15257,5,6],"templateInfo":null,"params":{"id":"cite_note-1"}}

ssastry added a project: Parsoid.Fri, Nov 22, 9:18 PM

ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

ssastry moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

Thanks for the quick and detailed attention. I hope the fix works.

Malarz_pl subscribed.Tue, Nov 26, 8:45 PM

New Linter errors (apparent false positives) as of 21 Nov 2024 MediaWiki updateOpen, HighPublicBUG REPORTActions

Description

Related Objects

Event Timeline

New Linter errors (apparent false positives) as of 21 Nov 2024 MediaWiki update
Open, HighPublicBUG REPORT
Actions