SUL2 uses mobile=1 URL param and passes that around as a way to indicate the device that is making the request but SUL3 uses the useformat=mobile|desktop approach. With the introduction of the AuthPreserveQueryParams hook in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1034966 and the way SUL3 currently uses the useformat param (with it being preserved by the hook), sync SUL2 to be compliant with SUL3 in the way they indicate the device making the request.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T345245 Mitigate phase-out of third-party cookies in Wikimedia production | |||
| Resolved | Tgr | T345249 Mitigate phase-out of third-party cookies in CentralAuth | |||
| Resolved | OWresch-WMF | T348388 SUL3: Use a dedicated domain for login and account creation | |||
| Resolved | Tgr | T362713 Implement the new login process which redirects to the central login wiki for showing the login/signup form | |||
| Resolved | DAlangi_WMF | T375788 Implement SUL3 central autologin | |||
| Resolved | DAlangi_WMF | T380646 Centralize SUL2 and SUL3 device detection |
Event Timeline
Comment Actions
Change #1094518 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):
[mediawiki/extensions/CentralAuth@master] Make use of `useformat` query param for device detection
Comment Actions
Change #1094518 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use `useformat` query param for device detection or mobile domain (m.)
Comment Actions
Change #1098622 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.4] Use `useformat` query param for device detection or mobile domain (m.)
Comment Actions
Change #1098623 had a related patch set uploaded (by Gergő Tisza; author: Derick Alangi):
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.5] Use `useformat` query param for device detection or mobile domain (m.)
Comment Actions
Change #1098633 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[operations/mediawiki-config@master] Fix mobile domain logic for login.wikimedia.org
Comment Actions
Change #1098633 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix mobile domain logic for login.wikimedia.org
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-27T22:51:16Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1098633|Fix mobile domain logic for login.wikimedia.org (T380646)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-27T22:56:47Z] <tgr@deploy2002> tgr: Backport for [[gerrit:1098633|Fix mobile domain logic for login.wikimedia.org (T380646)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-27T23:09:24Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1098633|Fix mobile domain logic for login.wikimedia.org (T380646)]] (duration: 18m 07s)
Comment Actions
Change #1098623 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.5] Use `useformat` query param for device detection or mobile domain (m.)
Comment Actions
Change #1098622 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.4] Use `useformat` query param for device detection or mobile domain (m.)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-28T14:23:29Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1098623|Use useformat query param for device detection or mobile domain (m.) (T380646 T375788)]], [[gerrit:1098913|ReportIncident: Enable instrumentation on labs (T372823)]], [[gerrit:1098509|Enable message group subscription feature for some wikis (T372386)]], [[gerrit:1098622|Use useformat query param for device detection or mobile domain (m.) (
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-28T14:28:41Z] <urbanecm@deploy2002> urbanecm, tgr, abi, mszabo: Backport for [[gerrit:1098623|Use useformat query param for device detection or mobile domain (m.) (T380646 T375788)]], [[gerrit:1098913|ReportIncident: Enable instrumentation on labs (T372823)]], [[gerrit:1098509|Enable message group subscription feature for some wikis (T372386)]], [[gerrit:1098622|Use useformat query param for device detection or mobile domain (m.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-11-28T14:54:04Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1098623|Use useformat query param for device detection or mobile domain (m.) (T380646 T375788)]], [[gerrit:1098913|ReportIncident: Enable instrumentation on labs (T372823)]], [[gerrit:1098509|Enable message group subscription feature for some wikis (T372386)]], [[gerrit:1098622|Use useformat query param for device detection or mobile domain (m.)