Allow users to clear locally stored donation history
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	Nov 23 2024, 12:58 AM

Project Tags

Referenced Files

	F58136159: image.png
	Jan 7 2025, 1:31 AM

	F58134796: image.png
	Jan 6 2025, 6:12 PM

	F58116789: image.png
	Jan 4 2025, 1:33 AM

	F57733884: image.png
	Nov 23 2024, 12:58 AM

Subscribers

Description

Background

As part of the Contributions dashboard work T376303, we updated instrumentation to account for user being donor in Android app T376082. Because this was for a temporary experiment, we did not initially add the ability for users to clear their donation history from device.

We also added this instrumentation on iOS, for the Year in Review, so that we could show a "thank you" slide to donors. When we added this tracking on iOS, we were recommended by Legal to allow users to clear their locally stored donation history on device.

We may do a "Year in Review" feature on Android in the future, so it would be wise to keep the local donation history tracking even after the end of the Contributions dashboard experiment, and allow users to clear their history.

Requirements

Ensure local donation storage will continue on even after Contributions dash experiment has ended
Allow logged-in and logged-out users to clear their locally stored donation history
Option to clear donation history should only display to users who have locally stored history availalbe to delete
Confirm with users that this will only apply to donations made from this device
PM - add instructions and update Android FAQ page for how users can clear their donation history

Reference

iOS added this functionality in Settings. It only appears if users have history to delete.

Related Objects

Mentioned Here: T376082: Update instrumentation to account for user being donor in Android app
T376303: [EPIC] Contributions Dashboard Experiment with Donor Inclusion

Event Timeline

HNordeenWMF created this task.Nov 23 2024, 12:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2024, 12:58 AM

Seddon triaged this task as Low priority.Dec 10 2024, 5:23 PM

Seddon moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App board.

Hi here, I've started working on this, can I be assigned to it? This is my draft PR with some questions: https://github.com/wikimedia/apps-android-wikipedia/pull/5196

Hi everyone, this is my first contribution and I have some doubts that cooltey asked me to post here tagging you two @HNordeenWMF @SChekfa-WMF

Here is a screenshot of how I've implemented this:

I saw that the iOS and Android Settings screen have a different UI and the preferences are organized in different sections, how can I know that the way I did is approved by the UX/UI team? And if not, can you please provide me details of how can I implement this in order to be UI-approved? Also, do we need a summary for this preference? If so, what should the text be?

Thank you very much!

HNordeenWMF updated the task description. (Show Details)Jan 6 2025, 6:12 PM

HNordeenWMF updated the task description. (Show Details)

Thanks @cesonha for working on this! That placement looks ok to me and our designer. I'll bring this onto our board, and design and QA will also do a check later on so it will be approved before release.

I updated the requirements on the task to be a bit clearer.
1- We only want this to appear when users do already have local history available to clear, otherwise it should not show
2- on iOS we have a confirmation dialog that comes up after they tap on it, it would be good to replicate that on Android if possible.

No summary is needed.

HNordeenWMF edited projects, added: Wikipedia-Android-App (Android Release - FY2024-25); removed: Wikipedia-Android-App.Jan 6 2025, 6:17 PM

HNordeenWMF moved this task from Epics in Progress to Doing on the Wikipedia-Android-App (Android Release - FY2024-25) board.

Perfect :)
The requirement #1 as you said is already fine in my solution, and I will update the PR with the confirmation dialog as well. As soon as I do that I will update you here in phabricator too!

Just updated the PR and got the dialog working as well :)

Thanks @cesonha ! I'm not able to see the image - could you make sure it's attached? Check the right-hand side of the task in "Referenced files" and attach it. Phabricator sometimes doesn't do this automatically :(