Page MenuHomePhabricator

Make command-line installer to read admin password and install db user password from files
Open, MediumPublicFeature

Description

Author: kacarstensen

Description:
Patch that adds new options to the command line installer

The command-line installer has a dbpassfile option, which can be used to avoid specifying the password for the database user in plaintext on the command line, as one would do with the dbpass option. It would be nice if there were a way to do that for the pass and installdbpass options as well. I've attached a patch against the current git master that does this. I'm running a similar modification on 1.18.2 at my site to get this functionality.


Version: 1.18.x
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=26911

Attached:

Details

Reference
bz36069

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36069.
bzimport added a subscriber: Unknown Object (MLST).

wmf.amgine3691 wrote:

This enhancement is related to #26911.

Kevan, do you have a Labs account to submit this to Gerrit yourself?

Kevan: Thanks for your patch!

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.

(In reply to Kevan Carstensen from comment #0)

Created attachment 10430 [details]
Patch that adds new options to the command line installer

Tried to put the patch into Gerrit via http://tools.wmflabs.org/gerrit-patch-uploader/ but patch needs rework:

patch -p1 < patch
patching file maintenance/install.php
Hunk #1 FAILED at 69.
1 out of 1 hunk FAILED -- saving rejects to file maintenance/install.php.rej
patching file maintenance/install.php
Hunk #1 FAILED at 40.
Hunk #2 succeeded at 60 (offset 6 lines).
Hunk #3 FAILED at 70.
2 out of 3 hunks FAILED -- saving rejects to file maintenance/install.php.rej

Attached:

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:24 PM
Aklapper removed a subscriber: wikibugs-l-list.