Page MenuHomePhabricator

error parameter of History.log in weblinkchecker script is unused
Closed, ResolvedPublic

Description

History class has a log method which is defined as def log(self, url, error, containingPage, archiveURL): but the error parameter is never used because it is overwritten by content of the historyDict.

Event Timeline

Xqt triaged this task as Medium priority.Nov 24 2024, 1:52 PM

Change #1097448 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] cleanup: remove unused 'error' parameter from History.log() method

https://gerrit.wikimedia.org/r/1097448

Change #1097448 merged by jenkins-bot:

[pywikibot/core@master] cleanup: remove unused 'error' parameter from History.log() method

https://gerrit.wikimedia.org/r/1097448