Remove .cache folder and run the server. Hit /api/v1/translation/page-collections
Following error is observed.
/api/v1/translation/page-collections" 500 Internal Server Error <ResponseValidationError: 1 validation errors:
{'type': 'list_type', 'loc': ('response',), 'msg': 'Input should be a valid list', 'input': None}
>This is random because of Modulo 4 check in the lifespan event for the process Id.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ngkountas | T379036 Update cache in a single thread | |||
| Resolved | BUG REPORT | SBisson | T380699 recommendation-api /api/v1/translation/page-collections throws 500 when cache is empty |
Problematic code:
# TODO: Use env variable for number of workers number_of_workers = 4 if worker_id % number_of_workers == 0: # we are using 4
Change #1097181 had a related patch set uploaded (by Santhosh; author: Santhosh):
[research/recommendation-api@master] Make sure application is started with initialized cache
In this patch, I addressed only one isse - The empty cache when application startup.
It seperates the cache filling when application is starting up from periodic updates. Periodic updates can be addressed in a diffrerent patch. If we address the TODO part in the code, it should be fixed.
However, it is very important to have cache filled before the apis start working. So make sure cache is initialized before server startup.
Change #1097181 merged by jenkins-bot:
[research/recommendation-api@master] Make sure application is started with initialized cache
+ Recommendation-API (please add project tags so other people who don't know or don't care about team tags can also find tasks. Thanks!)
Change #1098495 had a related patch set uploaded (by KartikMistry; author: KartikMistry):
[operations/deployment-charts@master] Update recommendation-api to 2024-11-27-065850-production
Change #1098495 merged by jenkins-bot:
[operations/deployment-charts@master] Update recommendation-api to 2024-11-27-065850-production
Mentioned in SAL (#wikimedia-operations) [2024-11-27T15:05:23Z] <kart_> Updated recommendation-api to 2024-11-27-142924-production (T380838, T379036, T380699)
This was deployed. We can now see that the api returns an empty list when no collections exist in the cache (it's the case at the time of writing this).
https://api.wikimedia.org/service/lw/recommendation/api/v1/translation/page-collections
The cache has been empty and the recommendation api collections endpoint has been returning [] for the best part of last week. I'm boldly closing this.