Page MenuHomePhabricator

[components-api, components-cli] deploy-token: separate create from update
Closed, ResolvedPublic

Description

currently, POST /deployment/token is used for both creating the token and refreshing it.

To avoid users accidentally refreshing a valid token (and having to change it wherever they use it), we should separate refreshing the token to use PUT, then make changes in cli the to create a separate update or refresh subcommand, add a confirmation prompt before overwriting an existing token, etc.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
cli: Improve deploy-token command UX and safetyrepos/cloud/toolforge/components-cli!6sstefanovaslavina/refresh-tokenmain
deploy-token: split create/refresh into POST/PUT endpointsrepos/cloud/toolforge/components-api!43sstefanovaslavina/refresh-tokenmain
Customize query in GitLab

Event Timeline

dcaro triaged this task as Medium priority.Nov 25 2024, 11:10 AM
Slst2020 changed the task status from Open to In Progress.Nov 25 2024, 12:25 PM

group_203_bot_4866fc124f4b41659f667468a6115cf3 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/629

components-api: bump to 0.0.71-20241129083321-0a425581

Slst2020 renamed this task from [components-api] deploy-token: separate create from update to [components-api, components-cli] deploy-token: separate create from update.Nov 29 2024, 8:59 AM
dcaro moved this task from In Progress to Done on the Toolforge (Toolforge iteration 18) board.