Page MenuHomePhabricator

"Unterminated string constant" error in IE7 on action=edit
Closed, InvalidPublic

Description

screen shot

seen as a result of 1.20 on wikisource, NOT seen in 1.19 on enwiki:

Follow a redlink to an edit page, e.g https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1

IE7 shows an error window "Unterminated string constant". see screen shot.

Checking web console in Firefox upon loading a redlink edit page shows two errors present on wikisource (1.20) that are not present on enwiki (1.19). see screen shot.

[12:58:21.194] Use of getAttributeNode() is deprecated. Use getAttribute() instead. @ https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1

[12:58:21.225] Use of attributes' specified attribute is deprecated. It always returns true. @ https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1


Version: unspecified
Severity: minor

Attached:

Screen_shot_2012-04-18_at_1.13.53_PM.png (422×652 px, 32 KB)

Details

Reference
bz36074

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36074.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 10432
web console screen shot

attachment Screen shot 2012-04-18 at 1.14.29 PM.png ignored as obsolete

I can't see that error at Google Chrome 18.0.1025.162 for Linux (Ubuntu 10.04.4 LTS).

'getAttributeNode()' and 'specified' problem is wikimedia bits's problem, not mediawiki.
https://bits.wikimedia.org/en.wikisource.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120416T184457Z

And I can't testing first error since I don't have IE7.

The warnings shown in Firefox are not related to MediaWiki and are not important problems. They are from jQuery internally and they will fix it upstream when needed.

The error "Unterminated string constant" shown in IE is not related to the Firefox warning but is a real bug. Rephrasing summary to emphasize that instead.

Note that from looking at the screenshot, it looks like this error is caused by a user script or site script from en.wikisource.org not something we can fix in the software.

There is bad syntax for IE in a local gadget, nothing for bugzilla -> INVALID

https://en.wikisource.org/wiki/MediaWiki:Gadget-Edittools.js contains a extra comma for a array definition.

Remove the comma in the following code snippet:

			$choise.show();
			$sections.not($choise).hide();
		},
 
		/**
		 * Convert the <a onclick> links to buttons in a given section.