Page MenuHomePhabricator
Create Task
Maniphest T380758

Turn on Parsoid Fragments support everywhere
Closed, ResolvedPublic
Actions

Description

(Title was: "Enabling Parsoid Fragments causes 9 round-trip testing regressions")

$ php tools/RegressionTesting.php -u cscott --url https://parsoid-rt-tests.wikimedia.org/regressions/between/9d1bf53d/e7403e6f
...
Pages needing investigation:
hewiki:אוניברסיטת בר-אילן
zhwiki:颱風蘇拉 (2023年)
frwikivoyage:Falmignoul
enwiktionary:a
enwiki:List of Gogglebox Australia episodes
ruwiki:Список футболистов, сыгравших 100 и более матчей за национальную сборную
eswiki:Epidemia_de_coronavirus_de_2020_en_Brasil
ruwiki:Список космических запусков в 2023 году
zhwiki:義大利世界遺產列表

Turning off ParsoidFragmentSupport (https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1096886) fixed the regressions.

Need to figure out what is causing the regression (but probably bad DSR info somewhere).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clean up temporary ParsoidFragmentSupport configuration flagmediawiki/coremaster+56 -170
Bump wikimedia/parsoid to 0.21.0-a22mediawiki/vendormaster+1 K -433
Turn on Parsoid fragment support everywhere (take 2)operations/mediawiki-configmaster+1 -12
Re-enable Parsoid fragment support v2 for RT testingmediawiki/services/parsoidmaster+1 -1
Add template expansion statistics to the Parsoid limit reportmediawiki/coremaster+76 -83
ParsoidFragmentMode: use special 'exttag' strip markermediawiki/coremaster+45 -5
Enable Parsoid Fragment mode on Chart pilot wikisoperations/mediawiki-configmaster+9 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Nov 25 2024, 3:15 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptNov 25 2024, 3:15 PM
MSantos added a project: OKR-Work.Nov 25 2024, 3:39 PM
cscott added a comment.Nov 25 2024, 7:26 PM

Turns out it is related to the expansion size limit: the original article is very very close to the limit, and Parsoid (with the fragments patch) accounts for the size of extension tags in a slightly different way which pushes it over the edge.

gerritbot added a comment.Nov 25 2024, 9:59 PM

Change #1097522 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Add template expansion statistics to the limit report

https://gerrit.wikimedia.org/r/1097522

gerritbot added a project: Patch-For-Review.Nov 25 2024, 9:59 PM
cscott added a parent task: T374616: A flexible fragment type for transclusions.Dec 5 2024, 12:22 AM
cscott mentioned this in T374661: Charts are not compatible with Parsoid - show as raw SVG.
Seddon subscribed.Dec 5 2024, 1:16 AM
gerritbot added a comment.Dec 5 2024, 2:56 AM

Change #1100570 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Enable Parsoid Fragment mode on Chart pilot wikis

https://gerrit.wikimedia.org/r/1100570

Ladsgroup subscribed.Dec 5 2024, 10:42 AM
gerritbot added a comment.Dec 5 2024, 2:56 PM

Change #1100570 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Parsoid Fragment mode on Chart pilot wikis

https://gerrit.wikimedia.org/r/1100570

Stashbot added a comment.Dec 5 2024, 2:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-05T14:58:25Z] <dbrant@deploy2002> Started scap sync-world: Backport for [[gerrit:1100570|Enable Parsoid Fragment mode on Chart pilot wikis (T381436 T381312 T380758)]]

Stashbot mentioned this in T381312: Enable Charts extension on Swedish, Italian, Hebrew Wikipedia.Dec 5 2024, 2:58 PM
Stashbot mentioned this in T381436: Enable Chart extension on mediawiki.org.
Stashbot added a comment.Dec 5 2024, 3:07 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-05T15:06:59Z] <dbrant@deploy2002> dbrant, cscott: Backport for [[gerrit:1100570|Enable Parsoid Fragment mode on Chart pilot wikis (T381436 T381312 T380758)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 5 2024, 3:18 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-05T15:18:16Z] <dbrant@deploy2002> Finished scap sync-world: Backport for [[gerrit:1100570|Enable Parsoid Fragment mode on Chart pilot wikis (T381436 T381312 T380758)]] (duration: 19m 51s)

gerritbot added a comment.Dec 16 2024, 10:00 PM

Change #1104734 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParsoidFragmentMode: use special 'exttag' strip marker

https://gerrit.wikimedia.org/r/1104734

gerritbot added a comment.Dec 16 2024, 11:57 PM

Change #1104734 merged by jenkins-bot:

[mediawiki/core@master] ParsoidFragmentMode: use special 'exttag' strip marker

https://gerrit.wikimedia.org/r/1104734

gerritbot added a comment.Dec 18 2024, 7:53 PM

Change #1097522 merged by jenkins-bot:

[mediawiki/core@master] Add template expansion statistics to the Parsoid limit report

https://gerrit.wikimedia.org/r/1097522

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Dec 18 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 18 2024, 8:30 PM
cscott renamed this task from Enabling Parsoid Fragments causes 9 round-trip testing regressions to Turn on Parsoid Fragments support everywhere.Feb 4 2025, 5:44 PM
cscott updated the task description. (Show Details)
cscott mentioned this in T385716: Parsoid's "include size" accounting differs from legacy.Feb 5 2025, 2:55 PM
cscott added a comment.Feb 8 2025, 12:01 AM

Note that Parsoid fragment support needs to be turned on to support T279094: Support for parser functions using "isHTML"?, which is used in the implementation of the new {{#interwikilink}} parser function, as well as Charts.

cscott mentioned this in T388786: Follow up from Parsoid Fragment support.Mar 13 2025, 1:12 PM
cscott added a parent task: T388786: Follow up from Parsoid Fragment support.
cscott added a subtask: T387608: Parsoid's Fragment Mode support doesn't process strip markers recursively inside StripMarker::split.
cscott added a subtask: T388819: Arguments with <nowiki> lose <span typeof="mw:Nowiki"> in parsoid output.Mar 13 2025, 8:46 PM
cscott closed subtask T388819: Arguments with <nowiki> lose <span typeof="mw:Nowiki"> in parsoid output as Resolved.Mar 14 2025, 8:34 PM
gerritbot added a comment.Mar 20 2025, 3:50 PM

Change #1129876 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Re-enable Parsoid fragment support v2 for RT testing

https://gerrit.wikimedia.org/r/1129876

gerritbot added a project: Patch-For-Review.Mar 20 2025, 3:50 PM
gerritbot added a comment.Mar 20 2025, 7:55 PM

Change #1129876 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Re-enable Parsoid fragment support v2 for RT testing

https://gerrit.wikimedia.org/r/1129876

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2025, 8:30 PM
cscott added a parent task: T389545: Variables in Parsoid content show older values compared to legacy.Mar 20 2025, 10:42 PM
gerritbot added a comment.Mar 24 2025, 4:42 AM

Change #1130343 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on Parsoid fragment support everywhere (take 2)

https://gerrit.wikimedia.org/r/1130343

gerritbot added a project: Patch-For-Review.Mar 24 2025, 4:42 AM
gerritbot added a comment.Mar 24 2025, 11:13 AM

Change #1130555 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a22

https://gerrit.wikimedia.org/r/1130555

gerritbot added a comment.Mar 24 2025, 1:25 PM

Change #1130343 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid fragment support everywhere (take 2)

https://gerrit.wikimedia.org/r/1130343

Stashbot added a comment.Mar 24 2025, 1:33 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-24T13:33:27Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1130343|Turn on Parsoid fragment support everywhere (take 2) (T374661 T380758 T389545 T387608)]], [[gerrit:1130560|Do not throw an exception after shared-domain login with no token (T362715)]], [[gerrit:1130561|Do not start central login from the shared domain (T362715)]]

Stashbot mentioned this in T387608: Parsoid's Fragment Mode support doesn't process strip markers recursively inside StripMarker::split.Mar 24 2025, 1:33 PM
Stashbot mentioned this in T389545: Variables in Parsoid content show older values compared to legacy.
Stashbot mentioned this in T362715: Move credentials change to central domain.
Stashbot added a comment.Mar 24 2025, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-24T13:37:04Z] <tgr@deploy1003> tgr, cscott: Backport for [[gerrit:1130343|Turn on Parsoid fragment support everywhere (take 2) (T374661 T380758 T389545 T387608)]], [[gerrit:1130560|Do not throw an exception after shared-domain login with no token (T362715)]], [[gerrit:1130561|Do not start central login from the shared domain (T362715)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 24 2025, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-24T13:54:09Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1130343|Turn on Parsoid fragment support everywhere (take 2) (T374661 T380758 T389545 T387608)]], [[gerrit:1130560|Do not throw an exception after shared-domain login with no token (T362715)]], [[gerrit:1130561|Do not start central login from the shared domain (T362715)]] (duration: 20m 42s)

gerritbot added a comment.Mar 24 2025, 4:31 PM

Change #1130555 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a22

https://gerrit.wikimedia.org/r/1130555

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2025, 5:31 PM
gerritbot added a comment.Mar 25 2025, 7:29 PM

Change #1131080 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Clean up temporary ParsoidFragmentSupport configuration flag

https://gerrit.wikimedia.org/r/1131080

gerritbot added a project: Patch-For-Review.Mar 25 2025, 7:29 PM
cscott mentioned this in T382524: IncubatorWiki: Parsoid's display title computation adds a namespace prefix where legacy parser does not.Mar 27 2025, 6:04 PM
ssastry closed subtask T387608: Parsoid's Fragment Mode support doesn't process strip markers recursively inside StripMarker::split as Resolved.Mar 27 2025, 7:17 PM
ssastry edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team-WIP.Apr 8 2025, 4:25 AM
gerritbot added a comment.Apr 10 2025, 3:43 PM

Change #1131080 merged by jenkins-bot:

[mediawiki/core@master] Clean up temporary ParsoidFragmentSupport configuration flag

https://gerrit.wikimedia.org/r/1131080

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.25; 2025-04-15); removed MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Apr 10 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 10 2025, 4:32 PM
ssastry closed this task as Resolved.Apr 11 2025, 4:52 PM
ssastry assigned this task to cscott.
Stang unsubscribed.Apr 15 2025, 4:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits