Maniphest T380808

Clean up error handling in Rust executor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Nov 25 2024, 11:37 PM

Tags

Referenced Files

None

Subscribers

Description

Description

We are mostly ignoring errors and throwing around bare asserts. We should do proper error handling.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

just good, clean errors

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2025-09-16-190551 to 2025-09-24-083919	operations/deployment-charts	master	+2 -2

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Fix remaining dangerous error-handling patterns (unwrap, assert, etc.).	repos/abstract-wiki/wikifunctions/function-evaluator!413	apine	apine-rust-no-asserts	main
	Run executors inside of separate tasks.	repos/abstract-wiki/wikifunctions/function-evaluator!396	apine	apine-fix-some-rust	main

Customize query in GitLab

Related Objects

Mentioned In: rMSFE8114a116b9cf: Fix remaining dangerous error-handling patterns (unwrap, assert, etc.).

Event Timeline

cmassaro created this task.Nov 25 2024, 11:37 PM

Jdforrester-WMF assigned this task to cmassaro.Dec 11 2024, 5:36 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Dec 11 2024, 6:14 PM

Jdforrester-WMF added a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.Dec 18 2024, 6:25 PM

Jdforrester-WMF moved this task from 25Q2 (Oct–Dec) to Engineering Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (25Q2 (Oct–Dec)).

cmassaro removed cmassaro as the assignee of this task.Feb 24 2025, 6:42 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)), Essential-Work; removed Abstract Wikipedia team.Jul 16 2025, 2:10 PM

DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/396

Run executors inside of separate tasks.

cmassaro claimed this task.Sep 22 2025, 7:49 PM

cmassaro moved this task from Ready to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/413

Fix remaining dangerous error-handling patterns (unwrap, assert, etc.).

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/413

Fix remaining dangerous error-handling patterns (unwrap, assert, etc.).

cmassaro changed the task status from Open to In Progress.Sep 24 2025, 7:17 PM

cmassaro moved this task from In Code review to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

Change #1191170 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-16-190551 to 2025-09-24-083919

https://gerrit.wikimedia.org/r/1191170

Change #1191170 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-09-16-190551 to 2025-09-24-083919

https://gerrit.wikimedia.org/r/1191170

Jdforrester-WMF closed this task as Resolved.Sep 25 2025, 10:06 AM

Jdforrester-WMF removed a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.Oct 1 2025, 8:54 PM

Jdforrester-WMF mentioned this in rMSFE8114a116b9cf: Fix remaining dangerous error-handling patterns (unwrap, assert, etc.)..Oct 3 2025, 9:45 AM