Summary
AbuseFilter has a preference that needs to be checked for the user to be able to see protected variable values. This is no longer required after T387333: CheckUser should impose IP viewing restrictions on AbuseFilter's `unnamed_user_ip` protected variable and per WMF Legal saying we don't need this preference for other protected variables
Background
- The AbuseFilter protected variables preference was added as is a requirement for the user_unnamed_ip variable, as a user needs to agree to the policy regarding the access to temporary account IP addresses
- As time went on, we found that we wanted to add more protected variables. Specifically as part of T354599: [EPIC] WE4.2.14b Provide IP reputation variables in AbuseFilter
- These variables are less sensitive and do not require a preference to be checked in order to see the values of these protected variables per this L3SC task
- In T387333: CheckUser should impose IP viewing restrictions on AbuseFilter's `unnamed_user_ip` protected variable, we were able to make user_unnamed_ip only viewable by users with access to reveal IP addresses using CheckUser extension tools
- Doing this means that the AbuseFilter preference is now redundant as it is no longer needed for access to the user_unnamed_ip variable to be compliant with WMF Legal requirements
- Removing the AbuseFilter preference will therefore reduce duplication (avoiding the need to two preferences that do similar things) and also allow T354599 to be worked on
Acceptance criteria
- Access to protected variable values does not require checking the AbuseFilter preference
- The AbuseFilter preference used to gate access to protected variable values is removed
- The preference values for the removed preference are cleaned up on WMF wikis using the associated maintenance script to avoid un-needed DB rows in the preference database tables
historical context
Adjust wording of "abusefilter-preference-protected-vars-view-agreement"
The i18n string for abusefilter-preference-protected-vars-view-agreement is currently Enable revealing IP addresses for temporary accounts in AbuseFilter. However, per the parent task, we'll have new protected variables that are not about revealing IP addresses. We should adjust this wording so that it is more generic.