Page MenuHomePhabricator

Revise Reference Check range logic
Closed, ResolvedPublic

Description

In T376345, we decided to to revert the Reference Logic change merging https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1010703 caused.

This task involves the work of actually executing that this reversion.

Event Timeline

ppelberg renamed this task from Revise Reference Check range check logic to Revise Reference Check range logic .Nov 27 2024, 6:23 PM
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.

Change #1113845 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheck: add reference should only trigger on fully covered nodes

https://gerrit.wikimedia.org/r/1113845

Change #1113845 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: add reference should only trigger on fully covered nodes

https://gerrit.wikimedia.org/r/1113845

DLynch added a project: Editing QA.

QA: this makes it so that a reference check should trigger if you enter a sufficient quantity of text as a complete new paragraph. If you add that same quantity of text to an existing paragraph, it should not trigger.

QA: this makes it so that a reference check should trigger if you enter a sufficient quantity of text as a complete new paragraph. If you add that same quantity of text to an existing paragraph, it should not trigger.

@DLynch: I just checked this. It seemed to be working as expected that, when I enter sufficient amount of test as a complete new paragraph the reference check is being triggered. Not when I am adding the same amount of text to an existing paragraph.

However, I have a clarifying question: what should happen if I make some changes to a paragraph then hit enter to add a newline and then add that block of text. Shouldn't it be considered adding as a new paragraph? Right now, it does not seem to be triggering the reference check in this scenario.

What will happen depends on exactly how you added the text. If you added it to the very beginning of an existing paragraph and then split it, resulting in one paragraph that's entirely made up of new text and one that's made up at least partially of old text, you should see it on the entirely-new paragraph. But if you added the new text somewhere in the middle and split it, resulting in two paragraphs that both contain some old and some new text, neither should see the check.

What will happen depends on exactly how you added the text. If you added it to the very beginning of an existing paragraph and then split it, resulting in one paragraph that's entirely made up of new text and one that's made up at least partially of old text, you should see it on the entirely-new paragraph. But if you added the new text somewhere in the middle and split it, resulting in two paragraphs that both contain some old and some new text, neither should see the check.

Thanks @DLynch. Yeah I checked the two cases you mentioned and they work as expected. However, my scenario involved deleting or removing the last few words or an line from a paragraph then hitting enter to got the next line and pasting the block of text. Here is the edit that did not trigger reference check: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_Echo_link_test_0.3658765792740022&diff=644225&oldid=228953

Per today's offline discussion, we're going to pursue the question @Ryasmeen raised in T381020#10499424 in the newly-created T388435.