Page MenuHomePhabricator
Create Task
Maniphest T381068

PHP Deprecated: Creation of dynamic property MediaWiki\\Auth\\ButtonAuthenticationRequest::$skipReset is deprecated at AuthenticationRequest.php:182
Closed, ResolvedPublic
Actions

Description

[stacktrace]
#0 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/auth/AuthenticationRequest.php(182): MWExceptionHandler::handleError()
#1 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/auth/AuthenticationRequest.php(262): MediaWiki\\Auth\\AuthenticationRequest->loadFromSubmission()
#2 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/specialpage/AuthManagerSpecialPage.php(523): MediaWiki\\Auth\\AuthenticationRequest::loadRequestsFromSubmission()
#3 [internal function]: MediaWiki\\SpecialPage\\AuthManagerSpecialPage->handleFormSubmit()
#4 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/htmlform/HTMLForm.php(822): call_user_func()
#5 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/specialpage/AuthManagerSpecialPage.php(455): MediaWiki\\HTMLForm\\HTMLForm->trySubmit()
#6 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/specialpage/LoginSignupSpecialPage.php(405): MediaWiki\\SpecialPage\\AuthManagerSpecialPage->trySubmit()
#7 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/specialpage/SpecialPage.php(729): MediaWiki\\SpecialPage\\LoginSignupSpecialPage->execute()
#8 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/specialpage/SpecialPageFactory.php(1726): MediaWiki\\SpecialPage\\SpecialPage->run()
#9 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/actions/ActionEntryPoint.php(504): MediaWiki\\SpecialPage\\SpecialPageFactory->executePath()
#10 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/actions/ActionEntryPoint.php(146): MediaWiki\\Actions\\ActionEntryPoint->performRequest()
#11 /srv/mediawiki/tags/2024-11-27_15:24:32/includes/MediaWikiEntryPoint.php(201): MediaWiki\\Actions\\ActionEntryPoint->execute()
#12 /srv/mediawiki/tags/2024-11-27_15:24:32/index.php(58): MediaWiki\\MediaWikiEntryPoint->run()
#13 {main}

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ButtonAuthenticationRequest: Add AllowDynamicProperties directiveReedymediawiki/coreREL1_42+1 -0
ButtonAuthenticationRequest: Add AllowDynamicProperties directiveReedymediawiki/coreREL1_43+1 -0
ButtonAuthenticationRequest: Add AllowDynamicProperties directiveReedymediawiki/coreREL1_39+1 -0
ButtonAuthenticationRequest: Add AllowDynamicProperties directiveReedymediawiki/coreREL1_41+1 -0
ButtonAuthenticationRequest: Add AllowDynamicProperties directiveJforrestermediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

• Nikerabbit created this task.Nov 28 2024, 8:26 AM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptNov 28 2024, 8:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a project: PHP 8.2 support.Nov 28 2024, 5:49 PM
• matmarex subscribed.Nov 29 2024, 12:39 AM

I recently fixed a similar issue in CentralAuth: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1081271

Reedy added projects: MW-1.39-release, MW-1.41-release, MW-1.42-release, MW-1.43-release.Nov 29 2024, 12:42 AM
Tgr subscribed.Nov 29 2024, 3:25 PM

This makes ButtonAuthenticationRequest unusable. We need to decide whether the expectation is that it's always subclassed, or we make it store the "clicked" flag in a property which is always called the same (rather than the HTML name of the button), which makes it more convenient to use but maybe less convenient to subclass.

JTweed-WMF moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Core-Platform-Team board.Dec 2 2024, 3:51 PM
• matmarex claimed this task.Dec 2 2024, 3:55 PM
Vedmaka subscribed.Dec 3 2024, 9:15 PM
cicalese subscribed.Dec 5 2024, 12:48 PM
cicalese mentioned this in T378579: Deprecation-messages for BeginAuthenticationRequest::$password/$pluggableauthlogin0 for PHP 8.2.Dec 5 2024, 12:52 PM
• matmarex added a comment.Dec 7 2024, 1:43 PM

We should probably just put #[\AllowDynamicProperties] (https://www.php.net/manual/en/class.allowdynamicproperties.php) on ButtonAuthenticationRequest. It was designed to use properties with dynamic names, and while we probably wouldn't design it like that today, it works just fine, and it would be an annoying breaking change to redo it now. This should also resolve deprecation warnings in extensions (e.g. T378579, https://codesearch.wmcloud.org/search/?q=ButtonAuthenticationRequest).

gerritbot added a comment.Dec 10 2024, 6:39 PM

Change #1101921 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1101921

gerritbot added a project: Patch-For-Review.Dec 10 2024, 6:39 PM
gerritbot added a comment.Dec 12 2024, 9:44 PM

Change #1101921 merged by jenkins-bot:

[mediawiki/core@master] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1101921

gerritbot added a comment.Dec 12 2024, 9:45 PM

Change #1102974 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_43] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102974

gerritbot added a comment.Dec 12 2024, 9:45 PM

Change #1102975 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_42] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102975

gerritbot added a comment.Dec 12 2024, 9:46 PM

Change #1102976 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_41] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102976

gerritbot added a comment.Dec 12 2024, 9:46 PM

Change #1102977 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_39] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102977

gerritbot added a comment.Dec 12 2024, 9:58 PM

Change #1102976 merged by jenkins-bot:

[mediawiki/core@REL1_41] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102976

gerritbot added a comment.Dec 12 2024, 9:59 PM

Change #1102977 merged by jenkins-bot:

[mediawiki/core@REL1_39] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102977

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.44-notes (1.44.0-wmf.8; 2024-12-17), MW-1.41-notes.Dec 12 2024, 10:00 PM
gerritbot added a comment.Dec 12 2024, 10:01 PM

Change #1102974 merged by jenkins-bot:

[mediawiki/core@REL1_43] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102974

gerritbot added a comment.Dec 12 2024, 10:01 PM

Change #1102975 merged by jenkins-bot:

[mediawiki/core@REL1_42] ButtonAuthenticationRequest: Add AllowDynamicProperties directive

https://gerrit.wikimedia.org/r/1102975

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2024, 10:30 PM
ReleaseTaggerBot added projects: MW-1.42-notes, MW-1.43-notes.Dec 12 2024, 11:00 PM
• matmarex closed this task as Resolved.Dec 13 2024, 11:00 AM

This change should resolve T378579 as well.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits