Page MenuHomePhabricator
Create Task
Maniphest T381207

Write orchestrator code for Z6921/ Built-in implementation of Fetch Wikidata item
Closed, ResolvedPublicFeature
Actions

Description

The definition exists (Z6921); what's needed is orchestrator code for it. This being implemented would allow for Wikidata items to be fetched, which will be needed for the long-term goal of Abstract Wikipedia, but would also be useful for current/near-future uses, like https://www.wikifunctions.org/view/en/Z19512

  • Add appropriate keys to Z6001 definition in function-schemata
  • Pull-through function-schemata to production repos
  • Apply new keys to production once code is live
  • Implement Z6921 in function-orchestrator

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-12-17-184905 to 2025-01-08-142250operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (7a5b59a)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Feeglgeef created this task.Nov 30 2024, 6:44 PM
Jdforrester-WMF triaged this task as High priority.Dec 11 2024, 5:42 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

I'd recommend against creating functions that need functionality before they're available.

Feeglgeef added a comment.Dec 11 2024, 8:11 PM
In T381207#10398260, @Jdforrester-WMF wrote:

I'd recommend against creating functions that need functionality before they're available.

Of course. The functions was created before we realized we'd need more than just the raw information available in senses.

CodeReviewBot added a project: Patch-For-Review.Dec 18 2024, 6:09 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/181

Add descriptions, aliases & claims properties to Z6001

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.Dec 19 2024, 4:15 PM
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Jdforrester-WMF updated the task description. (Show Details)
DMartin-WMF claimed this task.Dec 27 2024, 4:37 PM
CodeReviewBot added a comment.Dec 27 2024, 7:21 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/264

Write orchestrator code for Z6921

CodeReviewBot added a comment.Jan 6 2025, 1:44 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/181

definitions: [Z6001] Add keys for descriptions, aliases & claims properties

gerritbot added a comment.Jan 6 2025, 8:57 PM

Change #1108482 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (7a5b59a)

https://gerrit.wikimedia.org/r/1108482

gerritbot added a comment.Jan 6 2025, 11:44 PM

Change #1108482 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (7a5b59a)

https://gerrit.wikimedia.org/r/1108482

CodeReviewBot added a comment.Jan 8 2025, 1:16 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/265

Update function-schemata sub-module to HEAD (7a5b59a)

CodeReviewBot added a comment.Jan 8 2025, 2:14 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/265

Update function-schemata sub-module to HEAD (7a5b59a)

CodeReviewBot added a comment.Jan 8 2025, 2:22 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/264

Write orchestrator code for Z6921

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2025, 2:31 PM
gerritbot added a comment.Jan 8 2025, 2:57 PM

Change #1109087 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-12-17-184905 to 2025-01-08-142250

https://gerrit.wikimedia.org/r/1109087

gerritbot added a project: Patch-For-Review.Jan 8 2025, 2:57 PM
gerritbot added a comment.Jan 8 2025, 3:05 PM

Change #1109087 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-12-17-184905 to 2025-01-08-142250

https://gerrit.wikimedia.org/r/1109087

Jdforrester-WMF moved this task from In Engineering to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Jan 8 2025, 3:27 PM
CodeReviewBot added a comment.Jan 8 2025, 3:30 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/295

Update function-schemata sub-module to HEAD (7a5b59a)

CodeReviewBot added a comment.Jan 8 2025, 3:31 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/59

Update function-schemata sub-module to HEAD (7a5b59a)

CodeReviewBot added a comment.Jan 8 2025, 11:53 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/59

Update function-schemata sub-module to HEAD (7a5b59a)

DMartin-WMF updated the task description. (Show Details)Jan 14 2025, 9:41 PM
CodeReviewBot added a comment.Jan 21 2025, 10:06 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/295

Update function-schemata sub-module to HEAD (7a5b59a)

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2025, 10:30 PM
gerritbot added a comment.Jan 22 2025, 9:54 PM

Change #1113572 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306

https://gerrit.wikimedia.org/r/1113572

gerritbot added a project: Patch-For-Review.Jan 22 2025, 9:54 PM
gerritbot added a comment.Jan 22 2025, 10:19 PM

Change #1113572 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-01-08-143723 to 2025-01-22-212306

https://gerrit.wikimedia.org/r/1113572

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2025, 10:30 PM
gerritbot added a comment.Jan 29 2025, 2:33 PM

Change #1115032 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115032

gerritbot added a project: Patch-For-Review.Jan 29 2025, 2:33 PM
gerritbot added a comment.Jan 29 2025, 2:36 PM

Change #1115032 abandoned by Cory Massaro:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

Reason:

already done

https://gerrit.wikimedia.org/r/1115032

DSantamaria subscribed.Feb 11 2025, 6:45 AM

Hey @DMartin-WMF
Are the Wikidata items fetched now? If so, should we proceed to "Resolve" this?

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 7:30 AM
DMartin-WMF closed this task as Resolved.Feb 11 2025, 11:05 PM

Thanks, David. Yes, this is done and I will sign off.

cmassaro mentioned this in rMSFEdc74fdcf5213: Update function-schemata sub-module to HEAD (7a5b59a).Oct 3 2025, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits