l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5116

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5116

Ready for design review in Experimental #210.

Looks good @Tsevener @GOlson-WMF 👏👏👏 Two nitpicks:

1) Slide 2: Overlapping footer:

2) As we can’t indent the numbered list properly, please left-align all text:

Implementation	vs	Design

@scblr
Getting it fixed!
For right now, we aren't going to be fixing #1 (the overlapping footer) but we will be fixing it in this ticket: https://phabricator.wikimedia.org/T379979
It requires a lot of custom rework so it's a bit heavy of a lift atm, but will be done (eventually) :)

Can be reviewed again in TestFlight 7.6.3 (4669).

In T381332#10415354, @scblr wrote:

Looks good @Tsevener @GOlson-WMF 👏👏👏 Two nitpicks:

1) Slide 2: Overlapping footer:

For right now, we aren't going to be fixing #1 (the overlapping footer) but we will be fixing it in this ticket: https://phabricator.wikimedia.org/T379979
It requires a lot of custom rework so it's a bit heavy of a lift atm, but will be done (eventually) :)

Thx @GOlson-WMF — I believe addressing this will be crucial for the release since it will impact a large number of users (CC @HNordeenWMF).

2) As we can’t indent the numbered list properly, please left-align all text:

Implementation	vs	Design

Looks good now!

@scblr I agree that the overlap is not something we should release without fixing. Before picking up T379979 to fix it, I'm checking if we can cut the copy down. (Either only list top 3, or remove the lead in sentence from first paragraph).

@GOlson-WMF I'm also seeing a less-than ideal display for the sharing view of that slide - is that something we can fix?

Another option if it's simpler: we could have the "share" button on this slide just be the link to the blogpost instead of an image

@HNordeenWMF On it now! Thanks!

Awaiting @scblr's feedback in Slack

@scblr could you share steps to recreate the overlap? I'm not seeing it on any of my devices, and trying to get an idea of how many people it will affect. Here's what I see when content overflows (scrollable behind the toolbar)

In T381332#10415354, @scblr wrote:

Looks good @Tsevener @GOlson-WMF 👏👏👏 Two nitpicks:

1) Slide 2: Overlapping footer:

@GOlson-WMF @scblr if necessary, we can also shorten the copy on this slide (3 options here, approved by Comms)

Hi @ABorbaWMF, as you review this: let us know if you see this issue Robin saw. We haven't been able to recreate it easily.

1) Slide 2: Overlapping footer:

@HNordeenWMF @GOlson-WMF @ABorbaWMF

I noticed the overlap with build 210. Just reproduced it again on iOS 18.2 on an iPhone 15 Pro. I didn’t do anything special (region set to United States, light theme):

1. Installed the build without a reading history or being logged in
2. Used the sheet entry point (not profile)
3. Swiped to the second card

Video: https://www.dropbox.com/scl/fi/b8tjqas4flzguq8i8h3ws/yir-overlap.mov?rlkey=a68o6cj8zksrwglf4zubx9qmx&dl=0

Dynamic type setting:

App font size setting:

I hope that helps!

Thanks @scblr ! I see it now - I had a smaller dynamic type size.
@GOlson-WMF could you try removing this sentence "When people want to learn about our world—the good, bad, weird, and wild alike—they turn to Wikipedia." and see if that solves this? We can function without it!

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5129

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5129

Works for me on 7.6.3 (4709)

@GOlson-WMF heads up I'm not seeing the fixes you made to share for the Top 5 Articles slide in the latest Test Flight build either (4683)

@HNordeenWMF Found in 4738! Moving back :)