Page MenuHomePhabricator
Create Task
Maniphest T381498

Review and testing support for Jon's ULS dark mode support work
Closed, DeclinedPublic4 Estimated Story Points
Actions

Description

NB: trying something slightly unconventional to see if we can handle these somewhat sprawling unplanned review tasks better.

See subtasks for more details.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Enable dark mode for IME selectorJon Harald Søbymediawiki/extensions/UniversalLanguageSelectormaster+145 -55
Use Less variables for the Vector skinJon Harald Søbymediawiki/extensions/UniversalLanguageSelectormaster+165 -12
Adapt ULS dialog and setlang to skin variablesJon Harald Søbymediawiki/extensions/UniversalLanguageSelectormaster+14 -16
Bump MW version requirement and use skin variables for LESS filesJon Harald Søbymediawiki/extensions/UniversalLanguageSelectormaster+16 -342
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Dec 4 2024, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2024, 1:45 PM
Nikerabbit triaged this task as Low priority.Dec 4 2024, 1:46 PM
Nikerabbit added subtasks: T375326: "Add languages" menu does not comply with dark theme when there are no crosswiki languages, T369328: Setlang override in dark mode, T370079: Language overlay on WelcomeSurvey is in light mode.
Nikerabbit set the point value for this task to 4.
Nikerabbit moved this task from Backlog to Needs Review on the LPL Essential (LPL Essential 2024 Nov-Jan) board.
jhsoby subscribed.Dec 4 2024, 1:47 PM
Nikerabbit moved this task from Needs Review to Ready for dev on the LPL Essential (LPL Essential 2024 Nov-Jan) board.Dec 4 2024, 1:50 PM
gerritbot added a comment.Dec 4 2024, 2:19 PM

Change #1098036 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] Use LESS variables for the Vector skin

https://gerrit.wikimedia.org/r/1098036

gerritbot added a project: Patch-For-Review.Dec 4 2024, 2:19 PM
jhsoby added a subtask: T381679: Input method selector needs dark mode support.Dec 6 2024, 5:24 PM
gerritbot added a comment.Dec 6 2024, 5:38 PM

Change #1101091 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] Bump MW version requirement and use skin variables for LESS files

https://gerrit.wikimedia.org/r/1101091

gerritbot added a comment.Dec 6 2024, 6:29 PM

Change #1101096 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] Adapt ULS dialog and setlang to skin variables

https://gerrit.wikimedia.org/r/1101096

gerritbot added a comment.Dec 7 2024, 2:24 AM

Change #1101133 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] Enable dark mode for IME selector

https://gerrit.wikimedia.org/r/1101133

gerritbot added a comment.Dec 9 2024, 10:36 AM

Change #1101091 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Bump MW version requirement and use skin variables for LESS files

https://gerrit.wikimedia.org/r/1101091

abi_ changed the task status from Open to In Progress.Dec 10 2024, 12:57 PM
abi_ claimed this task.
abi_ moved this task from Ready for dev to In Progress on the LPL Essential (LPL Essential 2024 Nov-Jan) board.
gerritbot added a comment.Dec 11 2024, 10:42 AM

Change #1101096 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Adapt ULS dialog and setlang to skin variables

https://gerrit.wikimedia.org/r/1101096

jhsoby closed subtask T369328: Setlang override in dark mode as Resolved.Dec 11 2024, 10:50 AM
abi_ moved this task from In Progress to Ready for dev on the LPL Essential (LPL Essential 2024 Nov-Jan) board.Jan 16 2025, 2:14 PM

Currently nothing to do on this.

Nikerabbit moved this task from Ready for dev to Backlog on the LPL Essential (LPL Essential 2024 Nov-Jan) board.Feb 5 2025, 1:22 PM
Nikerabbit edited projects, added: LPL Essential; removed: LPL Essential (LPL Essential 2024 Nov-Jan).Feb 5 2025, 1:28 PM
Nikerabbit moved this task from LPL Essential 2024 Nov-Jan to Backlog on the LPL Essential board.
Nikerabbit removed a project: LPL Essential.Jul 10 2025, 6:26 AM
gerritbot added a comment.Oct 14 2025, 3:06 PM

Change #1098036 abandoned by Jon Harald Søby:

[mediawiki/extensions/UniversalLanguageSelector@master] Use Less variables for the Vector skin

Reason:

Not working on this at the moment, probably better to wait for the ULS rewrite at this point.

https://gerrit.wikimedia.org/r/1098036

jhsoby closed this task as Declined.Oct 14 2025, 3:08 PM

Abandoned the now-stale patches, since there is a ULS rewrite on the steps – better to wait for that, I think.

gerritbot added a comment.Oct 14 2025, 3:26 PM

Change #1101133 abandoned by Jon Harald Søby:

[mediawiki/extensions/UniversalLanguageSelector@master] Enable dark mode for IME selector

Reason:

Not actively working on this, better to wait for ULS rewrite

https://gerrit.wikimedia.org/r/1101133

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 3:30 PM
jhsoby closed subtask T375326: "Add languages" menu does not comply with dark theme when there are no crosswiki languages as Resolved.Nov 10 2025, 10:13 PM
jhsoby closed subtask T370079: Language overlay on WelcomeSurvey is in light mode as Resolved.
abi_ mentioned this in T363762: ULS should eliminate references to the "legacy" Codex design tokens.Jul 21 2026, 10:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits