Page MenuHomePhabricator
Create Task
Maniphest T381610

Move Reference Check decline survey into sidebar (desktop)
Closed, ResolvedPublic
Actions

Description

This task involves the work of moving the "survey" that appears when people decide not to add a reference when Reference Check prompts them to do so from appearing within the article content to appearing within the sidebar T378777 introduces.

Prioritizing this work is in service of the, "Meet people where they are." Edit Check design principle. More in T381711.

Story

As someone who elects to decline a reference in response to Reference Check prompting me to do so [on desktop], I want to be able to complete the decline survey that I am presented with within the Edit Check sidebar, so that I do not need to reacquire the focus I've attained in order to proceed with the change(s) I'm intent on making.

Requirements

Current stateDesired
image.png (928×2 px, 563 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditCheck: move Reference check feedback to the sidebarmediawiki/extensions/VisualEditormaster+104 -175
Customize query in gerrit

Related Objects

Event Timeline

ppelberg created this task.Dec 5 2024, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2024, 6:15 PM
ppelberg updated the task description. (Show Details)Dec 6 2024, 4:26 AM
ppelberg merged a task: T380399: Consider moving Reference Check questionnaire to sidebar (desktop) when declining Check.Dec 10 2024, 5:37 PM
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.Dec 10 2024, 6:14 PM
ppelberg updated the task description. (Show Details)Jan 9 2025, 11:07 PM
gerritbot added a comment.Jan 10 2025, 2:49 AM

Change #1109530 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheck: move Reference check feedback to the sidebar

https://gerrit.wikimedia.org/r/1109530

gerritbot added a project: Patch-For-Review.Jan 10 2025, 2:49 AM
DLynch moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 10 2025, 3:44 AM

Can be seen here: https://patchdemo.wmcloud.org/wikis/e8dc274531/w/index.php?title=Douglas_Adams&veaction=edit

Probably needs some design tweaks as well -- it's literally just the contents of the former inspector put into the widget in the sidebar.

ppelberg reassigned this task from DLynch to nayoub.Jan 10 2025, 6:17 AM
ppelberg moved this task from Code Review to Design Review on the Editing-team (Kanban Board) board.
ppelberg added subscribers: nayoub, DLynch.
In T381610#10447176, @DLynch wrote:

Can be seen here: https://patchdemo.wmcloud.org/wikis/e8dc274531/w/index.php?title=Douglas_Adams&veaction=edit

What a great start, @DLynch! For reference, here is a screenshot of the experience in its current/initial form:

image.png (1×2 px, 382 KB)

Probably needs some design tweaks as well -- it's literally just the contents of the former inspector put into the widget in the sidebar.

Wonderful; I'm going to assign this over to @nayoub to offer direction here.

PatchDemoBot added a comment.Jan 13 2025, 11:48 PM

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/b6fb100017/w/

PatchDemoBot added a comment.Jan 15 2025, 5:22 PM

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/719d6529c9/w/

ppelberg moved this task from Design Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mar 17 2025, 10:14 PM
ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Mar 24 2025, 5:20 PM

Next steps

  • @DLynch to update size of card/hint title to be smaller
DLynch claimed this task.Mar 29 2025, 1:41 AM
DLynch moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Design tweaks were made and the patch updated.

gerritbot added a comment.Apr 2 2025, 10:28 PM

Change #1109530 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: move Reference check feedback to the sidebar

https://gerrit.wikimedia.org/r/1109530

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 10:30 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 2 2025, 10:35 PM
DLynch added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 2 2025, 11:00 PM
Ryasmeen subscribed.Apr 11 2025, 10:29 PM

@DLynch: This change looks good to me.

One small issue observed with the interface: The reference check prompt on the side bar slightly jumps when I cross out the "Add a citation" dialog. Not sure if it's relevant to this. I can file a separate task if not.

Ryasmeen removed a project: Editing QA.Apr 15 2025, 2:20 AM
Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Apr 21 2025, 5:25 PM
DLynch added a comment.Apr 28 2025, 3:00 PM

@Ryasmeen am I right to think that what you're seeing is:

  1. Add some content and click "publish"
  2. See the add-reference edit check appear
  3. Click "yes" in the check
  4. Click the "X" on the reference dialog
  5. See things move around slightly before resettling

(I don't see this, though I do see some slight jostling-in-place at the moment that you click "yes".)

ppelberg reassigned this task from DLynch to Ryasmeen.May 1 2025, 6:24 PM
ppelberg moved this task from Ready to Be Worked On to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
VPuffetMichel added a project: OKR-Work.May 8 2025, 1:54 PM
PatchDemoBot added a comment.May 16 2025, 7:29 PM

Test wiki on Patch demo by DLynch (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/719d6529c9/w/

PatchDemoBot added a comment.May 16 2025, 7:34 PM

Test wiki on Patch demo by DLynch (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/b6fb100017/w/

ppelberg mentioned this in T389443: [Tone Check] Present survey when people choose to "Decline" invitation to revise tone.Jun 25 2025, 11:20 PM
ppelberg closed this task as Resolved.Jun 30 2025, 5:20 PM
ppelberg mentioned this in T398228: Reference Check card jumps when exiting Citoid dialog .
In T381610#10735542, @Ryasmeen wrote:

@DLynch: This change looks good to me.

One small issue observed with the interface: The reference check prompt on the side bar slightly jumps when I cross out the "Add a citation" dialog. Not sure if it's relevant to this. I can file a separate task if not.

Per offline discussion, we're going to address (or at least, investigate) this issue in T398228.

ppelberg mentioned this in T401739: Implement v2 of Suggestion feedback flow.Aug 12 2025, 6:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits