Change #1100876 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix deprecation warnings in Minerva

https://gerrit.wikimedia.org/r/1100876

Change #1100877 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ExternalGuidance@master] Fixes deprecation warnings in MTServiceInfo

https://gerrit.wikimedia.org/r/1100877

@santhosh RequestTitleForm while possible to fix up, seems a little complicated and might benefit from an extensive Vue rewrite..?

This project is a candidate for sunsetting as per our last team discussions. So , I am not expecting any rewrite.

Change #1100877 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] MTServiceInfo: Remove usage of deprecated View class constructor

https://gerrit.wikimedia.org/r/1100877

This project is a candidate for sunsetting as per our last team discussions. So , I am not expecting any rewrite.

@santhosh can I delete the associated code now to unblock removal of this code (or alternatively break it if it's not in use anywhere)?

@santhosh: Could you please answer the last comment? Thanks in advance!

@Jdlrobson Apologies, I missed this notification.

Yes, please go ahead. No blocker from our side. I will follow up and keep Special:ExternalGuidance minimum functional. It barely get traffic.

Change #1125026 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ExternalGuidance@master] Special:ExternalGuidance: Remove dependency on View class from MobileFrontEnd

https://gerrit.wikimedia.org/r/1125026

Change #1125026 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Special:ExternalGuidance: Remove dependency on View class from MobileFrontEnd

https://gerrit.wikimedia.org/r/1125026

I believe this is now only blocked on the GrowthExperiments extension (specifically the MobileOverlay). I'm keen to drop support for View and Overlay inheritance as there are some subtle bugs that may be present in Growth code. @Sgs @KStoller-WMF
could we set up some time to pair on fixing this up?

Looks like we need to remove the class inheritance in the following file, replacing it with Overlay.make:
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/8feabf3e53e240071db8d1a6366b9a82b388940c/modules/ext.growthExperiments.Homepage.mobile/MobileOverlay.js#20

Good example for reference:

• Overlay.make https://gerrit.wikimedia.org/g/mediawiki/extensions/Echo/+/e65ec1760bf78e5efed0d87b45bd2d78e07bf7b4/modules/mobile/notificationsFilterOverlay.js#34

In T381627#10624906, @Jdlrobson-WMF wrote:

could we set up some time to pair on fixing this up?

Thanks for offering pairing support! We'll discuss and estimate this task next week and plan to pull it into our upcoming sprint.

In T381627#10624906, @Jdlrobson-WMF wrote:

Looks like we need to remove the class inheritance in the following file, replacing it with Overlay.make:
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/8feabf3e53e240071db8d1a6366b9a82b388940c/modules/ext.growthExperiments.Homepage.mobile/MobileOverlay.js#20

Good example for reference:

• Overlay.make https://gerrit.wikimedia.org/g/mediawiki/extensions/Echo/+/e65ec1760bf78e5efed0d87b45bd2d78e07bf7b4/modules/mobile/notificationsFilterOverlay.js#34

Does the Overlay.make factory allow to set a preRender hook into the overlay? Or what would be an alternative? GrowthExperiments is using it to add extra options into the header (see ext.growthExperiments.Homepage.mobile/MobileOverlay.js#35).

It does yes. It's a factory function.

MobileOverlay will need to be updated to do something like this:

	module.exports = ( params ) => {
		const options = preRender( params );
		const view = postRender( options );
		return Overlay.make( options, view );
	}

Looking at your code it doesn't seem you are making use of any of the preRender of postRender functionality of Overlay.

the new postRender version would do something like return View.make( {}, [ $el ] ); and the new preRender function would simply return the modified options. Further refactoring is likely possible to make this code more readable.

I can walk you through it tomorrow and possibly get you started.

Change #1127884 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] refactor(MobileOverlay): use View.make instead of extending class

https://gerrit.wikimedia.org/r/1127884

Test Steps

Status: ❌ FAIL
Environment: enwiki
OS: macOS
Browser: Chrome
Device: MS MBA

⸻

Test Case 1: Verify no deprecation warning for View constructor

1. Visit a page that previously used unsupported View constructor code. https://en.m.wikipedia.org/wiki/Special:Homepage#/homepage/suggested-edits
2. Open the developer console.
3. ❌ AC1: Confirm there is no warning stating: “[1.44] Extending View class constructor is deprecated. Please use View.make”.

@Edtadros thanks this is expected. Work is still ongoing here by the Growth team and it's only partially fixed.

Change #1128901 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Do not expose View and Overlay to external extensions

https://gerrit.wikimedia.org/r/1128901

Change #1127884 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor(MobileOverlay): use View.make instead of extending class

https://gerrit.wikimedia.org/r/1127884

Test Steps

Status: ✅ PASS
Environment: beta
OS: macOS
Browser: Chrome
Device: MS

⸻

Test Case 1: Verify no deprecation warning for View constructor

1. Visit a page that previously used unsupported View constructor code. https://en.m.wikipedia.org/wiki/Special:Homepage#/homepage/suggested-edits
2. Open the developer console.
3. ✅ AC1: Confirm there is no warning stating: “[1.44] Extending View class constructor is deprecated. Please use View.make”.

Test Steps

Status: ✅ PASS
Environment: enwiki
OS: macOS
Browser: Chrome
Device: MS

⸻

Test Case 1: Verify no deprecation warning for View constructor

1. Visit a page that previously used unsupported View constructor code. https://en.m.wikipedia.org/wiki/Special:Homepage#/homepage/suggested-edits
2. Open the developer console.
3. ✅ AC1: Confirm there is no warning stating: “[1.44] Extending View class constructor is deprecated. Please use View.make”.