Page MenuHomePhabricator

PageTriage should use temporary accounts username styling
Closed, ResolvedPublic2 Estimated Story Points

Description

Temporary account usernames should appear differently from regular account names.

Compare

image.png (192×1 px, 46 KB)

and

image.png (192×1 px, 32 KB)

Event Timeline

kostajh renamed this task from PageTriage does not use temporary accounts username styling to PageTriage should use temporary accounts username styling.Dec 6 2024, 11:56 AM

PageTriage is only deployed on English Wikipedia, where anonymous/temporary users can't create articles, so I don't believe this is a scenario which can occur in Wikimedia production projects at this time, unless I'm missing something?

testwiki and test2wiki also has it, and other may have once T50552: Make PageTriage wiki agnostic is resolved.

testwiki and test2wiki also has it, and other may have once T50552: Make PageTriage wiki agnostic is resolved.

To what degrees do the test wikis need to provide full (i.e. UI optimised, not errors) support for temporary accounts?

I'm not aware of any plans to proceed with T50552 in the near future.

PageTriage is only deployed on English Wikipedia, where anonymous/temporary users can't create articles, so I don't believe this is a scenario which can occur in Wikimedia production projects at this time, unless I'm missing something?

Anonymous/temp accounts could create content in the Draft namespace, where they can be listed on Special:NewPagesFeed via articles for creation mode

image.png (1×1 px, 258 KB)

Oh, of course, I always forget about the AfC part of PageTriage. Thanks!

Change #1116858 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] PageTriage should use temporary accounts username styling

https://gerrit.wikimedia.org/r/1116858

Note I attempted to add some integration tests, but was unable to create a test user that is temporary in the test environment. Does anyone have any tips?

Note I attempted to add some integration tests, but was unable to create a test user that is temporary in the test environment. Does anyone have any tips?

You can use the TempUserCreator service to create a temporary account for you.

See https://gerrit.wikimedia.org/g/mediawiki/extensions/CheckUser/+/2bb8649ec423b26ca484f3cd4fd4054cfaf2f926/tests/phpunit/integration/Api/Rest/Handler/TemporaryAccountLogHandlerTest.php#297 for an example in CheckUser tests.

Note I attempted to add some integration tests, but was unable to create a test user that is temporary in the test environment. Does anyone have any tips?

You can use the TempUserCreator service to create a temporary account for you.

See https://gerrit.wikimedia.org/g/mediawiki/extensions/CheckUser/+/2bb8649ec423b26ca484f3cd4fd4054cfaf2f926/tests/phpunit/integration/Api/Rest/Handler/TemporaryAccountLogHandlerTest.php#297 for an example in CheckUser tests.

Thanks!

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/d8f304691a/w/

Change #1116858 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PageTriage should use temporary accounts username styling

https://gerrit.wikimedia.org/r/1116858

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/d8f304691a/w/

jsn.sherman subscribed.

verified style change on testwiki; leaving open until deployed to all groups.

Change #1119205 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] PageTriage should use temporary accounts username styling - enable temp user accounts in test which creates a temp user

https://gerrit.wikimedia.org/r/1119205

Created a small PR to fix a newly added test so that it will run successfully even when temporary account auto creation is disabled.

Change #1119205 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PageTriage should use temporary accounts username styling - enable temp user accounts in test which creates a temp user

https://gerrit.wikimedia.org/r/1119205

Scardenasmolinar subscribed.

Moving this back to Done because the latest patch has been merged