Remove duplicate suggestions for Collections
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• PWaigi-WMF
	Dec 9 2024, 3:09 PM

Project Tags

Referenced Files

	F57791426: Screenshot 2024-12-09 at 07.33.19.png
	Dec 9 2024, 3:09 PM

Subscribers

Aklapper

GMikesell-WMF

• PWaigi-WMF

Description

If an article needing translation falls under multiple collections, the RecAPI should only return 1 article suggestion, which can then be shown to the user.

Screenshot 2024-12-09 at 07.33.19.png (2,560×1,600 px, 569 KB)

Examples:

HIV/AIDS article appears in 3 collections > Vital articles, Women's Health & List of articles every Wikipedia should have

Bread article appears in 3 collections > Vital articles, Wiki99 & List of articles every Wikipedia should have

Dentistry article appears in 2 collections > List of articles every Wikipedia should have & Vital articles

QA Results - Test Mobile ContentTranslation

AC	Status	Details
1	⬜	T381777#10414679

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Update recommendation-api to 2024-12-12-085930-production	KartikMistry	operations/deployment-charts	master	+2 -2
	collections: add recommendation to the list only if not already present	Nik Gkountas	research/recommendation-api	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: T380388: Add an initial set of collections by tagging some existing community pages

Event Timeline

• PWaigi-WMF created this task.Dec 9 2024, 3:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2024, 3:09 PM

• PWaigi-WMF triaged this task as High priority.Dec 9 2024, 3:09 PM

Change #1101569 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[research/recommendation-api@master] collections: add recommendation to the list only if not already present

https://gerrit.wikimedia.org/r/1101569

gerritbot added a project: Patch-For-Review.Dec 9 2024, 6:19 PM

ngkountas claimed this task.Dec 9 2024, 6:20 PM

ngkountas moved this task from Prioritized to Needs Code Review on the LPL Hypothesis board.

Change #1101569 merged by jenkins-bot:

[research/recommendation-api@master] collections: add recommendation to the list only if not already present

https://gerrit.wikimedia.org/r/1101569

Maintenance_bot removed a project: Patch-For-Review.Dec 10 2024, 7:30 PM

SBisson moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Dec 10 2024, 7:31 PM

• PWaigi-WMF mentioned this in T380388: Add an initial set of collections by tagging some existing community pages.Dec 11 2024, 9:19 AM

Change #1102845 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update recommendation-api to 2024-12-12-085930-production

https://gerrit.wikimedia.org/r/1102845

gerritbot added a project: Patch-For-Review.Dec 12 2024, 1:18 PM

Change #1102845 merged by jenkins-bot:

[operations/deployment-charts@master] Update recommendation-api to 2024-12-12-085930-production

https://gerrit.wikimedia.org/r/1102845

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2024, 3:31 PM

ngkountas moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Dec 16 2024, 4:11 PM

@ngkountas @PWaigi-WMF How would I be able to test this since I can't pick like the example you have with "Dentistry" from Suggestions?

@ngkountas @PWaigi-WMF It seems like this one is hard to test & replicate now since they've fixed it, and Vital Articles is removed since it was similar to the Essential list. I tried to do some blind refreshing for a bit and did not find any duplicates. After discussing it with you, I will move this to Prod sign-off, thanks!

GMikesell-WMF updated the task description. (Show Details)Dec 19 2024, 1:05 AM

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.

Pginer-WMF moved this task from Design Signoff to Product Signoff on the LPL Hypothesis board.Dec 19 2024, 2:11 PM

• PWaigi-WMF closed this task as Resolved.Dec 20 2024, 8:10 AM

Remove duplicate suggestions for CollectionsClosed, ResolvedPublicActions