Page MenuHomePhabricator
Create Task
Maniphest T381834

Support dark mode in the Translate extension
Closed, ResolvedPublic
Actions

Assigned To
jhsoby
Authored By
jhsoby
Dec 10 2024, 12:26 AM
Tags
Referenced Files
F58205051: image.png
Jan 15 2025, 2:28 PM
F58205040: image.png
Jan 15 2025, 2:28 PM
F58024011: image.png
Dec 16 2024, 2:41 PM
F58024008: image.png
Dec 16 2024, 2:41 PM
Subscribers
abi_
Aklapper
hueitan
jhsoby
Nemoralis

Description

Umbrella task for supporting dark mode across the Translate extension, by leveraging MediaWiki skin variables in LESS files.

Special pages

Many of these special pages don't need any changes to work with dark mode, but some do.

  • Special:ActiveLanguages
  • Special:AggregateGroups
  • Special:ExportTranslations
  • Special:LanguageStats
  • Special:ManageMessageGroups
  • Special:ManageTranslatorSandbox
  • Special:MessageGroupStats
  • Special:PageMigration
  • Special:PagePreparation
  • Special:PageTranslation
  • Special:SearchTranslations (T380138)
  • Special:Translate (T371071)
  • Special:TranslationStash (Note! Only available to new translators)
  • Special:TranslationStats
  • Special:Translations

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

jhsoby created this task.Dec 10 2024, 12:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2024, 12:26 AM
jhsoby added a subtask: T380138: Special:SearchTranslations is not dark mode compatible.Dec 10 2024, 12:27 AM
jhsoby added a subtask: T371071: Dark mode not compatible with Translate extension Special:Translate page.
gerritbot added a comment.Dec 10 2024, 12:28 AM

Change #1101603 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Use Codex icons instead of custom icons

https://gerrit.wikimedia.org/r/1101603

gerritbot added a project: Patch-For-Review.Dec 10 2024, 12:28 AM
jhsoby added a project: dark-mode.Dec 10 2024, 2:20 AM
jhsoby added subtasks: T356821: Make <languages> compatible with night mode by using Codex design tokens, T358381: Make Translate outdated translations text compatible with night mode, T358822: Translate extension needs to import mediawiki.skin.variables to get night mode.Dec 10 2024, 2:23 AM
Nemoralis awarded a token.Dec 10 2024, 9:36 AM
gerritbot added a comment.Dec 10 2024, 10:15 AM

Change #1101819 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:Translate: Use Codex icons

https://gerrit.wikimedia.org/r/1101819

gerritbot added a comment.Dec 10 2024, 10:23 AM

Change #1101821 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:AggregateGroups: Use Codex icons

https://gerrit.wikimedia.org/r/1101821

gerritbot added a comment.Dec 10 2024, 10:26 AM

Change #1101822 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:ManageMessageGroups: Use Codex icons

https://gerrit.wikimedia.org/r/1101822

gerritbot added a comment.Dec 10 2024, 10:30 AM

Change #1101824 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:ManageTranslatorSandbox: Use Codex icons

https://gerrit.wikimedia.org/r/1101824

gerritbot added a comment.Dec 10 2024, 10:32 AM

Change #1101825 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:MovePage: Use Codex icons

https://gerrit.wikimedia.org/r/1101825

gerritbot added a comment.Dec 10 2024, 10:36 AM

Change #1101828 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:PageMigration: Use Codex icons

https://gerrit.wikimedia.org/r/1101828

gerritbot added a comment.Dec 10 2024, 10:38 AM

Change #1101603 abandoned by Jon Harald Søby:

[mediawiki/extensions/Translate@master] Use Codex icons instead of custom icons

Reason:

Split into several patches: Iae9ed91fe2cb3a41460b1c27273d1c4963faf443 I42d491f604f91420b7fd5bd99b974599bc435749 Ifb8edd668a131dbcfb125950ac5812c484780b95 Id4b5dda37a1b34d30c9196a679c71c1ef8683e21 Ia021cf665bdb1f3e13410d886bb0359396af0e41 I9121990d6122a2395d24be6a5d636435ccaeb51f

https://gerrit.wikimedia.org/r/1101603

Pginer-WMF triaged this task as Medium priority.Dec 12 2024, 9:03 AM
Pginer-WMF moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Dec 12 2024, 12:11 PM

Change #1101825 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:MovePage: Use Codex icons

https://gerrit.wikimedia.org/r/1101825

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 12 2024, 1:00 PM
hueitan subscribed.Dec 16 2024, 2:41 PM

The changes include the icon expand/collapse

image.png (852×1 px, 253 KB)

image.png (1×2 px, 294 KB)

abi_ subscribed.Dec 16 2024, 2:49 PM
In T381834#10406249, @hueitan wrote:

The changes include the icon expand/collapse

image.png (852×1 px, 253 KB)

image.png (1×2 px, 294 KB)

I think this looks fine.

gerritbot added a comment.Jan 6 2025, 12:53 PM

Change #1101828 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:PageMigration: Use Codex icons

https://gerrit.wikimedia.org/r/1101828

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.12; 2025-01-14); removed MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Jan 6 2025, 1:00 PM
Nemoralis subscribed.Jan 6 2025, 11:15 PM
gerritbot added a comment.Jan 7 2025, 10:45 AM

Change #1101819 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:Translate: Use Codex icons

https://gerrit.wikimedia.org/r/1101819

gerritbot added a comment.Jan 7 2025, 10:45 AM

Change #1101821 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:AggregateGroups: Use Codex icons

https://gerrit.wikimedia.org/r/1101821

gerritbot added a comment.Jan 7 2025, 12:24 PM

Change #1101824 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ManageTranslatorSandbox: Use Codex icons

https://gerrit.wikimedia.org/r/1101824

gerritbot added a comment.Jan 7 2025, 1:35 PM

Change #1101822 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ManageMessageGroups: Use Codex icons

https://gerrit.wikimedia.org/r/1101822

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2025, 2:31 PM
jhsoby updated the task description. (Show Details)Jan 9 2025, 8:46 AM
gerritbot added a comment.Jan 9 2025, 8:48 AM

Change #1109381 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:PageMigration: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109381

gerritbot added a project: Patch-For-Review.Jan 9 2025, 8:48 AM
gerritbot added a comment.Jan 9 2025, 9:17 AM

Change #1109385 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:ManageTranslatorSandbox: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109385

gerritbot added a comment.Jan 10 2025, 1:55 PM

Change #1109381 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:PageMigration: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109381

gerritbot added a comment.Jan 10 2025, 4:13 PM

Change #1109739 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:ManageMessageGroups: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109739

gerritbot added a comment.Jan 13 2025, 10:28 AM

Change #1110733 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Special:TranslationStats: Use skin variables

https://gerrit.wikimedia.org/r/1110733

gerritbot added a comment.Jan 13 2025, 11:42 AM

Change #1110748 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Languages tag: Use skin variables to support dark mode

https://gerrit.wikimedia.org/r/1110748

gerritbot added a comment.Jan 13 2025, 11:44 AM

Change #1110749 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Entity selector: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1110749

gerritbot added a comment.Jan 15 2025, 1:04 PM

Change #1110733 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:TranslationStats: Use skin variables

https://gerrit.wikimedia.org/r/1110733

gerritbot added a comment.Jan 15 2025, 1:13 PM

Change #1110749 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Entity selector: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1110749

gerritbot added a comment.Jan 15 2025, 1:42 PM

Change #1109739 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ManageMessageGroups: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109739

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.13; 2025-01-21); removed MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 15 2025, 2:00 PM
abi_ added a comment.Jan 15 2025, 2:28 PM

Few minor issues noticed on translatewiki.net when testing: 1109739: Special:ManageMessageGroups: Use skin variables for dark mode support | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1109739, which I missed during my local testing:

The loading symbol is a bit blurry but not noticing the same on https://translatewiki.net/w/i.php?title=Special%3ATranslationStats&preview=1&width=800&height=600&start=&days=30&scale=days&count=edits&mw-language-selector=aa&language=&mw-group-selector=adiutor&group=

image.png (440×1 px, 39 KB)

The background color for the items in the dialog below can be the same as the darker dialog background color.

image.png (729×1 px, 82 KB)

abi_ updated the task description. (Show Details)Jan 15 2025, 2:32 PM
jhsoby added a comment.Jan 15 2025, 3:39 PM
In T381834#10462244, @abi_ wrote:

Few minor issues noticed on translatewiki.net when testing: 1109739: Special:ManageMessageGroups: Use skin variables for dark mode support | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1109739, which I missed during my local testing:

The loading symbol is a bit blurry but not noticing the same on https://translatewiki.net/w/i.php?title=Special%3ATranslationStats&preview=1&width=800&height=600&start=&days=30&scale=days&count=edits&mw-language-selector=aa&language=&mw-group-selector=adiutor&group=

image.png (440×1 px, 39 KB)

The background color for the items in the dialog below can be the same as the darker dialog background color.

image.png (729×1 px, 82 KB)

I thought I had also added skin-invert when the .loading is present, but that must have been something I just tested locally without adding it to the patch, in order to fix this.

The loading circle in Special:TranslationStats is indeed different; we actually have 3 different spinners in the Translate extension:

This should probably be improved…

jhsoby mentioned this in T383802: Translate extension should use one loading spinner.Jan 15 2025, 5:27 PM
stjn awarded a token.Jan 20 2025, 2:58 AM
gerritbot added a comment.Jan 21 2025, 7:39 AM

Change #1110748 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Languages tag: Use skin variables to support dark mode

https://gerrit.wikimedia.org/r/1110748

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.14; 2025-01-28); removed MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 21 2025, 8:00 AM
gerritbot added a comment.Jan 22 2025, 7:15 AM

Change #1109385 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Special:ManageTranslatorSandbox: Use skin variables for dark mode support

https://gerrit.wikimedia.org/r/1109385

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2025, 7:30 AM
jhsoby closed this task as Resolved.Jun 13 2025, 8:37 AM
jhsoby claimed this task.

This should be all done with the patches that were merged in December/January. 👍

jhsoby closed subtask T371071: Dark mode not compatible with Translate extension Special:Translate page as Resolved.Jun 13 2025, 8:37 AM
jhsoby closed subtask T380138: Special:SearchTranslations is not dark mode compatible as Resolved.
jhsoby mentioned this in T386536: Ensure `@color-subtle` is used instead of `#72777d`.Jun 13 2025, 8:43 AM
Tacsipacsi reopened subtask T371071: Dark mode not compatible with Translate extension Special:Translate page as Open.Jun 13 2025, 1:50 PM
jhsoby closed subtask T371071: Dark mode not compatible with Translate extension Special:Translate page as Resolved.Oct 2 2025, 4:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits