Page MenuHomePhabricator

MetricsPlatform: Update MetricsPlatformEnable config variable
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The $wgMetricsPlatformEnable config variable currently does two things:

  1. It enables loading of the extension along with $wgMetricsPlatformEnableStreamConfigsMerging (see https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/9d1764e343c324af702553f81bc604c836914ddb/wmf-config/CommonSettings.php#4681)
  2. It enables stream configs fetching

The variable was added when the MetricsPlatform MediaWiki extension only did stream configs fetching and merging and we wanted to understand the performance of stream config fetching . Now the extension does more, we should alter the design slightly to ensure that the extension's config variables are easy to understand and consistent with other extensions'.

I propose that:

  1. We introduce the $wmgUseMetricsPlatform config variable in the operations/mediawiki-config repo, which causes the extension to be loaded
  2. We rename the $wgMetricsPlatformEnable config variable to $wgMetricsPlatformEnableStreamConfigsFetching

Event Timeline

Change #1101840 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Beta Cluster: Enable MetricsPlatform extension on all wikis

https://gerrit.wikimedia.org/r/1101840

Change #1101840 merged by jenkins-bot:

[operations/mediawiki-config@master] Beta Cluster: Enable MetricsPlatform extension on all wikis

https://gerrit.wikimedia.org/r/1101840

Mentioned in SAL (#wikimedia-operations) [2024-12-10T21:48:31Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1101840|Beta Cluster: Enable MetricsPlatform extension on all wikis (T381849 T381853)]]

Mentioned in SAL (#wikimedia-operations) [2024-12-10T21:52:45Z] <cjming@deploy2002> cjming, phuedx: Backport for [[gerrit:1101840|Beta Cluster: Enable MetricsPlatform extension on all wikis (T381849 T381853)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-12-10T21:59:22Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1101840|Beta Cluster: Enable MetricsPlatform extension on all wikis (T381849 T381853)]] (duration: 10m 50s)

Change #1111254 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/MetricsPlatform@master] Rename MetricsPlatformEnable config variable

https://gerrit.wikimedia.org/r/1111254

hi @phuedx I asked this in one of your patches -- do we want to replace occurrences of Metrics Platform with Experiment Platform even tho the extension is still called Metrics Platform for now?

hi @phuedx I asked this in one of your patches -- do we want to replace occurrences of Metrics Platform with Experiment Platform even tho the extension is still called Metrics Platform for now?

Good question. I've responded inline. In short, no – it might be confusing to developers outside of the Experiment Platform team.

Change #1111254 merged by jenkins-bot:

[mediawiki/extensions/MetricsPlatform@master] Rename MetricsPlatformEnable config variable

https://gerrit.wikimedia.org/r/1111254

Change #1112770 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] testwiki: Enable Metrics Platform configs fetching

https://gerrit.wikimedia.org/r/1112770

Change #1112770 abandoned by Phuedx:

[operations/mediawiki-config@master] testwiki: Enable Metrics Platform configs fetching

Reason:

Not necessary as the train will start rolling tomorrow (21/01/25) at 0900 UTC

https://gerrit.wikimedia.org/r/1112770