Page MenuHomePhabricator

Article Feedback Page Layout and "Look and Feel" Tweaks
Closed, ResolvedPublic

Description

Please switch 'Sort by' with 'Showing' in the toolbar, as outlined in the feedback page requirements:
http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_Page_for_Editors

Also, please change the wording of the Relevance filter to say "Most Relevant' instead of 'Relevant' in the drop-down menu.

Lastly, we need to make the tools panel wider in the right sidebar, because the words 'Unrequest Oversight' cause that function to wrap up into two lines, as shown in the attached screenshot (Firefox).


Version: unspecified
Severity: normal

Details

Reference
bz36188

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 12:20 AM
bzimport added a project: ArticleFeedbackv5.
bzimport set Reference to bz36188.

Created attachment 10454
AFT5 Tool Panel 'Unrequest Oversight' Line Wrap-around Bug (Firefox)

Attached:

A couple other presentational issues of the feedback page:

  • Instead of saying 'View article revision', let's say '(see old article)' in small text font next to the time stamp, as shown on our feature requirements page (2nd post from the top):

http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_Page_for_Editors

  • Would it be possible to make the 'Featured' and 'Resolved' labels be right-aligned?
  • When displaying a gray mask for hidden posts, can we add a text link called "View contents >>" after the words "This post was hidden by an authorized editor?" (this would cause the gray mask to reveal its contents to authorized users, in the same way as if they had clicked on the gray mask). It's particularly important to make this work on the permalink page, so an editor that hasn't been trained knows they can click on the gray mask to reveal its contents).
  • On the permalink page, let's replace the wording "Go to feedback list' with "View feedback page" -- also, make the font size at least 2-3 points larger (the equivalent of 16 and 18 points) and add 2-3 pixels of white space above it, so it stands out more.

Feel free to break out these requests into separate tickets, as needed. They all seem presentational to me, so I thought they could be done by one person in one work session, but I defer to you on actual implementation. Thanks.

elizabeth wrote:

Most of these changes have been made and are pushed to omniti - still remaining are the red view contents marker on the masked area and right aligning resolved and featured labels

Thanks, guys!

I appreciate all the changes you have made so far.

The items that now remain are:

  • make the 'Featured' and 'Resolved' labels be right-aligned (Brandon suggested we create a third, middle column between the comments on the left and the tools on the right, to list both labels, as well as the link to the old article and 'Flag this post')
  • add a text pseudo-link called "View contents >>" after the words "This post was hidden by an authorized editor"

... and this new request:

  • Remove the line "This is a prototype. Please do not use it unless you have been invited to." below the title.

Thanks!

Here are few minor copy or layout tweaks, please:

  • Let's add more spacing between 'Showing' and 'Sort by' -- about the same distance as between 'x feedback posts' and '85% found what they were looking for' in the line above.
  • Let's say 'Helpfulness' instead of 'Helpful' in the 'Sort by' section
  • Let's only have a couple spaces between the timestamp of a post and '(see old article)', so they are closer together (instead of the current tab-like separation)
  • Use a green color (instead of red) for all the activity notices which have a 'positive' outcome (e.g. un-mark as resolved, un-hide, decline oversight, un-oversight). Also, is it possible to not display these 'positive' notices on the main feedback page at all? (only in the activity logs)
  • Add horizontal gray dividers between tool panel sections, as shown on this mockup:

http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_Page_for_Editors

Feel free to open up separate Bugzilla tickets, as needed, if any of these requests are complex enough to warrant it.

yoni wrote:

Prototype notification line is to be removed. All other requests from 2012-04-25 are scheduled for the next release.

Thanks, Yoni.

Let's aim to implement the easy changes in coming days.

Also, I want to clarify that the 'View contents >>' request from 4-24 above should not be 'red' as suggested by Elizabeth above, but should be blue, as if it were a link.

Much appreciated.

Fabrice

Padding for the feedback text needs to be fixed. Right now it flows underneath the tools panel so you can't read all of it.

To fix this, change...
.articleFeedbackv5-feedback blockquote {
padding: 0 180px 0 0;

to...
.articleFeedbackv5-feedback blockquote {
padding: 0 210px 0 0;

Thanks, Kaldari, that's a great suggestion!

Yoni, would you like us to open up a separate ticket for this comment text issue, or is this fine to include it on this ticket?

Also, here are a few more simple presentational issues that have come up based on today's feedback:

  • Add a gray neutral face icon before posts where the person did not answer whether or not they found what they were looking for (Heather already sent that icon to Reha and Elizabeth, but I can resend it if you like).
  • Number of feedback posts at the top of the page should have a comma when exceeding 1,000 posts (1,060 posts instead of 1060 posts) -- when we do the internationalization, we can turn this into a a context-sensitive setting for U.S. users only.
  • Link username/IP link to their talk page if they don't have a user page but have a talk page (instead of linking to their contribution page, which should be the last resort). So the logic should be as follows:
  • if the user has filled in their profile, link there;
  • if the user has not filled in their profile, but have an active talk page, link there;
  • if the user has not filled in their profile or have an active talk page, link to their contribution page

Again, please let me know if you would like me to open up separate Bugzilla tickets for any of these requests, if you think they are complex enough to warrant it.

For this ticket, here are some requests that are higher priority than the other presentational tweaks listed above:

  • add a text pseudo-link called "View contents >>" after the words "This post was hidden by an authorized editor"
  • add horizontal gray dividers between tool panel sections
  • add a gray neutral face icon before posts where the person did not answer
  • add a text pseudo-link called "View contents >>" after the words "This post

was hidden by an authorized editor"
code pushed to omniti branch & on gerrit: https://gerrit.wikimedia.org/r/6536

  • add horizontal gray dividers between tool panel sections

code pushed to omniti branch & on gerrit: https://gerrit.wikimedia.org/r/6537

reha wrote:

Fixed and submitted to gerrit:

https://gerrit.wikimedia.org/r/7151