Yeah, this is a known issue. It's part of the reason why I first suggested a simple scrollable list in T369182: to avoid similar issues. My understanding is that we would live with the ugliness until the Special:EventDetails is redesigned with a new layout to accommodate the list of wikis. There should have been a task about it, as a follow-up of T369182, but I can't find it. @cmelo @gonyeahialam any ideas on where that task might be?

Okay thanks @Daimona. This button just became sticky as this is not in master yet - seems like a regression to me? Is there a reason it was changed? It does seem worse to me than having it just at the bottom of the list scrollable list. Here's the diff from the pixel test

In T381898#10394606, @vaughnwalters wrote:

Okay thanks @Daimona. This button just became sticky as this is not in master yet - seems like a regression to me? Is there a reason it was changed? It does seem worse to me than having it just at the bottom of the list scrollable list.

Yep, it was changed to prevent the height of the box from growing indefinitely when there are many wikis selected. The box is scrollable now.

It looks like this max height that is causing the problem now where it currently isn't in prod?

.mw-body .ext-campaignevents-eventdetails-panel {
    max-height: 32em; }

In T381898#10394628, @Daimona wrote:

In T381898#10394606, @vaughnwalters wrote:

Okay thanks @Daimona. This button just became sticky as this is not in master yet - seems like a regression to me? Is there a reason it was changed? It does seem worse to me than having it just at the bottom of the list scrollable list.

Yep, it was changed to prevent the height of the box from growing indefinitely when there are many wikis selected. The box is scrollable now.

I wonder how often it will be that there will be many wikis selected?

If we don't anticipate many wikis being selected often, maybe we could revert this since it does affect the UI of Special:EventDetails most of the time? Or... if we don't want to revert this then we can just mark this ticket as declined. Thoughts @ifried @gonyeahialam ?

Hi @ vaughnwalters and @Daimona, as @Daimona already said there is (or at list we should have) a task related to changes needed on the event details, to summarize, the layout (meaning the order the fields appear) will change, @gonyeahialam will work on it, but I couldn't find it too.

Also, this will only happen on some devices, we could solve this by adding different values on:

@media ( min-width: @min-width-breakpoint-tablet ) {
	.mw-body .ext-campaignevents-eventdetails-panel {
		max-height: 32em;
		overflow-y: auto;
	}
}`

We are using the default ones provided by the MediaWiki CSS variables, we could play with the possible values to try to fix it, but there is no guarantee, the closest value I could test to make it work on most scenarios was 950, the @min-width-breakpoint-tablet is something like 640.

In T381898#10394797, @cmelo wrote:

Also, this will only happen on some devices, we could solve this by adding different values on: [...]
We are using the default ones provided by the MediaWiki CSS variables, we could play with the possible values to try to fix it, but there is no guarantee, the closest value I could test to make it work on most scenarios was 950, the @min-width-breakpoint-tablet is something like 640.

That wouldn't fix it though. It largely depends on the exact event data (and also things like font / font size). I had this same bug for a few events in my local with the original, custom breakpoints.

Regarding the ticket for improvement, the last decision on it was that Ilana and I would discuss about it but we haven't done that yet. I don't think a ticket was created for it.

Can we not just wrap the button in a footer section and make the content scroll behind it? Similar to the modal popup

In T381898#10400076, @MHorsey-WMF wrote:

Can we not just wrap the button in a footer section and make the content scroll behind it? Similar to the modal popup

I think it is a good idea, what do you think @ifried @gonyeahialam

Thanks for this great suggestion, @MHorsey-WMF! I think this solution makes sense (cc @cmelo).

Change #1178135 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Fix 'View event page' button overlap on mobile EventDetails

https://gerrit.wikimedia.org/r/1178135

Change #1178135 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix 'View event page' button overlap on page Special:EventDetails

https://gerrit.wikimedia.org/r/1178135

✅ The View event page button should not overlap the content.

Full size	mobile

Niiiiice 🎉

Sending to design sign off and you can test with this event: https://en.wikipedia.beta.wmcloud.org/wiki/Special:EventDetails/732

hi @vaughnwalters thank you so much! i think the full size screenshot wasn't attached, can you re-attach it pls? and the beta link is not working for me, do you know why that might be happening? apologies!

In T381898#11313522, @JFernandez-WMF wrote:

hi @vaughnwalters thank you so much! i think the full size screenshot wasn't attached, can you re-attach it pls? and the beta link is not working for me, do you know why that might be happening? apologies!

Hello hello, I have attached the full size screenshot now! And the beta link is working for me correctly right now, is it still not working for you? It not, then the full size gif and the mobile screenshot should still be enough. Thank you!

thank you! nice, this looks good to me. sending to prod sign off