Page MenuHomePhabricator

Expanding/Collapsing sections is slow
Closed, DeclinedPublic

Description

Even on fast phones like the Nexus S using the native browser expanding/collapsing sections is sluggish.


Version: unspecified
Severity: normal

Details

Reference
bz36190

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:20 AM
bzimport set Reference to bz36190.
bzimport added a subscriber: Unknown Object (MLST).

Also true for the Galaxy Nexus (ice cream sandwich).

This seems to be effecting ICS pre version 4.0.3
See http://code.google.com/p/android/issues/detail?id=24833

Tomasz - I'm guessing your Nexus S is also on ICS ?

We could disable animations for this browser... alternatively I could look into scraping the use of transitions altogether and rewriting toggling to not use them.

I'm testing on a Nexus S running Android 2.3.6 with the native browser

I got Tomasz to test this and it seems his problem was solved by https://gerrit.wikimedia.org/r/5801

To deal with ICS which checking with Brion and Arthur seems to be specific to 4.0.2 (see above android issue) https://gerrit.wikimedia.org/r/5873 seems to take care of this. Arthur / Brion please confirm this and reopen ticket if this is not the case.

This fix takes away the toggleable sections, so there is definitely no more flicker :p I'm having a hard time deciding what is worse - the flicker or an intolerably long article. The San Francisco article feels utterly unnavigable to me without folded sections. Is it possible to toggle the sections but just have no animation?

I thought that's what I did.. I've obviously done it wrong in state of tiredness... will fix tomorrow!

Max height should only be applied to .togglefix I think this was a bad merge.

Jon, even with that fix the sections are not toggle-able :( I am seeing just the full article.

The issue I mentioned with sections being non-toggle-able was the result of another bug (https://bugzilla.wikimedia.org/show_bug.cgi?id=36306) which has been resolved in master. The aforementioned changes though still do not resolve the flickering issue on ICS (4.0.2) when toggling the sections. However, since this is due to a bug in ICS, perhaps there's not much else that we can do until Google and cell providers push updates to 4.0.3/4.0.4.

Arthur I checked this with brion
If you are still getting this in the latest master can you

  • reopen this
  • put at the top of application.js on a dev version the following code:

var ua = navigator.userAgent;
alert(ua);

  • comment on the ticket with what this alerts

I'm hoping it's a cache issue and if not that something to do with a slightly different user agent...

Thanks!

Do we have any metrics for this? If not, maybe add to T94752.