Page MenuHomePhabricator
Create Task
Maniphest T381912

Review dead code relating to OOUI popup widget
Closed, ResolvedPublicBUG REPORT
Actions

Description

Recently the ability for anonymous users to disable multimedia viewer was removed. Some code associated with this feature does not look like it was updated or removed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove obsolete Config.setMediaViewerEnabledOnClick and MultimediaViewerBootstrap.showStatusInfomediawiki/extensions/MultimediaViewermaster+2 -215
Remove obsolete MultimediaViewerBootstrap.showStatusInfomediawiki/extensions/MultimediaViewermaster+0 -91
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 10 2024, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2024, 7:21 PM
Jdlrobson triaged this task as Medium priority.Dec 10 2024, 7:22 PM
Jdlrobson added a subscriber: simon04.

FYI @simon04 I think this relates to T77349?

Jdlrobson-WMF moved this task from Backlog to Triaged on the MediaViewer board.Apr 24 2025, 2:50 PM
simon04 claimed this task.May 2 2026, 10:29 AM
simon04 updated the task description. (Show Details)
gerritbot added a comment.May 2 2026, 10:32 AM

Change #1281742 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Remove obsolete Config.setMediaViewerEnabledOnClick

https://gerrit.wikimedia.org/r/1281742

gerritbot added a project: Patch-For-Review.May 2 2026, 10:32 AM
gerritbot added a comment.May 2 2026, 10:42 AM

Change #1281743 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Remove MultimediaViewerBootstrap.showStatusInfo

https://gerrit.wikimedia.org/r/1281743

gerritbot added a comment.May 2 2026, 12:12 PM

Change #1281743 abandoned by Simon04:

[mediawiki/extensions/MultimediaViewer@master] Remove obsolete MultimediaViewerBootstrap.showStatusInfo

https://gerrit.wikimedia.org/r/1281743

simon04 changed the task status from Open to In Progress.May 2 2026, 12:37 PM
simon04 added a project: Wikimedia-Hackathon-2026.
TheDJ closed this task as Resolved.May 2 2026, 7:46 PM
gerritbot added a comment.May 2 2026, 7:55 PM

Change #1281742 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Remove obsolete Config.setMediaViewerEnabledOnClick and MultimediaViewerBootstrap.showStatusInfo

https://gerrit.wikimedia.org/r/1281742

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 2 2026, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 2 2026, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits