Page MenuHomePhabricator
Create Task
Maniphest T381943

Swagger probe test for page fetch API is failing
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Description

CXServer production logs has many entries as shown below:

image.png (523×1 px, 135 KB)

This is originated form the x-amples entries in swagger spec. https://github.com/wikimedia/mediawiki-services-cxserver/blob/master/spec.yaml#L99

However, the space in the title is causing the issue. In the same spec.yaml, the same title is present without '_' too. That generated rest.php URLs like this:
https://en.wikipedia.org/w/rest.php/v1/page/User%3ABSitzmann%2B(WMF)%2FMCS%2FTest%2FFrankenstein/html?

Which returns error: "The specified page (User:BSitzmann+(WMF)/MCS/Test/Frankenstein) does not exist"

Either we need to update spec.yaml to use underscore consistantly or make sure titles are normalized as required(this is preferred solution)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update cxserver to 2025-02-13-102531-productionoperations/deployment-chartsmaster+1 -1
Error middleware: Log entire HTTP error objectmediawiki/services/cxservermaster+10 -7
Update cxserver to 2025-02-12-075258-productionoperations/deployment-chartsmaster+1 -1
Remove space character in example titlesmediawiki/services/cxservermaster+2 -2
MWPageLoader: Avoid logging 404 errorsmediawiki/services/cxservermaster+41 -9
Customize query in gerrit

Related Objects

Event Timeline

santhosh created this task.Dec 11 2024, 7:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2024, 7:23 AM
santhosh renamed this task from Swagger proble test for page fetch API is failing to Swagger probe test for page fetch API is failing.Dec 11 2024, 7:23 AM
KartikMistry added subscribers: akosiaris, KartikMistry.Dec 11 2024, 8:30 AM
Pginer-WMF triaged this task as Medium priority.Dec 12 2024, 8:56 AM
Pginer-WMF added a project: LPL Essential (LPL Essential 2024 Nov-Jan).
Pginer-WMF moved this task from Backlog to Article loading on the CX-cxserver board.
Nikerabbit set the point value for this task to 4.Dec 12 2024, 12:41 PM
Nikerabbit moved this task from Backlog to Ready for dev on the LPL Essential (LPL Essential 2024 Nov-Jan) board.
Wangombe changed the task status from Open to In Progress.Dec 16 2024, 11:40 AM
Wangombe claimed this task.
Wangombe moved this task from Ready for dev to In Progress on the LPL Essential (LPL Essential 2024 Nov-Jan) board.
Wangombe added a subscriber: ngkountas.Jan 8 2025, 7:50 AM

@santhosh I cannot reproduce this issue locally using the /v1/page/{language}/{title} endpoint. I don't think the User namespace has anything to do with the errors, does it? @ngkountas submitted a patch to fix this normalization issue in T357769. The regex responsible for normalization of the text covers all possible 'white space' variations.

abi_ moved this task from In Progress to Needs Review on the LPL Essential (LPL Essential 2024 Nov-Jan) board.Jan 23 2025, 5:02 PM
Nikerabbit mentioned this in T377966: Make cxserver Logstash logs readable and reliable.Feb 5 2025, 12:50 PM
Wangombe added a comment.Feb 6 2025, 10:54 AM

T382294 --> The review of this patch should resolve this issue.

gerritbot added a comment.Feb 10 2025, 6:37 AM

Change #1118378 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/services/cxserver@master] Remove space character in example titles

https://gerrit.wikimedia.org/r/1118378

gerritbot added a project: Patch-For-Review.Feb 10 2025, 6:37 AM
gerritbot added a comment.Feb 10 2025, 7:29 AM

Change #1118378 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Remove space character in example titles

https://gerrit.wikimedia.org/r/1118378

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2025, 7:30 AM
abi_ subscribed.Feb 11 2025, 10:23 AM

Which returns error: "The specified page (User:BSitzmann+(WMF)/MCS/Test/Frankenstein) does not exist"

We're not sure what's triggering this request with the invalid page name. Either way I don't think we should bother logging 404 errors.

gerritbot added a comment.Feb 11 2025, 1:09 PM

Change #1118800 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/services/cxserver@master] MWPageLoader: Avoid logging 404 errors

https://gerrit.wikimedia.org/r/1118800

gerritbot added a project: Patch-For-Review.Feb 11 2025, 1:09 PM
gerritbot added a comment.Feb 12 2025, 7:52 AM

Change #1118800 merged by jenkins-bot:

[mediawiki/services/cxserver@master] MWPageLoader: Avoid logging 404 errors

https://gerrit.wikimedia.org/r/1118800

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2025, 8:30 AM
gerritbot added a comment.Feb 12 2025, 8:49 AM

Change #1119052 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2025-02-12-075258-production

https://gerrit.wikimedia.org/r/1119052

gerritbot added a project: Patch-For-Review.Feb 12 2025, 8:49 AM
abi_ moved this task from Needs Review to Pending Deployment on the LPL Essential (LPL Essential 2024 Nov-Jan) board.Feb 12 2025, 2:00 PM
gerritbot added a comment.Feb 13 2025, 4:09 AM

Change #1119052 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2025-02-12-075258-production

https://gerrit.wikimedia.org/r/1119052

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 4:30 AM
Stashbot added a comment.Feb 13 2025, 4:45 AM

Mentioned in SAL (#wikimedia-operations) [2025-02-13T04:45:46Z] <kart_> Updated cxserver to 2025-02-12-075258-production (T381943)

abi_ closed this task as Resolved.Feb 13 2025, 7:18 AM
abi_ moved this task from Pending Deployment to Done on the LPL Essential (LPL Essential 2024 Nov-Jan) board.
In T381943#10538686, @gerritbot wrote:

Change #1118800 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/services/cxserver@master] MWPageLoader: Avoid logging 404 errors

https://gerrit.wikimedia.org/r/1118800

The above patch has been deployed to production and we are no longer seeing 404 errors being logged to Logstash.

gerritbot added a comment.Feb 13 2025, 8:35 AM

Change #1119454 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/services/cxserver@master] Error middleware: Log enitre HTTP error object

https://gerrit.wikimedia.org/r/1119454

gerritbot added a project: Patch-For-Review.Feb 13 2025, 8:35 AM
gerritbot added a comment.Feb 13 2025, 10:25 AM

Change #1119454 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Error middleware: Log entire HTTP error object

https://gerrit.wikimedia.org/r/1119454

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 10:30 AM
gerritbot added a comment.Feb 13 2025, 12:06 PM

Change #1119478 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2025-02-13-102531-production

https://gerrit.wikimedia.org/r/1119478

gerritbot added a project: Patch-For-Review.Feb 13 2025, 12:06 PM
gerritbot added a comment.Feb 13 2025, 12:53 PM

Change #1119478 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2025-02-13-102531-production

https://gerrit.wikimedia.org/r/1119478

Stashbot mentioned this in T386231: /v2/translate API fails to perform any translation when no provider is provided.Feb 13 2025, 1:04 PM

Mentioned in SAL (#wikimedia-operations) [2025-02-13T13:04:01Z] <kart_> Updated Cxserver to 2025-02-13-102531-production (T381943, T386231)

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2025, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits