Page MenuHomePhabricator
Create Task
Maniphest T382003

(mw.track) Migrate timing.growthExperiments.* to statslib
Closed, ResolvedPublic
Actions

Description

To complete the migration to statslib client code also needs to be updated.

GrowthExperiments client code contains the following timing calls to migrate:

  • /extensions/GrowthExperiments/modules/ext.growthExperiments.DataStore/GrowthTasksApi.js
    • 496 timing.growthExperiments.specialHomepage.growthTasksApi
  • /extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.Impact/App.vue
    • 80 timing.growthExperiments.newImpact.' + inject( 'RENDER_MODE' ) + '.mounted
  • /extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.SuggestedEdits/index.js
    • 70 timing.growthExperiments.specialHomepage.modules.suggestedEditsTimeToInteractive
    • 77 timing.growthExperiments.specialHomepage.modules.suggestedEditsTimeToInteractive.serverSideStartInclusive
    • 85 timing.growthExperiments.specialHomepage.modules.suggestedEditsLoadingComplete
  • /extensions/GrowthExperiments/modules/ext.growthExperiments.SuggestedEditSession/index.js
    • 627 timing.growthExperiments.suggestedEdits.taskEditorReady. + this.taskType
    • 646 timing.growthExperiments.suggestedEdits.guidanceShown. + this.taskType
  • /extensions/GrowthExperiments/modules/homepage.init.js
    • 22 timing.growthExperiments.specialHomepage.navigationDuration
    • 29 timing.growthExperiments.specialHomepage.navigationTransferSize
    • 35 timing.growthExperiments.specialHomepage.paintStartTime

Now that T355837 is resolved, this task is actionable. Example of migration: mediawiki/core/+/1105813

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
stats(SuggestedEdits): avoid tracking negative tti durationsmediawiki/extensions/GrowthExperimentsmaster+27 -14
fix(logging): temporary subscribe to analytics uncaught errorsmediawiki/extensions/GrowthExperimentsmaster+35 -30
Log more data if serverDuration is invalidmediawiki/extensions/GrowthExperimentsmaster+32 -16
homepage: Add `homepage_transfersize_bytes_total` metricmediawiki/extensions/GrowthExperimentsmaster+15 -1
homepage: Add `homepage_transfersize_bytes_total` metricmediawiki/extensions/GrowthExperimentswmf/1.44.0-wmf.23+15 -1
homepage: Add `homepage_transfersize_bytes_total` metricmediawiki/extensions/GrowthExperimentswmf/1.44.0-wmf.22+15 -1
homepage: rename _duration to _loadeventendmediawiki/extensions/GrowthExperimentsmaster+11 -9
fix(stats): fix invalid label value for task_typemediawiki/extensions/GrowthExperimentsmaster+24 -6
statslib(Impact): fix invalid label value for render_modemediawiki/extensions/GrowthExperimentsmaster+1 -1
metrics: Migrate GrowthExperiments client code to statslibmediawiki/extensions/GrowthExperimentsmaster+90 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Sgs triaged this task as Medium priority.Dec 11 2024, 4:37 PM
Sgs moved this task from Backlog to Statslib migration on the Growth-Team (Maintenance) board.
Sgs updated the task description. (Show Details)Jan 7 2025, 11:40 AM
Sgs updated the task description. (Show Details)
Sgs assigned this task to Cyndymediawiksim.Jan 7 2025, 4:52 PM
Sgs edited projects, added Growth-Team (Current Sprint); removed Growth-Team (Maintenance).
Sgs raised the priority of this task from Medium to High.Jan 7 2025, 5:05 PM
gerritbot added a comment.Jan 9 2025, 9:59 AM

Change #1109391 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] metrics: Migrate GrowthExperiments client code to statslib

https://gerrit.wikimedia.org/r/1109391

gerritbot added a project: Patch-For-Review.Jan 9 2025, 9:59 AM
Cyndymediawiksim moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.Jan 9 2025, 10:02 AM
Urbanecm_WMF moved this task from Code Review to Doing on the Growth-Team (Current Sprint) board.Jan 11 2025, 6:22 PM
Urbanecm_WMF subscribed.

Moving back to Doing, as the patch has a V-1 and is not mergeable yet.

Michael added a subtask: T348796: MediaWiki: Define new metric type - Histogram.Jan 14 2025, 2:48 PM
Michael mentioned this in T348796: MediaWiki: Define new metric type - Histogram.
Cyndymediawiksim moved this task from Doing to QA on the Growth-Team (Current Sprint) board.Jan 20 2025, 4:26 PM
Cyndymediawiksim moved this task from QA to Code Review on the Growth-Team (Current Sprint) board.
Cyndymediawiksim moved this task from Code Review to Blocked / Needs Work on the Growth-Team (Current Sprint) board.Jan 22 2025, 3:46 PM
Sgs renamed this task from Migrate GrowthExperiments client code to statslib to (mw.track) Migrate timing.growthExperiments.* to statslib.Jan 22 2025, 6:05 PM
Sgs mentioned this in T383953: Statsv support for timer metrics.
Michael reopened subtask T383563: mw.track: support for histogram metrics as Open.Feb 7 2025, 12:50 PM
Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Current Sprint) board.Feb 11 2025, 9:23 AM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Feb 11 2025, 4:53 PM
Sgs moved this task from Code Review to Doing on the Growth-Team (Current Sprint) board.Feb 13 2025, 2:27 PM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Feb 17 2025, 8:51 AM
Sgs moved this task from Code Review to Doing on the Growth-Team (Current Sprint) board.Mar 11 2025, 5:31 PM
Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Mar 12 2025, 3:07 PM
gerritbot added a comment.Mar 13 2025, 5:26 PM

Change #1109391 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] metrics: Migrate GrowthExperiments client code to statslib

https://gerrit.wikimedia.org/r/1109391

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 5:33 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 6:00 PM
Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Mar 17 2025, 7:36 AM
gerritbot added a comment.Mar 19 2025, 3:39 PM

Change #1129303 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] statslib(Impact): fix invalid label value for render_mode

https://gerrit.wikimedia.org/r/1129303

gerritbot added a project: Patch-For-Review.Mar 19 2025, 3:39 PM
Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Current Sprint) board.Mar 20 2025, 1:20 AM
gerritbot added a comment.Mar 20 2025, 7:10 PM

Change #1129303 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] statslib(Impact): fix invalid label value for render_mode

https://gerrit.wikimedia.org/r/1129303

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2025, 7:31 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 20 2025, 8:00 PM
gerritbot added a comment.Mar 26 2025, 9:41 AM

Change #1131281 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(stats): fix invalid label value for task_type

https://gerrit.wikimedia.org/r/1131281

gerritbot added a project: Patch-For-Review.Mar 26 2025, 9:41 AM
Etonkovidova subscribed.Mar 26 2025, 3:38 PM

Testing notes: Currently - testwiki wmf.22 - the following error is displayed for &gesuggestededit=1&veaction=edit:
Invalid label value for mediawiki_GrowthExperiments_task_editor_ready_seconds task_type "link-recommendation"

Etonkovidova added a comment.Mar 26 2025, 11:08 PM

Are those logstash reports (https://logstash.wikimedia.org/goto/a5e8693844fc133fe7d698f7cebd7c46) related to the issue?

normalized_message": "Invalid timing value for mediawiki_GrowthExperiments_suggested_edits_server_tti_seconds"

Seems to started around March 21/2025 - https://logstash.wikimedia.org/goto/76e2d3c791caf528cfed723cd47e0440

gerritbot added a comment.Mar 27 2025, 10:20 AM

Change #1131281 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(stats): fix invalid label value for task_type

https://gerrit.wikimedia.org/r/1131281

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2025, 10:31 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 27 2025, 11:00 AM
gerritbot added a comment.Mar 27 2025, 9:04 PM

Change #1131821 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/GrowthExperiments@master] homepage: Add `homepage_transfersize_bytes_bucket_total` metric

https://gerrit.wikimedia.org/r/1131821

gerritbot added a project: Patch-For-Review.Mar 27 2025, 9:04 PM
gerritbot added a comment.Mar 27 2025, 9:18 PM

Change #1131823 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/GrowthExperiments@master] homepage: rename _duration to _loadeventend

https://gerrit.wikimedia.org/r/1131823

gerritbot added a comment.Mar 28 2025, 12:01 PM

Change #1131823 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] homepage: rename _duration to _loadeventend

https://gerrit.wikimedia.org/r/1131823

Michael subscribed.Mar 28 2025, 5:51 PM
gerritbot added a comment.Apr 1 2025, 1:32 PM

Change #1131821 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] homepage: Add `homepage_transfersize_bytes_total` metric

https://gerrit.wikimedia.org/r/1131821

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 1 2025, 2:00 PM
gerritbot added a comment.Apr 1 2025, 2:22 PM

Change #1133157 had a related patch set uploaded (by Michael Große; author: Krinkle):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.22] homepage: Add `homepage_transfersize_bytes_total` metric

https://gerrit.wikimedia.org/r/1133157

gerritbot added a comment.Apr 1 2025, 2:23 PM

Change #1133158 had a related patch set uploaded (by Michael Große; author: Krinkle):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.23] homepage: Add `homepage_transfersize_bytes_total` metric

https://gerrit.wikimedia.org/r/1133158

gerritbot added a comment.Apr 1 2025, 8:28 PM

Change #1133157 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.22] homepage: Add `homepage_transfersize_bytes_total` metric

https://gerrit.wikimedia.org/r/1133157

gerritbot added a comment.Apr 1 2025, 8:28 PM

Change #1133158 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.23] homepage: Add `homepage_transfersize_bytes_total` metric

https://gerrit.wikimedia.org/r/1133158

Stashbot mentioned this in T390642: Non-functional WikiLove icon showing on user pages on mobile.Apr 1 2025, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:29:58Z] <taavi@deploy1003> Started scap sync-world: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]]

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 8:31 PM
Stashbot added a comment.Apr 1 2025, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:37:19Z] <taavi@deploy1003> migr, taavi: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 1 2025, 8:46 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:46:57Z] <taavi@deploy1003> Finished scap sync-world: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]] (duration: 16m 59s)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 1 2025, 9:00 PM
Etonkovidova added a comment.Apr 2 2025, 10:24 PM

There are still some error reports (much less though than before) for wmf.23 -https://logstash.wikimedia.org/goto/88305b0939400634c82cf8628c31e62d.

Michael added a comment.Apr 3 2025, 4:25 PM
In T382003#10706229, @Etonkovidova wrote:

There are still some error reports (much less though than before) for wmf.23 -https://logstash.wikimedia.org/goto/88305b0939400634c82cf8628c31e62d.

I'm not sure what is going on there. The error message is as follows:

Invalid timing value for mediawiki_GrowthExperiments_suggested_edits_server_tti_seconds

But the value it is logging is:

ext.growthExperiments.Homepage.SuggestedEdits/index.js
serverDuration = mw.now() - mw.config.get( 'GEHomepageStartTime' );

Is GEHomepageStartTime sometimes not set to something sensible?

gerritbot added a comment.Apr 3 2025, 6:19 PM

Change #1133998 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Log more data if serverDuration is not a number

https://gerrit.wikimedia.org/r/1133998

gerritbot added a project: Patch-For-Review.Apr 3 2025, 6:19 PM
Michael moved this task from Test in Production to Code Review on the Growth-Team (Current Sprint) board.Apr 3 2025, 6:57 PM

I still don't understand what is going on, but added a bit more logging. Maybe it will tell us something useful.

Krinkle removed a subtask: T348796: MediaWiki: Define new metric type - Histogram.Apr 10 2025, 2:44 PM
Krinkle removed a subtask: T383563: mw.track: support for histogram metrics.
Krinkle mentioned this in T383563: mw.track: support for histogram metrics.Apr 10 2025, 2:48 PM
Etonkovidova added a comment.Apr 24 2025, 12:49 AM
In T382003#10710189, @Michael wrote:

I still don't understand what is going on, but added a bit more logging. Maybe it will tell us something useful.

The error seems to start on March 19/2025 - https://logstash.wikimedia.org/goto/fb0c2951523fbd34ff33e0823ed771c7. The rate of error has been about the same (high) since then

Screen Shot 2025-04-23 at 5.38.22 PM.png (642×2 px, 178 KB)

gerritbot added a comment.Apr 25 2025, 4:20 PM

Change #1133998 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Log more data if serverDuration is invalid

https://gerrit.wikimedia.org/r/1133998

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2025, 4:30 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.27; 2025-04-29); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Apr 25 2025, 5:00 PM
Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.May 6 2025, 12:12 PM
Sgs added a comment.EditedMay 6 2025, 12:13 PM

It seems the additional logging data change didn't work out as expected. It seems the error logger overwrites whatever error.error_context would initially have. I look into it.

Actually what happens is the catch clause is never executed because mw.track returns errors rather than throwing them. Working on a fix.

Cyndymediawiksim moved this task from QA to Code Review on the Growth-Team (Current Sprint) board.May 6 2025, 12:54 PM
gerritbot added a comment.May 6 2025, 1:28 PM

Change #1142597 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(logging): temporary subscribe to analytics uncaught errors

https://gerrit.wikimedia.org/r/1142597

gerritbot added a project: Patch-For-Review.May 6 2025, 1:28 PM
Sgs moved this task from Code Review to Blocked / Needs Work on the Growth-Team (Current Sprint) board.May 6 2025, 1:30 PM
gerritbot added a comment.May 9 2025, 1:22 PM

Change #1142597 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(logging): temporary subscribe to analytics uncaught errors

https://gerrit.wikimedia.org/r/1142597

Maintenance_bot removed a project: Patch-For-Review.May 9 2025, 1:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 9 2025, 2:00 PM
DMburugu moved this task from Blocked / Needs Work to QA on the Growth-Team (Current Sprint) board.May 13 2025, 2:49 PM
Sgs added a subtask: T394289: Invalid timing value for mediawiki_GrowthExperiments_suggested_edits_server_tti_seconds.May 14 2025, 10:56 AM
Sgs added a comment.May 15 2025, 10:49 AM
This comment was removed by Sgs.
gerritbot added a comment.May 19 2025, 9:41 AM

Change #1147720 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] stats(SuggestedEdits): avoid tracking negative tti durations

https://gerrit.wikimedia.org/r/1147720

gerritbot added a project: Patch-For-Review.May 19 2025, 9:41 AM
gerritbot added a comment.May 20 2025, 5:39 PM

Change #1147720 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] stats(SuggestedEdits): avoid tracking negative tti durations

https://gerrit.wikimedia.org/r/1147720

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 6:31 PM
Etonkovidova closed this task as Resolved.May 27 2025, 12:06 AM
Etonkovidova closed subtask T394289: Invalid timing value for mediawiki_GrowthExperiments_suggested_edits_server_tti_seconds as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits