Page MenuHomePhabricator
Create Task
Maniphest T382010

Fix IP reveal preference log entry for Special:Preferences/reset
Closed, ResolvedPublic
Actions

Description

Background

Special:Preferences/reset sets a user's preferences to their defaults. If the IP reveal preference was enabled, it will be set to disabled.

We are meant to log whenever the IP reveal preference is changed: T335365.

However, the log is not made if it is disabled via Special:Preferences/reset.

Acceptance criteria

The preference change is logged whether the preference is changed via manually changing it in Special:Preferences, or via Special:Preferences/reset.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
preferences: Trigger onSaveUserOptions after saving user preferencesmediawiki/coremaster+6 -0
preferences: Fix tests for Preferences hook handlermediawiki/extensions/CheckUsermaster+10 -13
preferences: Make sure IP reveal is contained in the modified optionsmediawiki/extensions/CheckUsermaster+271 -27
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Dec 11 2024, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2024, 5:03 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)); removed Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).Jan 17 2025, 12:24 PM
hector.arroyo changed the task status from Open to In Progress.Jan 28 2025, 10:18 AM
hector.arroyo claimed this task.
hector.arroyo moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.
hector.arroyo moved this task from Backlog to In progress on the Temporary accounts (Major pilot wiki deployment) board.Jan 28 2025, 10:20 AM
gerritbot added a comment.Jan 28 2025, 4:34 PM

Change #1114776 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/core@master] preferences: Trigger onSaveUserOptions after saving user preferences

https://gerrit.wikimedia.org/r/1114776

gerritbot added a project: Patch-For-Review.Jan 28 2025, 4:34 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)); removed Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)).Feb 10 2025, 10:01 AM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.
gerritbot added a comment.Feb 17 2025, 4:46 PM

Change #1120203 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] preferences: Make sure IP reveal is contained in the modified options

https://gerrit.wikimedia.org/r/1120203

gerritbot added a comment.Feb 17 2025, 4:47 PM

Change #1114776 abandoned by Harroyo-wmf:

[mediawiki/core@master] preferences: Trigger onSaveUserOptions after saving user preferences

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1120203

https://gerrit.wikimedia.org/r/1114776

hector.arroyo added a comment.Feb 18 2025, 1:08 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1120203 is now ready for review

hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 18 2025, 1:08 PM
gerritbot added a comment.Feb 18 2025, 4:56 PM

Change #1120203 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] preferences: Make sure IP reveal is contained in the modified options

https://gerrit.wikimedia.org/r/1120203

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Feb 18 2025, 5:00 PM
gerritbot added a comment.Feb 18 2025, 5:27 PM

Change #1120606 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] preferences: Fix tests for Preferences hook handler

https://gerrit.wikimedia.org/r/1120606

hector.arroyo moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 18 2025, 5:40 PM

A fix for this has been merged.

There is an additional patch pending review that only updates the unit tests, therefore I think this can already be moved forward for QA.

gerritbot added a comment.Feb 18 2025, 10:52 PM

Change #1120606 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] preferences: Fix tests for Preferences hook handler

https://gerrit.wikimedia.org/r/1120606

hector.arroyo removed a project: Patch-For-Review.Feb 19 2025, 2:27 PM
hector.arroyo edited projects, added Temporary accounts, CheckUser; removed Temporary accounts (Major pilot wiki deployment).Feb 19 2025, 3:14 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptFeb 19 2025, 3:14 PM
hector.arroyo edited projects, added Temporary accounts (Major pilot wiki deployment); removed Temporary accounts.Feb 19 2025, 3:16 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 20 2025, 11:31 AM
Djackson-ctr subscribed.

QA is completed, I have verified the new code has been implemented and is functioning as expected (The preference change is now being logged whether the preference is changed via manually changing it in Special:Preferences, or via Special:Preferences/reset)... Thank you @hector.arroyo.

image.png (770×1 px, 100 KB)

Dreamy_Jazz closed this task as Resolved.Feb 20 2025, 11:35 AM
hector.arroyo moved this task from Inbox to Engineering on the Trust and Safety Product Team board.May 30 2025, 9:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits