Page MenuHomePhabricator

Incrementally validate objects in the orchestrator; avoid duplicate validation
Closed, ResolvedPublic

Description

Description

Once an object has been validated, we can skip subsequent validations of the object (as its own type). This is true of sub-objects, too: within a ZWrapper, an already-validated object does not need to be validated again. This should save us lots of duplicate calculation.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • add a marker to ZWrapper (e.g. alreadyValid)
  • invalidate pre-validated ZWrappers whenever an internal object changes to an invalid state
  • short-circuit validation (as self-declared type) upon encountering an alreadyValid object
  • avoid validation as Z1 on alreadyValid objects (since, trivially, anything that validates as anything MUST also validate as Z1)

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task


Completion checklist

Event Timeline

Change #1117551 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-28-144249 to 2025-02-03-215824

https://gerrit.wikimedia.org/r/1117551

Change #1117551 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-28-144249 to 2025-02-03-215824

https://gerrit.wikimedia.org/r/1117551

@cmassaro does this one belong to the "Improve performance" epic?

ecarg claimed this task.
ecarg reassigned this task from ecarg to cmassaro.
ecarg subscribed.

confirmed w// Cory that this is finished

Change #1119094 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-11-155417.

https://gerrit.wikimedia.org/r/1119094

Change #1119094 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-11-155417.

https://gerrit.wikimedia.org/r/1119094