Maniphest T382034

Consolidate code to check ACL membership of acting user
Open, Stalled, LowPublic
Actions

Assigned To

Authored By

	Aklapper
	Dec 11 2024, 9:16 PM

Description

Looking into non-public T373358 reminded me again that I am duplicating code, and that is no good:

./libext/misc/src/policy/WMFSecurityPolicy.php:    $trusted_project_names = ["Trusted-Contributors", "WMF-NDA", "acl*sre-team", "acl*security"];
./libext/ava/src/herald/AntiVandalismAction.php:      $trusted_project_names = ["Trusted-Contributors", "WMF-NDA", "acl*sre-team", "acl*security"];
./phabricator/src/applications/maniphest/editor/ManiphestEditEngine.php:    // ["Trusted-Contributors", "WMF-NDA", "acl*sre-team", "acl*security"];
./phabricator/src/applications/maniphest/editor/ManiphestEditEngine.php:       'PHID-PROJ-fqb3bhereyljcqrsbju7', 'PHID-PROJ-koo4qqdng27q7r65x3cw']; // acl-security
./phabricator/src/applications/maniphest/editor/ManiphestEditEngine.php:       'PHID-PROJ-fqb3bhereyljcqrsbju7', 'PHID-PROJ-koo4qqdng27q7r65x3cw']; // acl*sre_team
./phabricator/src/applications/maniphest/editor/ManiphestEditEngine.php:      ['PHID-PROJ-rte2hubdntrhiwyoau6n', 'PHID-PROJ-ibxm3v6ithf3jpqpqhl7', // trusted-contributors
./phabricator/src/applications/maniphest/editor/ManiphestEditEngine.php:      ['PHID-PROJ-rte2hubdntrhiwyoau6n', 'PHID-PROJ-ibxm3v6ithf3jpqpqhl7', // wmf-nda

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Don't duplicate code from Security extension	repos/phabricator/phabricator!83	aklapper	T382034	wmf/stable

Customize query in GitLab

Related Objects

Mentioned Here: rPHAB9e3e4130a134: Revert "Expose the Edit Task Priority dropdown field only to trusted users"

Event Timeline

Aklapper created this task.Dec 11 2024, 9:16 PM

Aklapper triaged this task as Low priority.

Aklapper moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.Dec 17 2024, 2:29 PM

Aklapper updated the task description. (Show Details)Jan 23 2025, 1:55 PM

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/83

Don't duplicate code from Security extension

I prefer not to have AVA depend on libext/misc for a single call (also: potential re-use outside of Wikimedia) so I'll keep a copy of getProjectByName() in src/herald/AntiVandalismAction.php.
Which leaves us with https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/83 (though I wonder if a surrounding if (function_exists('fooo')) could be good?)

aklapper closed https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/83

Don't duplicate code from Security extension

Unneeded now due to https://phabricator.wikimedia.org/rPHAB9e3e4130a1344ff541c99427d7f962c752ff9429

Reopening for now as I proposed https://we.phorge.it/D26738 in upstream

Consolidate code to check ACL membership of acting userOpen, Stalled, LowPublicActions

Description

Details

Related Objects

Event Timeline

Consolidate code to check ACL membership of acting user
Open, Stalled, LowPublic
Actions