Maniphest T382045

[RUST STUFF]: Make executor_classes a non-public module
Open, Stalled, MediumPublic
Actions

Assigned To

Authored By

	cmassaro
	Dec 12 2024, 4:19 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Description

This should be an implementation detail.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

executor_classes need not be public

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Draft: clippy for abstraction work	repos/abstract-wiki/wikifunctions/function-evaluator!335	ecarg	grace/T382045/run-clippy	main
	Draft: refactor exposure of executor_classes	repos/abstract-wiki/wikifunctions/function-evaluator!296	ecarg	grace/T382045/rusticize-executor-classes	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		Jdforrester-WMF	T402957 [26Q2] Rust evaluator in production
		Stalled		ecarg	T382045 [RUST STUFF]: Make executor_classes a non-public module

Event Timeline

cmassaro created this task.Dec 12 2024, 4:19 AM

Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Dec 18 2024, 5:21 PM

Jdforrester-WMF triaged this task as Medium priority.Dec 18 2024, 5:30 PM

Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.

Hi @cmassaro I've been reading at how modules work in Rust today, is still ticket still valid to be taken on by a noob?

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/296

Draft: refactor exposure of executor_classes

we want to avoid having the executor class public chiefly to keep the WasiBuilder encapsulated
so whether we want to modularize the executors or create some wrapper function, the goal is to privatize the builder

jforrester updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/335

Draft: clippy for abstraction work

cmassaro added a parent task: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.May 21 2025, 12:26 PM

DSantamaria edited projects, added Abstract Wikipedia team (26Q1 (Jul–Sep)), Essential-Work; removed Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team.Jul 16 2025, 2:10 PM

DSantamaria moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

Jdforrester-WMF changed the task status from Open to In Progress.Jul 30 2025, 3:51 PM

Jdforrester-WMF moved this task from Ready to In Engineering on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

ecarg closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/335

Draft: clippy for abstraction work

working on security implementations atm

Do we want to re-scope this to Q2, or will we complete it this week?

In T382045#11229443, @Jdforrester-WMF wrote:

Do we want to re-scope this to Q2, or will we complete it this week?

I defer to @ecarg . If we don't have a decision by EOD, then I'm happy to roll this over to next quarter.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)); removed Abstract Wikipedia team (26Q1 (Jul–Sep)).Sep 30 2025, 6:41 PM

Jdforrester-WMF edited parent tasks, added: T402957: [26Q2] Rust evaluator in production; removed: T382433: Get the Rust prototype of the function-evaluator's executors into a state where it could be deployed.

ecarg mentioned this in rMSFEc286a90d8c6c: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….Oct 3 2025, 9:45 AM

ecarg mentioned this in rMSFE2fceae7c1e85: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….

ecarg mentioned this in rMSFE1337c3ed29fb: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….

ecarg mentioned this in rMSFEe52acac92245: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….

ecarg mentioned this in rMSFE9bb0fd0a394f: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….

ecarg mentioned this in rMSFE11b5e6944904: Merge branch 'grace/T382045/rusticize-executor-classes' of gitlab.wikimedia.org….

Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Oct 9 2025, 3:17 PM